From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 222E3C433EF for ; Mon, 8 Nov 2021 07:46:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A489D61059 for ; Mon, 8 Nov 2021 07:46:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A489D61059 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:43436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjzMW-0005EW-Sx for qemu-devel@archiver.kernel.org; Mon, 08 Nov 2021 02:46:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjzKz-0004Ae-NX for qemu-devel@nongnu.org; Mon, 08 Nov 2021 02:45:05 -0500 Received: from [2a00:1450:4864:20::333] (port=38885 helo=mail-wm1-x333.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjzKy-00085m-4K for qemu-devel@nongnu.org; Mon, 08 Nov 2021 02:45:05 -0500 Received: by mail-wm1-x333.google.com with SMTP id a20-20020a1c7f14000000b003231d13ee3cso14321366wmd.3 for ; Sun, 07 Nov 2021 23:45:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0BhT39p/mRAiYKm6I5GTZy3jNRSXfKLEtx4IOsK10Zo=; b=gH/H0Bumvwvt0OywnzaPimus9KzGddDUcU2CEppNKwoVjHGQODmxlWZ/J+eWjWDcGB 0GK80bakBzr04mLPY26IzUnJUrcgiV65B5n0yJzZw9OUvXnsHrRX/ztjCHgclDbqLxrQ LbojQ2oJhS0nJkbifY05ZAVi6Z08HY4W3Ap6fiS/dsDT6SveuwpURR3MTkgp0/3Zk6fJ K1hXcT2T37rFMTky6sdhQxQY2fUGb4H3oOIv3bnrfRvOqrdsQS0o6qSlP+do2HUDem0M X4w8632OjZ9KBrY4poogk5VMalWzWw9r1MfQLjGDdK72DM520AumbYo6ITxN6nfi+7H9 DaUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0BhT39p/mRAiYKm6I5GTZy3jNRSXfKLEtx4IOsK10Zo=; b=Rp6/wOj9kyrMnnX2a5MyvaIZravkLqZq2Dr011eApweHFBllBKiagfFX4/1zEmFFMf Lu+2Afr1XJV3gFXSv6GA1EVHq1ogI5SGblE/a4WLHmR/kmp0ED+7qDRTZ8As8tCgMxTB gHMgrqQ16Po51AqQSt7GoVDArlAPcbbO5MB9S7zdgnRwJBA3/WHPZeLbveQdP6hhli9u P9rD1SA5AOafuOgxMMJb99NbdXk4mWoCFbwkZ9GFxkmY4ZLeJKvZjMaIIEjC29abqVUC 8bXu/aAZ9xpM9tCbEn3RRAoZtiow00ucbtsFgBc7aUb33af7EQgWwIeVcQKvJAbxeD4V xTxA== X-Gm-Message-State: AOAM530YHEFtt2hJtz+eo8bArHm9CC7lte/73ZPcX13QmcWpVHQF9iZu c2MqQyTvZdaYb22IHHPbKNQSyVhLS3c= X-Google-Smtp-Source: ABdhPJx22sbZqkOKE9+tp+I7H2QMELBA7awIn2SjDdgLmswDX6bOEAdqYTDl0IFqe1bwjpA96jJh+g== X-Received: by 2002:a1c:770e:: with SMTP id t14mr49773624wmi.173.1636357038589; Sun, 07 Nov 2021 23:37:18 -0800 (PST) Received: from [192.168.1.36] (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id 10sm19158940wrb.75.2021.11.07.23.37.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Nov 2021 23:37:18 -0800 (PST) Message-ID: <39681686-e208-3c75-c0a5-ffda2482311f@amsat.org> Date: Mon, 8 Nov 2021 08:37:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2] linux-user: Mark cpu_loop() with noreturn attribute Content-Language: en-US To: Warner Losh References: <20211106113916.544587-1-f4bug@amsat.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::333 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x333.google.com X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-3.06, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bin Meng , Richard Henderson , QEMU Developers , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/7/21 01:39, Warner Losh wrote: > > > On Sat, Nov 6, 2021, 5:39 AM Philippe Mathieu-Daudé > wrote: > > cpu_loop() never exits, so mark it with QEMU_NORETURN. > > Reviewed-by: Richard Henderson > > Reviewed-By: Warner Losh > > Reviewed-by: Bin Meng > > Signed-off-by: Philippe Mathieu-Daudé > > --- > v2: > - rebased > - restricted to linux-user > > Supersedes: <20210905000429.1097336-1-f4bug@amsat.org > > > > > Reviewed-by: Warner Losh > > > bsd-user likely needs similar treatment, no? IIUC this thread, not yet (I didn't want to get into your refactor): https://lore.kernel.org/qemu-devel/CAFEAcA-f=n6XHp5Cj7=tH8NWO1GLA50i34=5GyaHrZELyr0bjw@mail.gmail.com/