From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D9D3C433FE for ; Mon, 17 Jan 2022 08:41:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238310AbiAQIlO (ORCPT ); Mon, 17 Jan 2022 03:41:14 -0500 Received: from gloria.sntech.de ([185.11.138.130]:58366 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238267AbiAQIlM (ORCPT ); Mon, 17 Jan 2022 03:41:12 -0500 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9NZP-0006T4-TT; Mon, 17 Jan 2022 09:40:55 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Brian Norris , Chen-Yu Tsai Cc: Liam Girdwood , Mark Brown , David Airlie , Daniel Vetter , linux-rockchip@lists.infradead.org, Lin Huang , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Rob Herring , Sandy Huang , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output Date: Mon, 17 Jan 2022 09:40:54 +0100 Message-ID: <3970568.xje1Q9F24u@diego> In-Reply-To: References: <20220114230209.4091727-1-briannorris@chromium.org> <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 17. Januar 2022, 08:44:37 CET schrieb Chen-Yu Tsai: > On Sat, Jan 15, 2022 at 7:03 AM Brian Norris wrote: > > > > Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > > switched the platform to SPDIF, but we didn't fix up the device tree. > > > > Drop the pinctrl settings, because the 'spdif_bus' pins are either: > > * unused (on kevin, bob), so the settings is ~harmless > > * used by a different function (on scarlet), which causes probe > > failures (!!) > > I suppose that means the default pinctrl should be dropped? Or maybe this > use case is the outlier. Up to Heiko? Interesting question. Right now it looks like Gru is the only one using spdif in that way, so I'd think dropping the pinctrl here is the "saner" option at this time ;-) I guess we can reevaluate if this becomes more widespread > > Fixes: b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > > Signed-off-by: Brian Norris > > Reviewed-by: Chen-Yu Tsai > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62011C433EF for ; Mon, 17 Jan 2022 08:41:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f+w3FBjdGoXwpempahBgUEnbvaw7fc+0lJ273Dq/c/0=; b=Va7qh5sXS5coIz Ma3ylA1vHwrbNeTKZW7wY1jY8RnHLq3itceSsp2hkrf/6tfhGZQb6sy24p3Xm7mF1f3/Ez+78lER2 Tav/yg+vjn+QG547g840zHLT95yFZ5DtreIvJif2O8HR+OInUDQrmedWQiSrI5Yqi5hBTt/WgteHe K3K+2P3fOKn8g6r3ao0sQ1Rqi9qc9rlfl+m15HhUwi2pos3ZwJHQstIYG8SwZ3kis1Pnr9HjlleaX FaNgQ9ylXKZdd3Q2umu+au6AMtPAsyMqZzo1LoXth+Jvfs3Dkl7wla9+kXIBqFu0ehI7ofhplygL8 3n1D3HKOj6os7aijvhmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9NZb-00E7Ll-Tp; Mon, 17 Jan 2022 08:41:07 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9NZV-00E7I0-Gm; Mon, 17 Jan 2022 08:41:05 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9NZP-0006T4-TT; Mon, 17 Jan 2022 09:40:55 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Brian Norris , Chen-Yu Tsai Cc: Liam Girdwood , Mark Brown , David Airlie , Daniel Vetter , linux-rockchip@lists.infradead.org, Lin Huang , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Rob Herring , Sandy Huang , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output Date: Mon, 17 Jan 2022 09:40:54 +0100 Message-ID: <3970568.xje1Q9F24u@diego> In-Reply-To: References: <20220114230209.4091727-1-briannorris@chromium.org> <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220117_004101_589251_6CC8C144 X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Am Montag, 17. Januar 2022, 08:44:37 CET schrieb Chen-Yu Tsai: > On Sat, Jan 15, 2022 at 7:03 AM Brian Norris wrote: > > > > Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > > switched the platform to SPDIF, but we didn't fix up the device tree. > > > > Drop the pinctrl settings, because the 'spdif_bus' pins are either: > > * unused (on kevin, bob), so the settings is ~harmless > > * used by a different function (on scarlet), which causes probe > > failures (!!) > > I suppose that means the default pinctrl should be dropped? Or maybe this > use case is the outlier. Up to Heiko? Interesting question. Right now it looks like Gru is the only one using spdif in that way, so I'd think dropping the pinctrl here is the "saner" option at this time ;-) I guess we can reevaluate if this becomes more widespread > > Fixes: b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > > Signed-off-by: Brian Norris > > Reviewed-by: Chen-Yu Tsai > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D0B0C433EF for ; Mon, 17 Jan 2022 08:41:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 055DE10E28D; Mon, 17 Jan 2022 08:41:02 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E10710E28D for ; Mon, 17 Jan 2022 08:41:00 +0000 (UTC) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9NZP-0006T4-TT; Mon, 17 Jan 2022 09:40:55 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Brian Norris , Chen-Yu Tsai Subject: Re: [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output Date: Mon, 17 Jan 2022 09:40:54 +0100 Message-ID: <3970568.xje1Q9F24u@diego> In-Reply-To: References: <20220114230209.4091727-1-briannorris@chromium.org> <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Lin Huang , David Airlie , linux-kernel@vger.kernel.org, Liam Girdwood , dri-devel@lists.freedesktop.org, Sandy Huang , linux-rockchip@lists.infradead.org, Mark Brown , Rob Herring , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am Montag, 17. Januar 2022, 08:44:37 CET schrieb Chen-Yu Tsai: > On Sat, Jan 15, 2022 at 7:03 AM Brian Norris wrote: > > > > Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > > switched the platform to SPDIF, but we didn't fix up the device tree. > > > > Drop the pinctrl settings, because the 'spdif_bus' pins are either: > > * unused (on kevin, bob), so the settings is ~harmless > > * used by a different function (on scarlet), which causes probe > > failures (!!) > > I suppose that means the default pinctrl should be dropped? Or maybe this > use case is the outlier. Up to Heiko? Interesting question. Right now it looks like Gru is the only one using spdif in that way, so I'd think dropping the pinctrl here is the "saner" option at this time ;-) I guess we can reevaluate if this becomes more widespread > > Fixes: b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > > Signed-off-by: Brian Norris > > Reviewed-by: Chen-Yu Tsai > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38DCFC433F5 for ; Mon, 17 Jan 2022 08:42:13 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8C070174F; Mon, 17 Jan 2022 09:41:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8C070174F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1642408931; bh=KEtz6kFsKMKYyb1SwMtrFy+rBZOHcM+2Fn7uK+T+Yh0=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Degd7XA0wk0L5HK3otHNz5+aX02wP2cMWyiKjhbt7uLsX83LRk7nEuwvyr7E6jIIF T+YIdPTwZlDwr5CnwJvcndsxzFIprCJdnm9KLhs4e3OLOXpK4bWeZ5FWwrKDeuZV87 NwI3ZT2Fz5EqVlNIRcOUENIBzOgb7gV8hEMGbufw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1FDF3F80100; Mon, 17 Jan 2022 09:41:21 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 409C9F80249; Mon, 17 Jan 2022 09:41:17 +0100 (CET) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A9CA4F80100 for ; Mon, 17 Jan 2022 09:41:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A9CA4F80100 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9NZP-0006T4-TT; Mon, 17 Jan 2022 09:40:55 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Brian Norris , Chen-Yu Tsai Subject: Re: [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output Date: Mon, 17 Jan 2022 09:40:54 +0100 Message-ID: <3970568.xje1Q9F24u@diego> In-Reply-To: References: <20220114230209.4091727-1-briannorris@chromium.org> <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Lin Huang , David Airlie , linux-kernel@vger.kernel.org, Liam Girdwood , dri-devel@lists.freedesktop.org, Sandy Huang , linux-rockchip@lists.infradead.org, Mark Brown , Daniel Vetter , Rob Herring , linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Am Montag, 17. Januar 2022, 08:44:37 CET schrieb Chen-Yu Tsai: > On Sat, Jan 15, 2022 at 7:03 AM Brian Norris wrote: > > > > Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > > switched the platform to SPDIF, but we didn't fix up the device tree. > > > > Drop the pinctrl settings, because the 'spdif_bus' pins are either: > > * unused (on kevin, bob), so the settings is ~harmless > > * used by a different function (on scarlet), which causes probe > > failures (!!) > > I suppose that means the default pinctrl should be dropped? Or maybe this > use case is the outlier. Up to Heiko? Interesting question. Right now it looks like Gru is the only one using spdif in that way, so I'd think dropping the pinctrl here is the "saner" option at this time ;-) I guess we can reevaluate if this becomes more widespread > > Fixes: b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > > Signed-off-by: Brian Norris > > Reviewed-by: Chen-Yu Tsai > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B2FEC433EF for ; Mon, 17 Jan 2022 08:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TJtM4bbG5gbxNYsOAOfdx5dggkCMr2nlnENbkACXVPI=; b=FqA1mYDCawwRWJ 6nilpBM2bMvHUQuSjZA0Lqee9N/gyRSww4I3sihG5vESip5u1CBYm/+RdRQCnYKgxUGTGuRgeoSWt lkVogmH6W8ZTFV+7F5pHSSHMihY4PFXjyPvCslt5fQffkusApE6GcFit/kX4BGsCzKUshBCBw0moB oWkH5SYEATC8bIYJl7set5MlBC1qqZhugvlQp61S2yJk1KUXRapuOI9VAyI7+xCyp16N2Okm/hrYN jIrEmSZ6pKY8DwGf3VxaJL6iKPvjwVX6YPp94pIOa7PNfQD8Jnkhm2iMaGhs2tJjpwwJYuO3O6GrU EnvCTYBTcwZlN/W9eGwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9NZd-00E7M4-QY; Mon, 17 Jan 2022 08:41:09 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9NZV-00E7I0-Gm; Mon, 17 Jan 2022 08:41:05 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9NZP-0006T4-TT; Mon, 17 Jan 2022 09:40:55 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Brian Norris , Chen-Yu Tsai Cc: Liam Girdwood , Mark Brown , David Airlie , Daniel Vetter , linux-rockchip@lists.infradead.org, Lin Huang , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Rob Herring , Sandy Huang , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output Date: Mon, 17 Jan 2022 09:40:54 +0100 Message-ID: <3970568.xje1Q9F24u@diego> In-Reply-To: References: <20220114230209.4091727-1-briannorris@chromium.org> <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220117_004101_589251_6CC8C144 X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Montag, 17. Januar 2022, 08:44:37 CET schrieb Chen-Yu Tsai: > On Sat, Jan 15, 2022 at 7:03 AM Brian Norris wrote: > > > > Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > > switched the platform to SPDIF, but we didn't fix up the device tree. > > > > Drop the pinctrl settings, because the 'spdif_bus' pins are either: > > * unused (on kevin, bob), so the settings is ~harmless > > * used by a different function (on scarlet), which causes probe > > failures (!!) > > I suppose that means the default pinctrl should be dropped? Or maybe this > use case is the outlier. Up to Heiko? Interesting question. Right now it looks like Gru is the only one using spdif in that way, so I'd think dropping the pinctrl here is the "saner" option at this time ;-) I guess we can reevaluate if this becomes more widespread > > Fixes: b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > > Signed-off-by: Brian Norris > > Reviewed-by: Chen-Yu Tsai > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel