On 04/27/2018 10:05 AM, Igor Mammedov wrote: > Ban it for now, if someone would need it to work early, > one would have to implement checks if HMP command is valid > at preconfig state. > > Signed-off-by: Igor Mammedov > --- Reviewed-by: Eric Blake There's a bisection window between when RUN_STATE_PRECONFIG is added and this patch where HMP can be used to screw things up, but I'm less worried about that being triggered in practice. If you want to avoid that window, then introduce RUN_STATE_PRECONFIG in one patch, then this patch, then add command line --preconfig in a later patch (thus, NOTHING can get into preconfig state, even though the code is starting to be modified to honor it, until --preconfig is enabled on the command line). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org