Re: [Kernel] [PATCH v2 4/5] ARM: dts: omap5: describe control for ckobuffer

From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Tero Kristo <t-kristo@ti.com>,
	"H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	"Discussions about the Letux Kernel"
	<letux-kernel@openphoenux.org>,
	"Russell King" <linux@arm.linux.org.uk>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Tony Lindgren" <tony@atomide.com>,
	kernel@pyra-handheld.com, LKML <linux-kernel@vger.kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Laxman Dewangan" <ldewangan@nvidia.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Marek Belisko" <marek@goldelico.com>,
	linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [Kernel] [PATCH v2 4/5] ARM: dts: omap5: describe control for ckobuffer
Date: Mon, 9 May 2016 16:52:44 +0300	[thread overview]
Message-ID: <3973330a-8a73-89fa-8e09-383407d0eaf9@ti.com> (raw)
In-Reply-To: <71c88d52-3737-6edb-52af-0b0f4a74efb2@ti.com>

On 05/09/16 15:46, Peter Ujfalusi wrote:
> On 05/09/16 15:32, Peter Ujfalusi wrote:
>> On 05/09/16 15:10, Peter Ujfalusi wrote:
>>
>>>>> finally I found some time to apply your patches. Sorry for the long time.
>>>>>
>>>>> Unfortunately, it does not work. Neither on omap5evm nor on our omap5 hardware.
>>>>> I get no sound on the twl6040 - just white noise (which can be controlled in
>>>>> level through
>>>>> amixer so it is created on the digital input side of the twl6040).
>>>>>
>>>>> So I think your patch is missing a detail compared to my simple solution.
>>>>
>>>> Did you implement anything on the audio driver side? The audio driver must
>>>> enable the clock implemented by this patch.
>>>
>>> I did, can test it in 10 minutes or so...
>>
>> might work, but linux-next is not booting on omap5-uevm :o I don't know why...
> 
> Applying Tero's alone makes the board not to boot, so something there... I can
> not see anything even with low-level debugging enabled :( I can not debug it
> further today, will look at this tomorrow.

The crash is in arch/arm/mach-omap2/control.c:omap_control_init()

the syscon_node_to_regmap() returns with error for the new
omap5_scm_wkup_pad_conf node. The other syscon was OK, but becasue of the
return PTR_ERR(syscon) the board will not boot...

Tero: any idea?

>> In any case I have attached the 3 patches I have for this, including Tero's
>> ported to linux-next.
>>
>> Patch 3 might need to be done per board probably, but this should be good for
>> testing.
>>
>>
>>
>> _______________________________________________
>> Kernel mailing list
>> Kernel@pyra-handheld.com
>> http://pyra-handheld.com/cgi-bin/mailman/listinfo/kernel
>>
> 
> 

-- 
Péter