From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] irqchip/irq-mvebu-icu: Remove redundant error printing in mvebu_icu_probe()
Date: Wed, 12 May 2021 20:23:58 +0800 [thread overview]
Message-ID: <39880ad3-16a5-42c9-6282-ed007f01ef2c@huawei.com> (raw)
In-Reply-To: <e23af14e-9305-bc6f-b96d-0c1a2e4c3073@huawei.com>
On 2021/5/11 20:11, Leizhen (ThunderTown) wrote:
>
>
> On 2021/5/11 20:08, Marc Zyngier wrote:
>> Hi Zhen,
>>
>> On 2021-05-11 13:01, Zhen Lei wrote:
>>> When devm_ioremap_resource() fails, a clear enough error message will be
>>> printed by its subfunction __devm_ioremap_resource(). The error
>>> information contains the device name, failure cause, and possibly resource
>>> information.
>>>
>>> Therefore, remove the error printing here to simplify code and reduce the
>>> binary size.
>>>
>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>>
>> I'm all grateful for these changes, but can you please organise them
>> in a series and send all the irqchip-related changes at once, instead
>> of one patch every two hours?
In a hurry yesterday, I misunderstood that they needed to be merged into one patch.
Because the rbot reports only one file at a time and there is no file order. I didn't
take the time to summarise it at first.
>
> OK, I will do it.
>
>>
>> Thanks,
>>
>> M.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-12 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 12:01 [PATCH 1/1] irqchip/irq-mvebu-icu: Remove redundant error printing in mvebu_icu_probe() Zhen Lei
2021-05-11 12:08 ` Marc Zyngier
2021-05-11 12:11 ` Leizhen (ThunderTown)
2021-05-12 12:23 ` Leizhen (ThunderTown) [this message]
2021-05-12 12:25 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39880ad3-16a5-42c9-6282-ed007f01ef2c@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.