From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54BEAC433EF for ; Sat, 11 Dec 2021 00:54:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235972AbhLKA6N (ORCPT ); Fri, 10 Dec 2021 19:58:13 -0500 Received: from mail-bn8nam08on2050.outbound.protection.outlook.com ([40.107.100.50]:52641 "EHLO NAM04-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S234568AbhLKA6M (ORCPT ); Fri, 10 Dec 2021 19:58:12 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7YzQzP75Z6EEuQdofSSlClzs5T2+p8kSEpgbJdTV4TtfKlY3/smwSmGMw0xHGc9bZRTOiOTCnyjXbZiCoZrG7DG4MtmGDXzcKZvv+JoUxEZryiFdV2XiHTf/7Mx3pXpToxMxd1LNHq1g5tAtEpBn0bua7Fe47fbFp78sN5lT4JdJRGMHEbOAKBLWmpat1YzU0wjCzrBc9J1ON3aPS8fOK2OZUWIXZaCwNUKU1O0AnMxNun2WepOog0O8lyF1/KRrGjivXfAXka7can/SF8ncH6+vBlMEas7QI+81ziVHmOEMwpUFZWwUJyp5xqNYLEuI0AxXenGT3DryaXTeWRn6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jc15YvWOr9/BgI/HQExwrT6kStb2atF+PyG+cJ+lrYY=; b=fa0BzWrwrRBTTOQnWU2Xrw7nZR39p1+vJYDTePHlh7/dprsfsQRJY35EMXH5d/rgLUwt7Og/Rh66ighUN95fn1Z+SrHEG0tG2RInNOR88HTSrhoMO8VdQbz8Kiv3eeQyfuWxR3u13cr2n+KDntMSGwaaUiGfR5mE4Ux5ZTHo71U1mdgEgyLel/PaHdkxjTp1+hoW8UhimhkbHf2fdT3SlM7gH3FdPFUc50WiYhPTGBxQ4i9Sg+Voota40upSyZykkvLTkqY9us2TBEdzqppCJ3XJK7X2choE1m+hYPYprrnBc8RufEb6e3hfAKwQLRBGHm1fKu7rVL1PzYeizKsxcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jc15YvWOr9/BgI/HQExwrT6kStb2atF+PyG+cJ+lrYY=; b=G/0iVXcpIv9IKqln5crvNBN4KwPTyfwb+rxUW8HU9XG142n048P7CspNBiQ3gAvjSDsq/Y+qwR/jZNG6KyN8Fd78mOWvxL8Q2Q8sH+0qNCqwY+BU5p0EIA6sdGsogtzbLQtcCUIf59oj5r2Aa5plZIN/2mcM9hHUyjCLcRWhbhA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BN9PR12MB5115.namprd12.prod.outlook.com (2603:10b6:408:118::14) by BN9PR12MB5276.namprd12.prod.outlook.com (2603:10b6:408:101::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Sat, 11 Dec 2021 00:54:36 +0000 Received: from BN9PR12MB5115.namprd12.prod.outlook.com ([fe80::9dfe:ccc6:102c:5300]) by BN9PR12MB5115.namprd12.prod.outlook.com ([fe80::9dfe:ccc6:102c:5300%7]) with mapi id 15.20.4755.022; Sat, 11 Dec 2021 00:54:35 +0000 Subject: Re: Reuse framebuffer after a kexec (amdgpu / efifb) To: =?UTF-8?Q?Christian_K=c3=b6nig?= , "Guilherme G. Piccoli" , Alex Deucher Cc: "open list:EFIFB FRAMEBUFFER DRIVER" , xinhui pan , Maling list - DRI developers , Baoquan He , =?UTF-8?Q?Samuel_Iglesias_Gons=c3=a1lvez?= , kernel@gpiccoli.net, kexec@lists.infradead.org, amd-gfx list , pjones@redhat.com, Gerd Hoffmann , Thomas Zimmermann , "Deucher, Alexander" , Dave Young , Vivek Goyal References: <62aab616-53cb-ff9f-c5f3-169c547bd1ee@igalia.com> <6d3c7acf-a23f-3073-56ed-375ccb8cc815@suse.de> <99b38881-8c63-de04-50f8-aa4119b52b25@igalia.com> <56dfb915-036b-0584-f0ef-83c786970d6e@igalia.com> From: Felix Kuehling Organization: AMD Inc. Message-ID: <3988a221-2f6a-540a-3d77-18c2c67ddbe7@amd.com> Date: Fri, 10 Dec 2021 19:54:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-ClientProxiedBy: BL0PR0102CA0026.prod.exchangelabs.com (2603:10b6:207:18::39) To BN9PR12MB5115.namprd12.prod.outlook.com (2603:10b6:408:118::14) MIME-Version: 1.0 Received: from [172.27.226.80] (165.204.55.251) by BL0PR0102CA0026.prod.exchangelabs.com (2603:10b6:207:18::39) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Sat, 11 Dec 2021 00:54:35 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ecccefe6-f74a-4f87-ee51-08d9bc40cd31 X-MS-TrafficTypeDiagnostic: BN9PR12MB5276:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0pNyuKTvDdj4rqvQ1JxZe0XBx2U35HUkCfUJtUPYXoP7n1+zb3Wh2QkmCCzVEgcoWNW3EkvEkhEHWrcsfuTo7+Kr8v6Lc5S006kjJI7fRMcjhHE04IBXd45n+MzoCR1Z8CanQZZ91k5rKRI3nRTmkF0sRK+F4EGqC5wa9Hcx+zc5ohhdo3RxL3ngGAFuI3tS5NxTyVIxroJrgK/k702WB6NqfYwRSyk7FfelE/cJ5Ik+nicsVJI6NBmNT4FGoEH/Ed7qM9rDUTow4h8ptyRI8rUqroUdGiIKR8IX5DISg+d/EHOIMw1D9bfY+8Y4HVK7amLQm11koF4LCvofaHebo190+EbdCwsrCMeiFx4b08VHZch7j53vDbcuBJoNyJsyrJLtUUKs9DdIu7v5t5G3ubr4Sur9ST3KXSg+uy0KU6zot/FnGRfIAQ2FuCSqC3kpXiOwdMtm12ZdwGhY+YF6fkUCt574VRvrPOmrekPdNVijZ0oNqGXjZZWvMWdJvmk8wjUzjj22meCsV7eGWwnCpHzQrEheHGCDJ//Z7eo600xXq3NT9KdNTgEBuoknKfcXkMuCRhNzwmtawUCcLaRZ99ZKmDK1KLMynW0wXEisC3nKuLpAy6umCvSirARxEySMs7sm6pr+S0EXg1lk/IgDbsCTSGLWtewt4SXcf9GQZs+lOYcydzN39Qc/emfaB5qrSdAnQ++kpn1iMiaW3E25TQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR12MB5115.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(16576012)(186003)(66574015)(4001150100001)(26005)(44832011)(956004)(36916002)(4326008)(2616005)(316002)(8936002)(54906003)(2906002)(6486002)(110136005)(66476007)(31686004)(83380400001)(86362001)(36756003)(5660300002)(66556008)(508600001)(66946007)(7416002)(38100700002)(53546011)(31696002)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmVtK0N1WndCQW95WXhIZ2ZYRlJFbGl1MFBscWEyd25WZXBCb1FySHFUMUY3?= =?utf-8?B?dU94eWgrS3VtTitCMW9HOWdqeVRnaEJJOTlTcG9lbGUyaGl4c2RVcVdOZEhX?= =?utf-8?B?b1FGSlNod3hCZFR6em8wcW5GQUpyaEdTWDdXVGhBOGgzQ0FXMFc5QVRCUnpL?= =?utf-8?B?K0ZrdUJPS0RudUdpNCtxanE5V2ViNDdiOEZwTXdHeTdrZnE3WjNwRmZKaU5x?= =?utf-8?B?bGNzeVZ2YmJJTDVtNllMMG1CTzBxUHNDU3ZzT1FpdTk5bjA1Q1JyKzMzbU1i?= =?utf-8?B?R0REVkRYN1Zhb3R6bjVCZHpuUTlxMlE3WXRTTGVpc0hBRkF6elhnUjdVKzBi?= =?utf-8?B?VHRvWERScWxuTTBFSStGOFdLM1JLRG4vbzVGeFh0VVhyUHJZS1I0M0I5bXhs?= =?utf-8?B?Rmx2aWJFSURrTFJzR3VZZWF5WmpvM0drVGp1bDRRMWFHTWFUaEJqTmZ0RjJY?= =?utf-8?B?cHJhMHhRN1NuQ3VpV1liMTBBbVU5ZDRWZ3UvU21aTUFGWDMzWW1vMXdxUVZx?= =?utf-8?B?bnRnRVNYMjd5bEcyVHcrV2F5WXZLTlJnNjR0aWJqMS9qWGsvczJjMG1qOFJY?= =?utf-8?B?MjczNEVTYjRnbGxhSXFvZ29TYUxHMEIrZm42QXE1ZEx5ODliMFVJMFNxZTRt?= =?utf-8?B?ZnFseVlKVFBiMDE0UmtRamV2RTJQTDhCczZ2bGNmZHJlNzhtNTNWQXlaOENI?= =?utf-8?B?UVl0U0VpaGkxTjVrbXNFNHh5R1dGczYrWEdJRzZLbjNCN2ZaWEVBQWE0TDRY?= =?utf-8?B?WTlTK3ZZTGtnSlpQMTA5K1BoRWhaSzgxRFByUWdFcmszTkdvaHFibHdTekVI?= =?utf-8?B?R2FablJqNEh4OGQwN1lIVXJEeGhORWl3dXBPbnhMeHpCYllhWENmc2lIZFl6?= =?utf-8?B?d0s3aUxNdExPTmxHRElKc2p6aTN1VnIvRTlJRXNpYW1nYUUzYTAydjBWMVpP?= =?utf-8?B?K1JpaCsvV3pkSU1EdlFJOXprWEJMME1QbnlmS2dTZHkyRW52M0gzTXI0dzhu?= =?utf-8?B?eW4wdFlKTHhZbWFVbEUzSWxWV1MyT253NnhwRjRybVlPTVd2M08wM0RRN0Fl?= =?utf-8?B?dzBWZXBXUzZQd1RuNXE3dkVJL0FYZFpiMUhuN1RxWjdZOG1pNEZUSmZtMER4?= =?utf-8?B?T3dXcW1FcXZyaGoyNVdGdENNOCtmRVVpMDNvZjUrN1kwdUJodEkyQWxlbXN0?= =?utf-8?B?U1ZTK2tzei9OQUFmeGQ2dTFpWHdCbVV3akl3MEVDQktJZE1FbENub1Q0WEdB?= =?utf-8?B?SDhNWTVSczM2a3lpVkdTUmhnMVZNaEQvcUtwUzlzKzhXVWZLZ1pDRU16NU5S?= =?utf-8?B?TWdrOGhueVFmUWNiaHJCSWNaZmxRL3ZnWFZORmVYVEV4SjQ2bGxWRloxOWp1?= =?utf-8?B?MDZKQTBLcUtLMWVUeHBOYldrRDkxUWY3VEpLUHVxTGVSVmNWUURzamFMYlFj?= =?utf-8?B?OXhBcit6UjJWcnZuMWtyRytReXR4M3czY2Vwa0w5b0plTUlOcWR4WUFJT3Er?= =?utf-8?B?RHZpN0FBUmhiVFpCUVlFTHhCejdGQm82NC9ldXJQK1FqNC8yc2xLKythSWJj?= =?utf-8?B?cEErandKbDU3MHVSUm1nbU0rbzZRVmROdFNzTzk3RXJTK2hXZFhFY3hhczV2?= =?utf-8?B?eGpBVjJLazRxNXFCdkVSSHRlMWwzNVhuWVJKRHR5cllJOThNNGExUkhhUUZJ?= =?utf-8?B?cHdJWmRwaTh4WlVqbzFxZnh6S2cxa0c0Y29mQTNlZ0VPSitNQzVlbmNaMGdY?= =?utf-8?B?dlR6RFlNOUtPRUtsOGtrNDU1QXJtKzRwR0lZa3MxeEpuTDNQSWdhYmNlZUw5?= =?utf-8?B?Y1o3YUxkWTEvc3JkZGRaa1YvV2VUWU1jbHI3YUN1Rml3YXdZSmJTNGFYQ2M1?= =?utf-8?B?cGpJV09mTFkyaS9HYXVXcDdsK1ZmblZ4cmNwcGlYcVBGa0w4SDloWVdjeTZa?= =?utf-8?B?cURWWTJOejJFR09jMEZKZTkrcnUzUVo0cFdJTWI4NHFEdFdIRHd0dFIrSEdJ?= =?utf-8?B?UHNmTFNjQlcxZjlUcXhOKzhzSmpRQWxQT3RyckhSL0cyL3gzMThSZU9ZbEJK?= =?utf-8?B?NStlMy9ab3RrSmY1dDFSbnhsQjM2UDRycVE0WVVzZXZLSFV6TTdsTzhTaWlH?= =?utf-8?B?eVJFZGh3YlNHM2JRUVVLOUdPS0dvRmFFNDRrd2YrU1FIOU4vcUc5elFWL2NM?= =?utf-8?Q?1Lurydfa6+vJ9vEPzmaQvjE=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ecccefe6-f74a-4f87-ee51-08d9bc40cd31 X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2021 00:54:35.9312 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EO+9EODOgc2d64mCWRhS+Dfbb9K7oD8M1TDvD3DKF8gylYvH17sD9tkqAzxz+DrKtjuI1OVjGmGQ4pi/nU9zrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5276 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On 2021-12-10 10:13 a.m., Christian König wrote: > > > Am 10.12.21 um 15:25 schrieb Guilherme G. Piccoli: >> On 10/12/2021 11:16, Alex Deucher wrote:> [...] >>> Why not just reload the driver after kexec? >>> >>> Alex >> Because the original issue is the kdump case, and we want a very very >> tiny kernel - also, the crash originally could have been caused by >> amdgpu itself, so if it's a GPU issue, we don't want to mess with that >> in kdump. And I confess I tried modprobe amdgpu after a kdump, no >> success - kdump won't call shutdown handlers, so GPU will be in a >> "rogue" state... >> >> My question was about regular kexec because it's much simpler usually, >> we can do whatever we want there. My line of thought was: if I make it >> work in regular kexec with a simple framebuffer, I might be able to get >> it working on kdump heheh > > How about issuing a PCIe reset and re-initializing the ASIC with just > the VBIOS? > > That should be pretty straightforward I think. Do you actually need to restore the exact boot-up mode? If you have the same framebuffer memory layout (width, height, bpp, stride) the precise display timing doesn't really matter. So we "just" need to switch to a mode that's compatible with the efifb framebuffer parameters and point the display engine at the efifb as the scan-out buffer. Regards,   Felix > > Christian. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D39E9C433F5 for ; Sat, 11 Dec 2021 00:54:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0769610E56F; Sat, 11 Dec 2021 00:54:39 +0000 (UTC) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2076.outbound.protection.outlook.com [40.107.92.76]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1311310E56F; Sat, 11 Dec 2021 00:54:38 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7YzQzP75Z6EEuQdofSSlClzs5T2+p8kSEpgbJdTV4TtfKlY3/smwSmGMw0xHGc9bZRTOiOTCnyjXbZiCoZrG7DG4MtmGDXzcKZvv+JoUxEZryiFdV2XiHTf/7Mx3pXpToxMxd1LNHq1g5tAtEpBn0bua7Fe47fbFp78sN5lT4JdJRGMHEbOAKBLWmpat1YzU0wjCzrBc9J1ON3aPS8fOK2OZUWIXZaCwNUKU1O0AnMxNun2WepOog0O8lyF1/KRrGjivXfAXka7can/SF8ncH6+vBlMEas7QI+81ziVHmOEMwpUFZWwUJyp5xqNYLEuI0AxXenGT3DryaXTeWRn6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jc15YvWOr9/BgI/HQExwrT6kStb2atF+PyG+cJ+lrYY=; b=fa0BzWrwrRBTTOQnWU2Xrw7nZR39p1+vJYDTePHlh7/dprsfsQRJY35EMXH5d/rgLUwt7Og/Rh66ighUN95fn1Z+SrHEG0tG2RInNOR88HTSrhoMO8VdQbz8Kiv3eeQyfuWxR3u13cr2n+KDntMSGwaaUiGfR5mE4Ux5ZTHo71U1mdgEgyLel/PaHdkxjTp1+hoW8UhimhkbHf2fdT3SlM7gH3FdPFUc50WiYhPTGBxQ4i9Sg+Voota40upSyZykkvLTkqY9us2TBEdzqppCJ3XJK7X2choE1m+hYPYprrnBc8RufEb6e3hfAKwQLRBGHm1fKu7rVL1PzYeizKsxcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jc15YvWOr9/BgI/HQExwrT6kStb2atF+PyG+cJ+lrYY=; b=G/0iVXcpIv9IKqln5crvNBN4KwPTyfwb+rxUW8HU9XG142n048P7CspNBiQ3gAvjSDsq/Y+qwR/jZNG6KyN8Fd78mOWvxL8Q2Q8sH+0qNCqwY+BU5p0EIA6sdGsogtzbLQtcCUIf59oj5r2Aa5plZIN/2mcM9hHUyjCLcRWhbhA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BN9PR12MB5115.namprd12.prod.outlook.com (2603:10b6:408:118::14) by BN9PR12MB5276.namprd12.prod.outlook.com (2603:10b6:408:101::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Sat, 11 Dec 2021 00:54:36 +0000 Received: from BN9PR12MB5115.namprd12.prod.outlook.com ([fe80::9dfe:ccc6:102c:5300]) by BN9PR12MB5115.namprd12.prod.outlook.com ([fe80::9dfe:ccc6:102c:5300%7]) with mapi id 15.20.4755.022; Sat, 11 Dec 2021 00:54:35 +0000 Subject: Re: Reuse framebuffer after a kexec (amdgpu / efifb) To: =?UTF-8?Q?Christian_K=c3=b6nig?= , "Guilherme G. Piccoli" , Alex Deucher References: <62aab616-53cb-ff9f-c5f3-169c547bd1ee@igalia.com> <6d3c7acf-a23f-3073-56ed-375ccb8cc815@suse.de> <99b38881-8c63-de04-50f8-aa4119b52b25@igalia.com> <56dfb915-036b-0584-f0ef-83c786970d6e@igalia.com> From: Felix Kuehling Organization: AMD Inc. Message-ID: <3988a221-2f6a-540a-3d77-18c2c67ddbe7@amd.com> Date: Fri, 10 Dec 2021 19:54:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-ClientProxiedBy: BL0PR0102CA0026.prod.exchangelabs.com (2603:10b6:207:18::39) To BN9PR12MB5115.namprd12.prod.outlook.com (2603:10b6:408:118::14) MIME-Version: 1.0 Received: from [172.27.226.80] (165.204.55.251) by BL0PR0102CA0026.prod.exchangelabs.com (2603:10b6:207:18::39) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Sat, 11 Dec 2021 00:54:35 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ecccefe6-f74a-4f87-ee51-08d9bc40cd31 X-MS-TrafficTypeDiagnostic: BN9PR12MB5276:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0pNyuKTvDdj4rqvQ1JxZe0XBx2U35HUkCfUJtUPYXoP7n1+zb3Wh2QkmCCzVEgcoWNW3EkvEkhEHWrcsfuTo7+Kr8v6Lc5S006kjJI7fRMcjhHE04IBXd45n+MzoCR1Z8CanQZZ91k5rKRI3nRTmkF0sRK+F4EGqC5wa9Hcx+zc5ohhdo3RxL3ngGAFuI3tS5NxTyVIxroJrgK/k702WB6NqfYwRSyk7FfelE/cJ5Ik+nicsVJI6NBmNT4FGoEH/Ed7qM9rDUTow4h8ptyRI8rUqroUdGiIKR8IX5DISg+d/EHOIMw1D9bfY+8Y4HVK7amLQm11koF4LCvofaHebo190+EbdCwsrCMeiFx4b08VHZch7j53vDbcuBJoNyJsyrJLtUUKs9DdIu7v5t5G3ubr4Sur9ST3KXSg+uy0KU6zot/FnGRfIAQ2FuCSqC3kpXiOwdMtm12ZdwGhY+YF6fkUCt574VRvrPOmrekPdNVijZ0oNqGXjZZWvMWdJvmk8wjUzjj22meCsV7eGWwnCpHzQrEheHGCDJ//Z7eo600xXq3NT9KdNTgEBuoknKfcXkMuCRhNzwmtawUCcLaRZ99ZKmDK1KLMynW0wXEisC3nKuLpAy6umCvSirARxEySMs7sm6pr+S0EXg1lk/IgDbsCTSGLWtewt4SXcf9GQZs+lOYcydzN39Qc/emfaB5qrSdAnQ++kpn1iMiaW3E25TQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5115.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8676002)(16576012)(186003)(66574015)(4001150100001)(26005)(44832011)(956004)(36916002)(4326008)(2616005)(316002)(8936002)(54906003)(2906002)(6486002)(110136005)(66476007)(31686004)(83380400001)(86362001)(36756003)(5660300002)(66556008)(508600001)(66946007)(7416002)(38100700002)(53546011)(31696002)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmVtK0N1WndCQW95WXhIZ2ZYRlJFbGl1MFBscWEyd25WZXBCb1FySHFUMUY3?= =?utf-8?B?dU94eWgrS3VtTitCMW9HOWdqeVRnaEJJOTlTcG9lbGUyaGl4c2RVcVdOZEhX?= =?utf-8?B?b1FGSlNod3hCZFR6em8wcW5GQUpyaEdTWDdXVGhBOGgzQ0FXMFc5QVRCUnpL?= =?utf-8?B?K0ZrdUJPS0RudUdpNCtxanE5V2ViNDdiOEZwTXdHeTdrZnE3WjNwRmZKaU5x?= =?utf-8?B?bGNzeVZ2YmJJTDVtNllMMG1CTzBxUHNDU3ZzT1FpdTk5bjA1Q1JyKzMzbU1i?= =?utf-8?B?R0REVkRYN1Zhb3R6bjVCZHpuUTlxMlE3WXRTTGVpc0hBRkF6elhnUjdVKzBi?= =?utf-8?B?VHRvWERScWxuTTBFSStGOFdLM1JLRG4vbzVGeFh0VVhyUHJZS1I0M0I5bXhs?= =?utf-8?B?Rmx2aWJFSURrTFJzR3VZZWF5WmpvM0drVGp1bDRRMWFHTWFUaEJqTmZ0RjJY?= =?utf-8?B?cHJhMHhRN1NuQ3VpV1liMTBBbVU5ZDRWZ3UvU21aTUFGWDMzWW1vMXdxUVZx?= =?utf-8?B?bnRnRVNYMjd5bEcyVHcrV2F5WXZLTlJnNjR0aWJqMS9qWGsvczJjMG1qOFJY?= =?utf-8?B?MjczNEVTYjRnbGxhSXFvZ29TYUxHMEIrZm42QXE1ZEx5ODliMFVJMFNxZTRt?= =?utf-8?B?ZnFseVlKVFBiMDE0UmtRamV2RTJQTDhCczZ2bGNmZHJlNzhtNTNWQXlaOENI?= =?utf-8?B?UVl0U0VpaGkxTjVrbXNFNHh5R1dGczYrWEdJRzZLbjNCN2ZaWEVBQWE0TDRY?= =?utf-8?B?WTlTK3ZZTGtnSlpQMTA5K1BoRWhaSzgxRFByUWdFcmszTkdvaHFibHdTekVI?= =?utf-8?B?R2FablJqNEh4OGQwN1lIVXJEeGhORWl3dXBPbnhMeHpCYllhWENmc2lIZFl6?= =?utf-8?B?d0s3aUxNdExPTmxHRElKc2p6aTN1VnIvRTlJRXNpYW1nYUUzYTAydjBWMVpP?= =?utf-8?B?K1JpaCsvV3pkSU1EdlFJOXprWEJMME1QbnlmS2dTZHkyRW52M0gzTXI0dzhu?= =?utf-8?B?eW4wdFlKTHhZbWFVbEUzSWxWV1MyT253NnhwRjRybVlPTVd2M08wM0RRN0Fl?= =?utf-8?B?dzBWZXBXUzZQd1RuNXE3dkVJL0FYZFpiMUhuN1RxWjdZOG1pNEZUSmZtMER4?= =?utf-8?B?T3dXcW1FcXZyaGoyNVdGdENNOCtmRVVpMDNvZjUrN1kwdUJodEkyQWxlbXN0?= =?utf-8?B?U1ZTK2tzei9OQUFmeGQ2dTFpWHdCbVV3akl3MEVDQktJZE1FbENub1Q0WEdB?= =?utf-8?B?SDhNWTVSczM2a3lpVkdTUmhnMVZNaEQvcUtwUzlzKzhXVWZLZ1pDRU16NU5S?= =?utf-8?B?TWdrOGhueVFmUWNiaHJCSWNaZmxRL3ZnWFZORmVYVEV4SjQ2bGxWRloxOWp1?= =?utf-8?B?MDZKQTBLcUtLMWVUeHBOYldrRDkxUWY3VEpLUHVxTGVSVmNWUURzamFMYlFj?= =?utf-8?B?OXhBcit6UjJWcnZuMWtyRytReXR4M3czY2Vwa0w5b0plTUlOcWR4WUFJT3Er?= =?utf-8?B?RHZpN0FBUmhiVFpCUVlFTHhCejdGQm82NC9ldXJQK1FqNC8yc2xLKythSWJj?= =?utf-8?B?cEErandKbDU3MHVSUm1nbU0rbzZRVmROdFNzTzk3RXJTK2hXZFhFY3hhczV2?= =?utf-8?B?eGpBVjJLazRxNXFCdkVSSHRlMWwzNVhuWVJKRHR5cllJOThNNGExUkhhUUZJ?= =?utf-8?B?cHdJWmRwaTh4WlVqbzFxZnh6S2cxa0c0Y29mQTNlZ0VPSitNQzVlbmNaMGdY?= =?utf-8?B?dlR6RFlNOUtPRUtsOGtrNDU1QXJtKzRwR0lZa3MxeEpuTDNQSWdhYmNlZUw5?= =?utf-8?B?Y1o3YUxkWTEvc3JkZGRaa1YvV2VUWU1jbHI3YUN1Rml3YXdZSmJTNGFYQ2M1?= =?utf-8?B?cGpJV09mTFkyaS9HYXVXcDdsK1ZmblZ4cmNwcGlYcVBGa0w4SDloWVdjeTZa?= =?utf-8?B?cURWWTJOejJFR09jMEZKZTkrcnUzUVo0cFdJTWI4NHFEdFdIRHd0dFIrSEdJ?= =?utf-8?B?UHNmTFNjQlcxZjlUcXhOKzhzSmpRQWxQT3RyckhSL0cyL3gzMThSZU9ZbEJK?= =?utf-8?B?NStlMy9ab3RrSmY1dDFSbnhsQjM2UDRycVE0WVVzZXZLSFV6TTdsTzhTaWlH?= =?utf-8?B?eVJFZGh3YlNHM2JRUVVLOUdPS0dvRmFFNDRrd2YrU1FIOU4vcUc5elFWL2NM?= =?utf-8?Q?1Lurydfa6+vJ9vEPzmaQvjE=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ecccefe6-f74a-4f87-ee51-08d9bc40cd31 X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2021 00:54:35.9312 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EO+9EODOgc2d64mCWRhS+Dfbb9K7oD8M1TDvD3DKF8gylYvH17sD9tkqAzxz+DrKtjuI1OVjGmGQ4pi/nU9zrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5276 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:EFIFB FRAMEBUFFER DRIVER" , kernel@gpiccoli.net, Baoquan He , =?UTF-8?Q?Samuel_Iglesias_Gons=c3=a1lvez?= , xinhui pan , kexec@lists.infradead.org, Maling list - DRI developers , pjones@redhat.com, amd-gfx list , Thomas Zimmermann , "Deucher, Alexander" , Dave Young , Vivek Goyal , Gerd Hoffmann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2021-12-10 10:13 a.m., Christian König wrote: > > > Am 10.12.21 um 15:25 schrieb Guilherme G. Piccoli: >> On 10/12/2021 11:16, Alex Deucher wrote:> [...] >>> Why not just reload the driver after kexec? >>> >>> Alex >> Because the original issue is the kdump case, and we want a very very >> tiny kernel - also, the crash originally could have been caused by >> amdgpu itself, so if it's a GPU issue, we don't want to mess with that >> in kdump. And I confess I tried modprobe amdgpu after a kdump, no >> success - kdump won't call shutdown handlers, so GPU will be in a >> "rogue" state... >> >> My question was about regular kexec because it's much simpler usually, >> we can do whatever we want there. My line of thought was: if I make it >> work in regular kexec with a simple framebuffer, I might be able to get >> it working on kdump heheh > > How about issuing a PCIe reset and re-initializing the ASIC with just > the VBIOS? > > That should be pretty straightforward I think. Do you actually need to restore the exact boot-up mode? If you have the same framebuffer memory layout (width, height, bpp, stride) the precise display timing doesn't really matter. So we "just" need to switch to a mode that's compatible with the efifb framebuffer parameters and point the display engine at the efifb as the scan-out buffer. Regards,   Felix > > Christian. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bn7nam10on2060.outbound.protection.outlook.com ([40.107.92.60] helo=NAM10-BN7-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvqet-004Mh5-8M for kexec@lists.infradead.org; Sat, 11 Dec 2021 00:54:41 +0000 Subject: Re: Reuse framebuffer after a kexec (amdgpu / efifb) References: <62aab616-53cb-ff9f-c5f3-169c547bd1ee@igalia.com> <6d3c7acf-a23f-3073-56ed-375ccb8cc815@suse.de> <99b38881-8c63-de04-50f8-aa4119b52b25@igalia.com> <56dfb915-036b-0584-f0ef-83c786970d6e@igalia.com> From: Felix Kuehling Message-ID: <3988a221-2f6a-540a-3d77-18c2c67ddbe7@amd.com> Date: Fri, 10 Dec 2021 19:54:34 -0500 In-Reply-To: Content-Language: en-US MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: =?UTF-8?Q?Christian_K=c3=b6nig?= , "Guilherme G. Piccoli" , Alex Deucher Cc: "open list:EFIFB FRAMEBUFFER DRIVER" , xinhui pan , Maling list - DRI developers , Baoquan He , =?UTF-8?Q?Samuel_Iglesias_Gons=c3=a1lvez?= , kernel@gpiccoli.net, kexec@lists.infradead.org, amd-gfx list , pjones@redhat.com, Gerd Hoffmann , Thomas Zimmermann , "Deucher, Alexander" , Dave Young , Vivek Goyal T24gMjAyMS0xMi0xMCAxMDoxMyBhLm0uLCBDaHJpc3RpYW4gS8O2bmlnIHdyb3RlOgo+Cj4KPiBB bSAxMC4xMi4yMSB1bSAxNToyNSBzY2hyaWViIEd1aWxoZXJtZSBHLiBQaWNjb2xpOgo+PiBPbiAx MC8xMi8yMDIxIDExOjE2LCBBbGV4IERldWNoZXIgd3JvdGU6PiBbLi4uXQo+Pj4gV2h5IG5vdCBq dXN0IHJlbG9hZCB0aGUgZHJpdmVyIGFmdGVyIGtleGVjPwo+Pj4KPj4+IEFsZXgKPj4gQmVjYXVz ZSB0aGUgb3JpZ2luYWwgaXNzdWUgaXMgdGhlIGtkdW1wIGNhc2UsIGFuZCB3ZSB3YW50IGEgdmVy eSB2ZXJ5Cj4+IHRpbnkga2VybmVsIC0gYWxzbywgdGhlIGNyYXNoIG9yaWdpbmFsbHkgY291bGQg aGF2ZSBiZWVuIGNhdXNlZCBieQo+PiBhbWRncHUgaXRzZWxmLCBzbyBpZiBpdCdzIGEgR1BVIGlz c3VlLCB3ZSBkb24ndCB3YW50IHRvIG1lc3Mgd2l0aCB0aGF0Cj4+IGluIGtkdW1wLiBBbmQgSSBj b25mZXNzIEkgdHJpZWQgbW9kcHJvYmUgYW1kZ3B1IGFmdGVyIGEga2R1bXAsIG5vCj4+IHN1Y2Nl c3MgLSBrZHVtcCB3b24ndCBjYWxsIHNodXRkb3duIGhhbmRsZXJzLCBzbyBHUFUgd2lsbCBiZSBp biBhCj4+ICJyb2d1ZSIgc3RhdGUuLi4KPj4KPj4gTXkgcXVlc3Rpb24gd2FzIGFib3V0IHJlZ3Vs YXIga2V4ZWMgYmVjYXVzZSBpdCdzIG11Y2ggc2ltcGxlciB1c3VhbGx5LAo+PiB3ZSBjYW4gZG8g d2hhdGV2ZXIgd2Ugd2FudCB0aGVyZS4gTXkgbGluZSBvZiB0aG91Z2h0IHdhczogaWYgSSBtYWtl IGl0Cj4+IHdvcmsgaW4gcmVndWxhciBrZXhlYyB3aXRoIGEgc2ltcGxlIGZyYW1lYnVmZmVyLCBJ IG1pZ2h0IGJlIGFibGUgdG8gZ2V0Cj4+IGl0IHdvcmtpbmcgb24ga2R1bXAgaGVoZWgKPgo+IEhv dyBhYm91dCBpc3N1aW5nIGEgUENJZSByZXNldCBhbmQgcmUtaW5pdGlhbGl6aW5nIHRoZSBBU0lD IHdpdGgganVzdCAKPiB0aGUgVkJJT1M/Cj4KPiBUaGF0IHNob3VsZCBiZSBwcmV0dHkgc3RyYWln aHRmb3J3YXJkIEkgdGhpbmsuCgpEbyB5b3UgYWN0dWFsbHkgbmVlZCB0byByZXN0b3JlIHRoZSBl eGFjdCBib290LXVwIG1vZGU/IElmIHlvdSBoYXZlIHRoZSAKc2FtZSBmcmFtZWJ1ZmZlciBtZW1v cnkgbGF5b3V0ICh3aWR0aCwgaGVpZ2h0LCBicHAsIHN0cmlkZSkgdGhlIHByZWNpc2UgCmRpc3Bs YXkgdGltaW5nIGRvZXNuJ3QgcmVhbGx5IG1hdHRlci4gU28gd2UgImp1c3QiIG5lZWQgdG8gc3dp dGNoIHRvIGEgCm1vZGUgdGhhdCdzIGNvbXBhdGlibGUgd2l0aCB0aGUgZWZpZmIgZnJhbWVidWZm ZXIgcGFyYW1ldGVycyBhbmQgcG9pbnQgCnRoZSBkaXNwbGF5IGVuZ2luZSBhdCB0aGUgZWZpZmIg YXMgdGhlIHNjYW4tb3V0IGJ1ZmZlci4KClJlZ2FyZHMsCiDCoCBGZWxpeAoKCj4KPiBDaHJpc3Rp YW4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprZXhl YyBtYWlsaW5nIGxpc3QKa2V4ZWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2tleGVjCg==