From: Hector Martin <marcan@marcan.st>
To: Heiner Kallweit <hkallweit1@gmail.com>, Jean Delvare <jdelvare@suse.de>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v2] i2c: i801: Ensure that SMBHSTSTS_INUSE_STS is cleared when leaving i801_access
Date: Mon, 7 Jun 2021 10:47:54 +0900 [thread overview]
Message-ID: <399040d5-7310-03e3-9963-c8bdf4f65913@marcan.st> (raw)
In-Reply-To: <cefbeb76-5f7f-036b-fa0e-1e339d261c35@gmail.com>
On 06/06/2021 22.55, Heiner Kallweit wrote:
> As explained in [0] currently we may leave SMBHSTSTS_INUSE_STS set,
> thus potentially breaking ACPI/BIOS usage of the SMBUS device.
>
> Seems patch [0] needs a little bit more of review effort, therefore
> I'd suggest to apply a part of it as quick win. Just clearing
> SMBHSTSTS_INUSE_STS when leaving i801_access() should fix the
> referenced issue and leaves more time for discussing a more
> sophisticated locking handling.
> out:
> + /* Unlock the SMBus device for use by BIOS/ACPI */
> + outb_p(SMBHSTSTS_INUSE_STS, SMBHSTSTS(priv));
> +
> pm_runtime_mark_last_busy(&priv->pci_dev->dev);
Yup, I was thinking of suggesting just this part if the rest of the
patch were deemed more controversial. Thanks :)
Reviewed-by: Hector Martin <marcan@marcan.st>
--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub
next prev parent reply other threads:[~2021-06-07 1:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-06 13:55 [PATCH v2] i2c: i801: Ensure that SMBHSTSTS_INUSE_STS is cleared when leaving i801_access Heiner Kallweit
2021-06-07 1:47 ` Hector Martin [this message]
2021-06-07 15:22 ` Jean Delvare
2021-06-20 20:59 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=399040d5-7310-03e3-9963-c8bdf4f65913@marcan.st \
--to=marcan@marcan.st \
--cc=hkallweit1@gmail.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.