On Freitag, 31. August 2018 17:52:39 CEST Ligang LIU wrote:
> 1. many unicast packets, with length of 200 bytes. I guess it's ELP unicast.
> 2. some batman-adv broadcast packets of 56 bytes length. I guess it's OGM2?
> 3. several batman-adv broadcast packets of 16 bytes length. It's ???

First two are correct and the the 16 bytes one is the broadcast ELP. I 
personally have no idea at the moment why the requested padding [0] was not 
implemented.

Especially because this frame will now be dropped over some interfaces. We 
already saw this in the past with fragmented frames [1]. You can increase the 
size in batadv_v_elp_iface_enable by adding the number x to the alloc and the 
skb_put. For example 44 to get to the minimum ethernet frame size:

    hard_iface->bat_v.elp_skb = dev_alloc_skb(size + 44);
    ...
    elp_buff = skb_put_zero(hard_iface->bat_v.elp_skb, BATADV_ELP_HLEN + 44);


> 3. many rts/cts/ack packets.

Is it possible that RTS, CTS + unicast retries take most of the airtime in 
your setup?


> I noticed 2 macro definitons.
> #define BATADV_ELP_PROBES_PER_NODE 2
> #define BATADV_ELP_MIN_PROBE_SIZE 200 /* bytes */
> I wonder why it sends 2 prob ELP packets to each neighbour.
> Can I change the value of BATADV_ELP_PROBES_PER_NODE from 2 to 1?
> And can I decrease ELP prob packet size from 200 to 100, in order to decrase the ELP airtime?

@Antonio, @Marek: Maybe you can explain it better than me.

I would guess that Antonio wanted to make sure that the rate control algorithm 
of the driver probes enough and thus provides a more realistic expected 
throughput.

But I would guess that the size doesn't matter much. It is more likely that 
all the stuff around the actual data frame (rts, cts, IFS, ...) takes more 
airtime.


And you can just use elp_interval [2] to reduce the number of times broadcast 
and unicast ELP frames are transmitted. But yes, reducing the number of probes 
per node might also be interesting. There is also BATADV_ELP_PROBE_MAX_TX_DIFF 
to reduce the time even further - but according to a comment [3], this may
make problems with minstrel. But I am not really sure about that because the
default elp_interval (500ms) is also already larger than 100ms.

Kind regards,
	Sven

[0] https://www.open-mesh.org/projects/batman-adv/wiki/ELP#section-9
[1] https://git.open-mesh.org/batman-adv.git/commit/11a0c90b439190fd6a104caac5d4ef09e1f65a96
[2] https://www.open-mesh.org/projects/batman-adv/wiki/Tweaking#ELP-interval
[3] https://git.open-mesh.org/batman-adv.git/blob/89dcbd5f2373b955fc8eabb909f6188ae33110b7:/net/batman-adv/bat_v_elp.c#l218