From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754393AbcLOTfV convert rfc822-to-8bit (ORCPT ); Thu, 15 Dec 2016 14:35:21 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:47736 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753714AbcLOTfU (ORCPT ); Thu, 15 Dec 2016 14:35:20 -0500 Subject: Re: Can't boot as Xen dom0 due to commit fe055896 To: Borislav Petkov References: <73a4d64b-b139-6579-a560-92311641d6c7@suse.com> <20161215164635.thm7ruio2ddnxszw@pd.tnic> <20161215171755.xpfuax7a6q3jofet@pd.tnic> <20161215173609.ornfok6lk5oro2pj@pd.tnic> <385ac3cd-7a3f-4c4d-69bb-8feee235fb7e@oracle.com> <20161215192305.dlgyrmteirgzop4y@pd.tnic> Cc: Juergen Gross , Linux Kernel Mailing List , xen-devel From: Boris Ostrovsky Message-ID: <399c758a-a94b-8aa1-efbb-79a0161b8020@oracle.com> Date: Thu, 15 Dec 2016 14:36:46 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161215192305.dlgyrmteirgzop4y@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/15/2016 02:23 PM, Borislav Petkov wrote: > On Thu, Dec 15, 2016 at 02:08:50PM -0500, Boris Ostrovsky wrote: >> This fixes my PV boot problem. I am still failing to boot HVM, will >> need to look at this some more. > No, no more stabbing in the dark and no more brown paper bags. This fixes a bug that has nothing to do with Xen. We are calling find_proper_container(..., &eq_id) and determine result based on eq_id not being zero. If find_proper_container() doesn't find anything it will not modify eq_id and so you get back whatever you passed in. What the patch that I sent does is no different from how apply_microcode_early_amd() makes the call to find_proper_container. The fact that I am having problems with HVM may or may not have anything to do with microcode. I don't know yet but it's separate from save_microcode_in_initrd_amd() patch. I am pretty sure about that because unlike PV it is failing in early boot code. -boris > > Please check whether CPUID(4) works that early in any xen guest and > let's add that check to a function which does something like: > > bool loader_disabled(void) > { > if (running_on_a_xen_guest) > return true; > > if (check_loader_disabled_bsp()) > return true; > > if (!have_cpuid_p()) > return true; > > return false; > > } > > and call that at the entry points and be done with it. > > Or if there's some other clean method to detect I'm running on a xen > guest. > > Thanks. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: Can't boot as Xen dom0 due to commit fe055896 Date: Thu, 15 Dec 2016 14:36:46 -0500 Message-ID: <399c758a-a94b-8aa1-efbb-79a0161b8020@oracle.com> References: <73a4d64b-b139-6579-a560-92311641d6c7@suse.com> <20161215164635.thm7ruio2ddnxszw@pd.tnic> <20161215171755.xpfuax7a6q3jofet@pd.tnic> <20161215173609.ornfok6lk5oro2pj@pd.tnic> <385ac3cd-7a3f-4c4d-69bb-8feee235fb7e@oracle.com> <20161215192305.dlgyrmteirgzop4y@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHbnD-0001P3-75 for xen-devel@lists.xenproject.org; Thu, 15 Dec 2016 19:34:15 +0000 In-Reply-To: <20161215192305.dlgyrmteirgzop4y@pd.tnic> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Borislav Petkov Cc: Juergen Gross , xen-devel , Linux Kernel Mailing List List-Id: xen-devel@lists.xenproject.org T24gMTIvMTUvMjAxNiAwMjoyMyBQTSwgQm9yaXNsYXYgUGV0a292IHdyb3RlOgo+IE9uIFRodSwg RGVjIDE1LCAyMDE2IGF0IDAyOjA4OjUwUE0gLTA1MDAsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToK Pj4gVGhpcyBmaXhlcyBteSBQViBib290IHByb2JsZW0uIEkgYW0gc3RpbGwgZmFpbGluZyB0byBi b290IEhWTSwgd2lsbAo+PiBuZWVkIHRvIGxvb2sgYXQgdGhpcyBzb21lIG1vcmUuCj4gTm8sIG5v IG1vcmUgc3RhYmJpbmcgaW4gdGhlIGRhcmsgYW5kIG5vIG1vcmUgYnJvd24gcGFwZXIgYmFncy4K ClRoaXMgZml4ZXMgYSBidWcgdGhhdCBoYXMgbm90aGluZyB0byBkbyB3aXRoIFhlbi4KCldlIGFy ZSBjYWxsaW5nIGZpbmRfcHJvcGVyX2NvbnRhaW5lciguLi4sICZlcV9pZCkgYW5kIGRldGVybWlu ZSByZXN1bHQKYmFzZWQgb24gZXFfaWQgbm90IGJlaW5nIHplcm8uIElmIGZpbmRfcHJvcGVyX2Nv bnRhaW5lcigpIGRvZXNuJ3QgZmluZAphbnl0aGluZyBpdCB3aWxsIG5vdCBtb2RpZnkgZXFfaWQg YW5kIHNvIHlvdSBnZXQgYmFjayB3aGF0ZXZlciB5b3UKcGFzc2VkIGluLgoKV2hhdCB0aGUgcGF0 Y2ggdGhhdCBJIHNlbnQgZG9lcyBpcyBubyBkaWZmZXJlbnQgZnJvbSBob3cKYXBwbHlfbWljcm9j b2RlX2Vhcmx5X2FtZCgpIG1ha2VzIHRoZSBjYWxsIHRvIGZpbmRfcHJvcGVyX2NvbnRhaW5lci4K ClRoZSBmYWN0IHRoYXQgIEkgYW0gaGF2aW5nIHByb2JsZW1zIHdpdGggSFZNIG1heSBvciBtYXkg bm90IGhhdmUKYW55dGhpbmcgdG8gZG8gd2l0aCBtaWNyb2NvZGUuIEkgZG9uJ3Qga25vdyB5ZXQg YnV0IGl0J3Mgc2VwYXJhdGUgZnJvbQpzYXZlX21pY3JvY29kZV9pbl9pbml0cmRfYW1kKCkgcGF0 Y2guIEkgYW0gcHJldHR5IHN1cmUgYWJvdXQgdGhhdApiZWNhdXNlIHVubGlrZSBQViBpdCBpcyBm YWlsaW5nIGluIGVhcmx5IGJvb3QgY29kZS4KCi1ib3JpcwoKPgo+IFBsZWFzZSBjaGVjayB3aGV0 aGVyIENQVUlEKDQpIHdvcmtzIHRoYXQgZWFybHkgaW4gYW55IHhlbiBndWVzdCBhbmQKPiBsZXQn cyBhZGQgdGhhdCBjaGVjayB0byBhIGZ1bmN0aW9uIHdoaWNoIGRvZXMgc29tZXRoaW5nIGxpa2U6 Cj4KPiBib29sIGxvYWRlcl9kaXNhYmxlZCh2b2lkKQo+IHsKPiAJaWYgKHJ1bm5pbmdfb25fYV94 ZW5fZ3Vlc3QpCj4gCQlyZXR1cm4gdHJ1ZTsKPgo+ICAgICAgICAgaWYgKGNoZWNrX2xvYWRlcl9k aXNhYmxlZF9ic3AoKSkKPiAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7Cj4KPiAgICAgICAg IGlmICghaGF2ZV9jcHVpZF9wKCkpCj4gICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwo+Cj4g CXJldHVybiBmYWxzZTsKPgo+IH0KPgo+IGFuZCBjYWxsIHRoYXQgYXQgdGhlIGVudHJ5IHBvaW50 cyBhbmQgYmUgZG9uZSB3aXRoIGl0Lgo+Cj4gT3IgaWYgdGhlcmUncyBzb21lIG90aGVyIGNsZWFu IG1ldGhvZCB0byBkZXRlY3QgSSdtIHJ1bm5pbmcgb24gYSB4ZW4KPiBndWVzdC4KPgo+IFRoYW5r cy4KPgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlz dHMueGVuLm9yZy94ZW4tZGV2ZWwK