From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [PATCH net-next mlxsw v2 2/2] net: bridge: Notify about !added_by_user FDB entries Date: Thu, 3 May 2018 15:56:33 +0300 Message-ID: <39b65224-cd35-4716-1a8c-cc1bfaff0654@cumulusnetworks.com> References: <33ac8ce3fcd084190c5797a409ebd7858f7d47db.1525350809.git.petrm@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: jiri@mellanox.com, idosch@mellanox.com, ivecera@redhat.com, davem@davemloft.net, stephen@networkplumber.org, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com To: Petr Machata , netdev@vger.kernel.org, bridge@lists.linux-foundation.org Return-path: Received: from mail-wr0-f193.google.com ([209.85.128.193]:46834 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbeECM4g (ORCPT ); Thu, 3 May 2018 08:56:36 -0400 Received: by mail-wr0-f193.google.com with SMTP id o2-v6so14591984wrj.13 for ; Thu, 03 May 2018 05:56:36 -0700 (PDT) In-Reply-To: <33ac8ce3fcd084190c5797a409ebd7858f7d47db.1525350809.git.petrm@mellanox.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 03/05/18 15:43, Petr Machata wrote: > Do not automatically bail out on sending notifications about activity on > non-user-added FDB entries. Instead, notify about this activity except > for cases where the activity itself originates in a notification, to > avoid sending duplicate notifications. > > Signed-off-by: Petr Machata > --- > net/bridge/br.c | 4 ++-- > net/bridge/br_fdb.c | 47 ++++++++++++++++++++++++++--------------------- > net/bridge/br_private.h | 6 ++++-- > net/bridge/br_switchdev.c | 2 +- > 4 files changed, 33 insertions(+), 26 deletions(-) > Thanks, looks good to me! In the future please add the reviewers to the CC list when sending a v2, I actually missed the v2 set and saw your reply to the cover letter patch later. Acked-by: Nikolay Aleksandrov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6va+JHT0bDh5ZxHr2ygNdw45QrcrtSj8SP8KvJocRRw=; b=UpTPUU2cQoimtua8UGuzzZTY545XgLRUrQvIkc22ts7CIBD7nalg+2s/1JtpoUl0s/ OghFzJUZ9UZmN/iHHCZVqZDzDQirCZX5POy7TBNrIQQoTKTIvzJWNE6DeIKNjXD7nfsc QElKrrZ3VFcgt2/Q8bYRbEN9oItRjWvmKO1dA= References: <33ac8ce3fcd084190c5797a409ebd7858f7d47db.1525350809.git.petrm@mellanox.com> From: Nikolay Aleksandrov Message-ID: <39b65224-cd35-4716-1a8c-cc1bfaff0654@cumulusnetworks.com> Date: Thu, 3 May 2018 15:56:33 +0300 MIME-Version: 1.0 In-Reply-To: <33ac8ce3fcd084190c5797a409ebd7858f7d47db.1525350809.git.petrm@mellanox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net-next mlxsw v2 2/2] net: bridge: Notify about !added_by_user FDB entries List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Petr Machata , netdev@vger.kernel.org, bridge@lists.linux-foundation.org Cc: ivecera@redhat.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, idosch@mellanox.com, jiri@mellanox.com, davem@davemloft.net On 03/05/18 15:43, Petr Machata wrote: > Do not automatically bail out on sending notifications about activity on > non-user-added FDB entries. Instead, notify about this activity except > for cases where the activity itself originates in a notification, to > avoid sending duplicate notifications. > > Signed-off-by: Petr Machata > --- > net/bridge/br.c | 4 ++-- > net/bridge/br_fdb.c | 47 ++++++++++++++++++++++++++--------------------- > net/bridge/br_private.h | 6 ++++-- > net/bridge/br_switchdev.c | 2 +- > 4 files changed, 33 insertions(+), 26 deletions(-) > Thanks, looks good to me! In the future please add the reviewers to the CC list when sending a v2, I actually missed the v2 set and saw your reply to the cover letter patch later. Acked-by: Nikolay Aleksandrov