From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCCD9C43460 for ; Fri, 9 Apr 2021 07:42:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A492961181 for ; Fri, 9 Apr 2021 07:42:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231817AbhDIHmw (ORCPT ); Fri, 9 Apr 2021 03:42:52 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:35608 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229751AbhDIHmu (ORCPT ); Fri, 9 Apr 2021 03:42:50 -0400 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 1397fcsY013416; Fri, 9 Apr 2021 09:42:05 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=lBIuI0IPIG0tqQ2R1deHRETQaTs9jGsCKm26UPFx2S8=; b=QPeB6UYsSP0FyvDqQhnUBlDgwVqFsuU6/njkpkzG5xj0Vh1vvCDevZlo6E4KP23a1mwi E9SCxgm2W/O6/7cUSzgnQPjbBwvAlJi6DhztA2fwLlS0hfl1xXncHCxkGfThckanzJl2 RQxZzWxVupUiEast9xkq9x7rP2ZwWSgwQvndJSg5vq7qn9yGvDubLMyX2iAzozRHM/Ni XajOjOu5WZ6CSZu++m82/zu53CkGIBu4N7M9HC7DZVjI1/gSGMIVFLNCIaJ/1Yxg6QJF e4DPa5m5h8zXYE4BLmQPcYwjH7ErOOX3nPjb8bKnRdyGkxbRriuy5F8iDm5BeJU7+Efe qw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 37sw5yxw6s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Apr 2021 09:42:05 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 55AB9100038; Fri, 9 Apr 2021 09:42:04 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 42FC521CA9E; Fri, 9 Apr 2021 09:42:04 +0200 (CEST) Received: from lmecxl0573.lme.st.com (10.75.127.51) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 9 Apr 2021 09:42:03 +0200 Subject: Re: [PATCH -next] mmc: sdhci-st: Remove unnecessary error log To: Laibin Qiu , , , CC: , , References: <20210409023801.3326572-1-qiulaibin@huawei.com> From: Patrice CHOTARD Message-ID: <39dd50a7-6e85-49e4-8072-e88fcc471714@foss.st.com> Date: Fri, 9 Apr 2021 09:42:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210409023801.3326572-1-qiulaibin@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG1NODE2.st.com (10.75.127.2) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-04-09_04:2021-04-08,2021-04-09 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laibin On 4/9/21 4:38 AM, Laibin Qiu wrote: > devm_ioremap_resource() has recorded error log, so it's > unnecessary to record log again. > > Reported-by: Hulk Robot > Signed-off-by: Laibin Qiu > --- > drivers/mmc/host/sdhci-st.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c > index 78941ac3a1d6..d41582c21aa3 100644 > --- a/drivers/mmc/host/sdhci-st.c > +++ b/drivers/mmc/host/sdhci-st.c > @@ -400,10 +400,8 @@ static int sdhci_st_probe(struct platform_device *pdev) > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > "top-mmc-delay"); > pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res); > - if (IS_ERR(pdata->top_ioaddr)) { > - dev_warn(&pdev->dev, "FlashSS Top Dly registers not available"); > + if (IS_ERR(pdata->top_ioaddr)) > pdata->top_ioaddr = NULL; > - } > > pltfm_host->clk = clk; > pdata->icnclk = icnclk; > Reviewed-by: Patrice Chotard Thanks Patrice From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F02FDC433B4 for ; Fri, 9 Apr 2021 07:48:03 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FE0261107 for ; Fri, 9 Apr 2021 07:48:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FE0261107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RevmHeFpNu3HshPslFQU8ZSy4rdfLJB/dK6lbUWRBug=; b=QbbyQqpO6GNNcvfoJGAShH6gH M0u302Pla+TIbitBtGMkw0crAHO6SZh//ypVzTGv+2QvTCI5h/XbeeYyn+Mizi965DTzFAy/xkL0g iy9X91qdj9+M4ni8yLiOYRCd4suinfOy8Q6IIZvs4+ougwu3RaSg+bDdlHa0GuftEp7UkHNPQj9Bc Eb6GV+5+RhwqHTpC+cSp9CnMSWXk+gwznP03a7KcUj4b2khmIW8Vns3lDtna/kCMhO+aBrAKPV1gb iJOQvRFJpz80kwCLiqwDEvuhv0VU3sacX3buJrN8kUO9UDCm2RLfL+aEh3RTpECt2sCappHbZ93Rs H+0RGAiHg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUlnj-00AUEj-1P; Fri, 09 Apr 2021 07:43:35 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUlmW-00ATzI-35 for linux-arm-kernel@lists.infradead.org; Fri, 09 Apr 2021 07:42:28 +0000 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 1397fcsY013416; Fri, 9 Apr 2021 09:42:05 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=lBIuI0IPIG0tqQ2R1deHRETQaTs9jGsCKm26UPFx2S8=; b=QPeB6UYsSP0FyvDqQhnUBlDgwVqFsuU6/njkpkzG5xj0Vh1vvCDevZlo6E4KP23a1mwi E9SCxgm2W/O6/7cUSzgnQPjbBwvAlJi6DhztA2fwLlS0hfl1xXncHCxkGfThckanzJl2 RQxZzWxVupUiEast9xkq9x7rP2ZwWSgwQvndJSg5vq7qn9yGvDubLMyX2iAzozRHM/Ni XajOjOu5WZ6CSZu++m82/zu53CkGIBu4N7M9HC7DZVjI1/gSGMIVFLNCIaJ/1Yxg6QJF e4DPa5m5h8zXYE4BLmQPcYwjH7ErOOX3nPjb8bKnRdyGkxbRriuy5F8iDm5BeJU7+Efe qw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 37sw5yxw6s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Apr 2021 09:42:05 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 55AB9100038; Fri, 9 Apr 2021 09:42:04 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 42FC521CA9E; Fri, 9 Apr 2021 09:42:04 +0200 (CEST) Received: from lmecxl0573.lme.st.com (10.75.127.51) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 9 Apr 2021 09:42:03 +0200 Subject: Re: [PATCH -next] mmc: sdhci-st: Remove unnecessary error log To: Laibin Qiu , , , CC: , , References: <20210409023801.3326572-1-qiulaibin@huawei.com> From: Patrice CHOTARD Message-ID: <39dd50a7-6e85-49e4-8072-e88fcc471714@foss.st.com> Date: Fri, 9 Apr 2021 09:42:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210409023801.3326572-1-qiulaibin@huawei.com> Content-Language: en-US X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG1NODE2.st.com (10.75.127.2) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-09_04:2021-04-08, 2021-04-09 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_084224_770088_48363C6A X-CRM114-Status: GOOD ( 20.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laibin On 4/9/21 4:38 AM, Laibin Qiu wrote: > devm_ioremap_resource() has recorded error log, so it's > unnecessary to record log again. > > Reported-by: Hulk Robot > Signed-off-by: Laibin Qiu > --- > drivers/mmc/host/sdhci-st.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c > index 78941ac3a1d6..d41582c21aa3 100644 > --- a/drivers/mmc/host/sdhci-st.c > +++ b/drivers/mmc/host/sdhci-st.c > @@ -400,10 +400,8 @@ static int sdhci_st_probe(struct platform_device *pdev) > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > "top-mmc-delay"); > pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res); > - if (IS_ERR(pdata->top_ioaddr)) { > - dev_warn(&pdev->dev, "FlashSS Top Dly registers not available"); > + if (IS_ERR(pdata->top_ioaddr)) > pdata->top_ioaddr = NULL; > - } > > pltfm_host->clk = clk; > pdata->icnclk = icnclk; > Reviewed-by: Patrice Chotard Thanks Patrice _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel