From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51563C433EF for ; Wed, 11 May 2022 13:55:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9C52184328; Wed, 11 May 2022 15:55:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=prevas.dk header.i=@prevas.dk header.b="huP52l7q"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 27DC984334; Wed, 11 May 2022 15:55:13 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0706.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0d::706]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9705E8431E for ; Wed, 11 May 2022 15:55:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TdnokJILcrDvfu1SEb59zoc0x6auWv1iYiDkorPUeWnILJtP1nVxQU04TDzfDreYv1pqcULIpau45dxtL2ULJUvDFckgbbk+33HohaXCsOKeiYPTOXV1up7WgIN6yXb/Ia+KGpLCHlm0dlv0kdgsNZA/Tlail57dXzm4NYUOzn04JoByuvhy3T0r3rOvYqHmgMmJ6WXUqLLDNw5CkBJxEclQKDK+1BiGZgdG0dr19zQmShfZVFt4eFoNhbmI5m3559MFAKW2Vo06EFjRAeDfV5MxIlUeEJqWxsn6AnQs0uGwfxZL/gW7mLBvhOd0vNV8qs4Q8hYSqEt3wOETqm9mQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sTT20ehDRY4L2juak6CxHuYr+7NKCfqdeJloz1Sv1W0=; b=G4UiPraOTsC3ZKzRGwB19ZaOHreI4BNHzl1ZFeGs45iK5qy1sKktXpJMIERwtMLGbUXIAXnuygOMWEdVSZ6YPUWShIC0tRuLfP998SGahAwvcWUxV8gsGEs0IjpxN7dki/Vv9udfT9Dl+wdtqziNLHrTvP3D2MCI4AEpy3+VhEN/Hz4O/LJDs67zD8t1+qkkrJFdhN9MTD9r0xMRtnD8EFltj3O+I1r3VHyZFqpGXqDmcnxqlu2VUvEoy4CUiD0Rvrh/AD0u327CJz05lwKG2Yx4gFMFOSWq1c0jTFOJOsJSR/hKgGoXOQX+X5ZZqr0YAilKYWLZ/9iCWI9C3FjoCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk; dkim=pass header.d=prevas.dk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sTT20ehDRY4L2juak6CxHuYr+7NKCfqdeJloz1Sv1W0=; b=huP52l7q5rhNaxdgolQW8rIk64zibkKwSK1I/SDWG1zVkujjAMb6StlJt22va6yEa4IC5akcpOWx5knvINEIo82vtk4d17eeHAQ5kB56xofw7/P+YHiz5n3Km04ztsiJKz87mMIEgmhhx/Z8Hmp8DIXxFc7PszWi1uCN46b/GcU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=prevas.dk; Received: from DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:34a::22) by DB6PR10MB1815.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:6:39::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.19; Wed, 11 May 2022 13:55:08 +0000 Received: from DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM ([fe80::5186:a92d:90e4:5648]) by DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM ([fe80::5186:a92d:90e4:5648%3]) with mapi id 15.20.5206.012; Wed, 11 May 2022 13:55:08 +0000 Message-ID: <39de1330-a36e-bad9-1b15-d4b43925870f@prevas.dk> Date: Wed, 11 May 2022 15:55:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] crypto/fsl: fsl_hash: Fix dcache issue in caam_hash_finish Content-Language: en-US To: Gaurav Jain , Stefano Babic , u-boot@lists.denx.de Cc: Fabio Estevam , Priyanka Jain , Ye Li , Horia Geanta , Silvano Di Ninno , Varun Sethi , Peng Fan , "NXP i . MX U-Boot Team" References: <20220511085319.1941861-1-gaurav.jain@nxp.com> From: Rasmus Villemoes In-Reply-To: <20220511085319.1941861-1-gaurav.jain@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: OL1P279CA0034.NORP279.PROD.OUTLOOK.COM (2603:10a6:e10:13::21) To DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:34a::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 59ce4d64-4a67-4753-81c9-08da3355db87 X-MS-TrafficTypeDiagnostic: DB6PR10MB1815:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gzay7IDtolHH8tKhf2KI2byN9Gi6B8zzUXHqeVg+OLHeNdorVoibxJcFxnHspW+lbocnFecA1xx0s/j8Cnmkf5mV0Wt2cdLkSH6EUe1I0vxBfIgRdpQYQCzJ7bvWtkWkZjufeug9z1HoghMV8dpUKaiiEaadjlaspcv6ZUpaVR7kRpRj89jw3feN2Y55FgegSgxNokJHbMf76Y0MCLg5AGpgv1qpfIgvL0M4qpImB0oyaw+psbr0vFOmMffqLmqzMooOKVtID2NShi8iGM2KPKtU05KaF59PYRSwG//NiHbM/wdW34HnAPco9RosnyKUL+t0DpicOp8eKKRwozAsDKOQf67uhK++9SL4G3pm2YNMkoKyiCIAIApRuJFuWj1RbuqJwssfk6IFFG19htyhvQnRzfYXxAGEp69R6wM5V6pIHz22glSVlxn/xwXuu9nj81Pfa87dws3r3MPchXvWQNPoweWpMiJx66l0cpxYbloa6MLsx82W86a1A2Fp++IS9n701G4dqE9eBYtF/DsgCpLM6+YOQWYJEYLX+Mh9qpOGrtirt0w9iovwg6jO73f8D8rm/GfEVllYRwHkLXz0Q0zqzLiqNxSgI7K+en5Kw3Gbtc60KVNy4kqeiU2uIvZd/ewBwlVV0GUWp7bfQVKl7LOIh0q35Zc2a8mbLUHm5xvlvEtvS8dy+3HRNIP8ae7ZtlHZMp8c7+OLmwY4+f/O5kZMPqkHvPQOEulEePHdEHUQUGma3GY7bJaPRGsPa6u0 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(366004)(4744005)(31696002)(5660300002)(44832011)(7416002)(36756003)(66556008)(4326008)(8676002)(66476007)(66946007)(508600001)(86362001)(8936002)(83380400001)(6486002)(26005)(38100700002)(38350700002)(6512007)(2616005)(8976002)(186003)(6666004)(52116002)(2906002)(6506007)(316002)(31686004)(54906003)(110136005)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUpJakVweEJIWm4zU1E3bmc5ZnJjZjExVmszWEpzVmZabjBZV2lwNVpSNUJt?= =?utf-8?B?VzdyeVlsQmlwVCt2VFVmOHl2eW5mNW9Ma2xqeW91WThiZjArWUgrK21ialdX?= =?utf-8?B?Nm1Wcm94SXIwOFpPeWxvSllMdkM0MkRqdnFrK3R0Wktyd1M2M3o2S1ZSd3dx?= =?utf-8?B?NXYyRmRtQzNQeFdxWDZHdW1EbytHL2JLV2N3MDh4Qnp5eU1TRjRLOXp6UkJz?= =?utf-8?B?ZU93U2VpUkY1em9oOEgzQjVHVXlyeUNlL1Q3SDB1OXNwZGtkcHhoS3dQSTkz?= =?utf-8?B?dmlkdVVkL013YVN0L2pNSitrOGFORnlpMmJaMFRaUFZxREZhaWlOVXNzR0gz?= =?utf-8?B?ZTB2ME4zVC9Xb1dTZDMyMFd1bmljNDhuTFhSZjlQamZhR0lmUWlqcXFMNlVi?= =?utf-8?B?cG9HQXYzTzFTZ0lxV3lCMXVQallkUC84TW4zV1pqTWFDTzJ3YWVwN0dzcGtR?= =?utf-8?B?clVjUFd0Y2ZpM2tlZE1nNGhKU0E5ZTYvaHN1MWN0Wm42MzFDTTdGSk9yTGRF?= =?utf-8?B?VFFrK0RCSCtvZy9xZE5pUHFhL2ZNZWozZ1dVcUtpMDdZbkQ4cEZzQVhuYnRE?= =?utf-8?B?U2hmbnJwZEhHUmZSaVBTYzI3NnFBRW1vcGFLMmExRklsQjg3eC9IQXY3WWg3?= =?utf-8?B?WEZuTkFZcUpBdmJvSkkzcVEveTYwelhGYTEzVnVtTWtSMUxZaTQ3VkM4RTJk?= =?utf-8?B?L2w3WjhROHIzSU1mNEszUVlsUDlOclNQbEpFMFlPS2M1bUZ1dzlITUVUQ3Ez?= =?utf-8?B?L3hOTkp5OUFwZTFqcXZWckxEU25od05hUm55R0dFbDBNMU9zWWI2SENFRGpP?= =?utf-8?B?NnB0UHhWTGI1bEs3aEN4dk5LUktERzR5YWV4ZnZ4ZUlWY3lnQllqNFhVNWFo?= =?utf-8?B?R2p6dXM3YlBqVHh5OE5LNXhGUmwvOWQ3djREQVdvNGROMHEvSDM1dHRoQ3V6?= =?utf-8?B?ci92aGZPMUM5UXBKVUZFZm1Jd2NhbHBtQzRZK0JKc01waXhBQWlObkh0bmVv?= =?utf-8?B?Q2xjdDZPejZqekgwYkZIVEd0ZXVYMDVDQU41M2pRM2k4Rm9aN2lCV2IrZXZ1?= =?utf-8?B?a2hjeUg4TnlwT3I0TzhDQzRsN0RwZElSUUl3NmJUWmUzY0tCRVRxVTc3ekNk?= =?utf-8?B?emVqZ0ZuRFdCaDZHdWdWNi93UHRWa0dQVGFyMnVoRHVNQXNqZ3IyMVZLdEtJ?= =?utf-8?B?RkVYUjAyZGdkK2NqcjRxMElyc2VFdWJGVnprKzhuVU9VaE9CcjRCbE9kclNz?= =?utf-8?B?YWg1YWk0dWpBR1psOGRXMktTdUltR3ZTcGgzb3lwTnZyaDB4Y3lzR2xRQk5i?= =?utf-8?B?R2hkVHd1elE2ZzF6WjZueW5Kcjk1ZGdiaHIrMEJkN0pmM2Z0ekUzWElLSlph?= =?utf-8?B?K1NzZlJldWxuT3Z4Ym9DKzQveHk1dzlDY04xb2NTcTJWVGtZWVdtMkVqNk5q?= =?utf-8?B?eERPZmNJQ1hmZXNRWm8rc3N5aGV2a2FKaXZyb0hSdExvanRBR2JYVVVid3B2?= =?utf-8?B?dmVrcE4zY1kwZVJ0WEp5RWpBdXZKRGRMRDdOMHE5NFRsREQ2V0xyZ2pJTFg3?= =?utf-8?B?ZXJYN1ZsL01KaXBVMUJlanhYbExIL0JLNFBLU0RkZC9sZmRDTmtBL3loeCs4?= =?utf-8?B?UUVmbUlVblc2aEM1OG41elV4dlNhUlJMcWdJcGFyWmNkR1pxUVl4UzhZWk1n?= =?utf-8?B?REhPZWcvd3YrSVNVUXpOeWw4QXc1V0RYbDZNN0xwOEdqd1hJYlNTTjh6OFVO?= =?utf-8?B?N0ZScllPZ3gxeGtOQ1NyVUdyZDlJS1YwRjE5em91Q1p4ek9vbHkxT1g1Vi9G?= =?utf-8?B?dkNUb1ozaDhGbGUzTGVESGQrRzE0a2FFeU5ocDhYYXBNVlV2ZDFyakFoV0hM?= =?utf-8?B?czBYZzczM2N2SG50ODFDVnJmT1BYUHI3L043d0FaZW9JVlMyc0Q0MWtudVpn?= =?utf-8?B?RjNiQ25Hc2N1NktYMUtaZ0IxTDNDbHltOFNCdUt1UG9Gek9Jcjk3SU9nR0h0?= =?utf-8?B?bHo0b2h5WEVrR0wvMnJSMjdKMGdVZGNTcVNHWTVPcjRPTEwvQXlXWWxrQ2JP?= =?utf-8?B?NDFsQWp2akVDNzM2OUc1ZHZlUFR6RkpqOXN3b3VnYkdmdjNXN25Ma1BiNkFu?= =?utf-8?B?L0VYVklzRHJXcEhpMmlwTnRsd1AzWlRMaWNLbENReldDcGU0bHhQeExqenBs?= =?utf-8?B?WmFTT2thRWVUczRlYUczaHN1VEpPUmlWZW5UbE1rOGdtcXF0SzFCM3dON1RS?= =?utf-8?B?ZktEWUwzN0hDWkYrWjZ2Y3RMT1YrdFJMOWtoTTVhZmNVWEt5VjBVaFFDRXhF?= =?utf-8?B?QjJubjY4N0xSayt6T3hCaTNhU0RIbjZrMTh4WjlrTFJSQUNlSTRreVVQRHJV?= =?utf-8?Q?ScW+MhXfkzu+8rYM=3D?= X-OriginatorOrg: prevas.dk X-MS-Exchange-CrossTenant-Network-Message-Id: 59ce4d64-4a67-4753-81c9-08da3355db87 X-MS-Exchange-CrossTenant-AuthSource: DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 13:55:08.1079 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W9KaHHCMWcPEEywh6KKwvUtfxl+6bMR6Pk6cnMsO2PfPALpCkkc/MLsvIk9DiYR/lubgiqXEhaRCxx3+8I5Dj9mJhaEPfZadGS4HkGkC7UI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR10MB1815 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 11/05/2022 10.53, Gaurav Jain wrote: > HW accelerated hash operations are giving incorrect hash output. > so add flush and invalidate for input/output hash buffers. > > Fixes: 94e3c8c4fd (crypto/fsl - Add progressive hashing support using hardware acceleration.) AFAICT, it takes somewhat more to fix that commit; the progressive hashing is entirely broken. It doesn't actually do anything progressive, it just stashes the address/length pairs it is given, but doesn't feed the contents of those buffers to the hardware, folding it into the hash state. So the caller must not touch the buffers it passes until the finalization. I.e. I think this won't work: char buf[SOMETHING]; update_buffer(buf); hash_update(buf, len); update_buffer_again(buf); hash_update(buf, len); And this pattern can be found in e.g. drivers/dfu/dfu.c which seems to repeatedly pass the same address (dfu->i_buf_start) to ->hash_update. Am I reading the code wrong? Rasmus