From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E84DC433E9 for ; Thu, 7 Jan 2021 06:58:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FF7B2311E for ; Thu, 7 Jan 2021 06:58:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725916AbhAGG55 (ORCPT ); Thu, 7 Jan 2021 01:57:57 -0500 Received: from mickerik.phytec.de ([195.145.39.210]:56860 "EHLO mickerik.phytec.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726752AbhAGG55 (ORCPT ); Thu, 7 Jan 2021 01:57:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; d=phytec.de; s=a1; c=relaxed/simple; q=dns/txt; i=@phytec.de; t=1610002635; x=1612594635; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qlIYyx2dKbyzQPLxoTo8MZiCWD1AYCgVDcO/IGZU0jw=; b=QA8uAM/aZOlthZesYpxPd48v+N11Xej1mKt69KF3ImdUBHgR61PzF/kJ7QQ6MltU CwzOHrvnbUOehUPmANbewzSv1JFO6A4hbHMMuqcrhN9Xbai/HQNGCfMAE0ZK2ASr UwZs/0Myqj41kmHMC09LBfAoOJF5fSnTp41OoFbLBKo=; X-AuditID: c39127d2-0c7b670000001c86-91-5ff6b0cbba6b Received: from Berlix.phytec.de (Berlix.phytec.de [172.16.0.117]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mickerik.phytec.de (PHYTEC Mail Gateway) with SMTP id FC.A0.07302.BC0B6FF5; Thu, 7 Jan 2021 07:57:15 +0100 (CET) Received: from llp-tremmet (172.16.0.116) by Berlix.phytec.de (172.16.0.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Thu, 7 Jan 2021 07:57:14 +0100 Message-ID: <39e830a329225b1f06c77ffaef8ed2ae5fe864fb.camel@phytec.de> Subject: Re: [PATCH v3 4/4] arm64: dts: freescale: Add support for phyBOARD-Pollux-i.MX8MP From: Teresa Remmet To: Shawn Guo CC: , , Catalin Marinas , Sascha Hauer , Rob Herring , Fabio Estevam , Krzysztof Kozlowski , Alexander Dahl Date: Thu, 7 Jan 2021 07:57:14 +0100 In-Reply-To: <20210107062234.GE28365@dragon> References: <1607694535-417799-1-git-send-email-t.remmet@phytec.de> <1607694535-417799-5-git-send-email-t.remmet@phytec.de> <20210107062234.GE28365@dragon> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [172.16.0.116] X-ClientProxiedBy: Berlix.phytec.de (172.16.0.117) To Berlix.phytec.de (172.16.0.117) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsWyRoChVPf0hm/xBu/eclv0HWSyeL+sh9Fi /pFzrBYPr/pbnD+/gd1i0+NrrBate4+wW/zdvonF4sUWcQdOjzXz1jB67Jx1l91j06pONo/N S+o9+v8aeKyb+57d4/MmuQD2KC6blNSczLLUIn27BK6M0+seMxe81Kr40HaTpYHxiXwXIweH hICJxNHlGl2MXBxCAsuYJHYe/coE4dxmlPjyeTp7FyMnB6+Am0Tz65dsILawQIzElccrWEFs NgENiacrTjOB2CICyhKnNvaxgzQzC2wEmvRlDSNIgkVAReLP6VXMIDangI5E46QzjBAbFjJK HL+0GKybWUBTonX7b7BtogJqEnuO3WOF2CwocXLmExaIGnmJ7W/ngA0SArJ3XToJtkBCQEFi 7u+JzBB2uMTbU7+ZJzAKzUIydhaSUbOQjFrAyLyKUSg3Mzk7tSgzW68go7IkNVkvJXUTIzBi Dk9Uv7SDsW+OxyFGJg7GQ4wSHMxKIrwWx77EC/GmJFZWpRblxxeV5qQWH2KU5mBREufdwFsS JiSQnliSmp2aWpBaBJNl4uCUamAsTi7iFbk3b8VnueWKh+6+NHimtPjujZkLri9sO/2JS99C IcNg3s/eb5NbJnZFH+mYVG+6ZeIlccbrxs932r/oZz7wRvLC4V8XVx7+npQYtK1n3jeuYJ/u GzfrbXwt5Vh55t1IPVwRPc1kkZCATqFvuaPbnWe+1kx7P7z5/P7mGp5Pf+85nXwwXYmlOCPR UIu5qDgRAB48lSyGAgAA Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello Shawn, Am Donnerstag, den 07.01.2021, 14:22 +0800 schrieb Shawn Guo: > On Fri, Dec 11, 2020 at 02:48:55PM +0100, Teresa Remmet wrote: > > Add initial support for phyBOARD-Pollux-i.MX8MP. > > Supported basic features: > > * eMMC > > * i2c EEPROM > > * i2c RTC > > * i2c LED > > * PMIC > > * debug UART > > * SD card > > * 1Gbit Ethernet (fec) > > * watchdog > > > > Signed-off-by: Teresa Remmet > > Reviewed-by: Krzysztof Kozlowski > > --- > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > .../dts/freescale/imx8mp-phyboard-pollux-rdk.dts | 163 > > ++++++++++++ > > .../boot/dts/freescale/imx8mp-phycore-som.dtsi | 296 > > +++++++++++++++++++++ > > 3 files changed, 460 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-phyboard- > > pollux-rdk.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-phycore- > > som.dtsi > > > > [...] > > +} > > + > > +/* ethernet 1 */ > > +&fec { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_fec>; > > + phy-mode = "rgmii-id"; > > + phy-handle = <ðphy1>; > > + fsl,magic-packet; > > + status = "okay"; > > + > > + mdio { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + ethphy1: ethernet-phy@0 { > > + compatible = "ethernet-phy-ieee802.3-c22"; > > + reg = <0>; > > + interrupt-parent = <&gpio1>; > > + interrupts = <15 IRQ_TYPE_EDGE_FALLING>; > > + ti,rx-internal-delay = > > ; > > + ti,tx-internal-delay = > > ; > > + ti,fifo-depth = > > ; > > + ti,clk-output-sel = ; > > + enet-phy-lane-no-swap; > > Undocumented property? yes it is undocumented but used by the drivers/net/phy/dp83867.c eth phy driver. > > > + }; > > + }; > > +}; > > + > > +&i2c1 { > > + clock-frequency = <400000>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_i2c1>; > > + pinctrl-1 = <&pinctrl_i2c1_gpio>; > > + sda-gpios = <&gpio5 15 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > > + scl-gpios = <&gpio5 14 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > > + status = "okay"; > > + > > + pmic: pmic@25 { > > + reg = <0x25>; > > + compatible = "nxp,pca9450c"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_pmic>; > > + interrupt-parent = <&gpio4>; > > + interrupts = <18 IRQ_TYPE_LEVEL_LOW>; > > + > > + regulators { > > + buck1: BUCK1 { > > + regulator-compatible = "BUCK1"; > > + regulator-min-microvolt = <600000>; > > + regulator-max-microvolt = <2187500>; > > + regulator-boot-on; > > + regulator-always-on; > > + regulator-ramp-delay = <3125>; > > + }; > > + > > + buck2: BUCK2 { > > + regulator-compatible = "BUCK2"; > > + regulator-min-microvolt = <600000>; > > + regulator-max-microvolt = <2187500>; > > + regulator-boot-on; > > + regulator-always-on; > > + regulator-ramp-delay = <3125>; > > + }; > > + > > + buck4: BUCK4 { > > + regulator-compatible = "BUCK4"; > > + regulator-min-microvolt = <600000>; > > + regulator-max-microvolt = <3400000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + buck5: BUCK5 { > > + regulator-compatible = "BUCK5"; > > + regulator-min-microvolt = <600000>; > > + regulator-max-microvolt = <3400000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + buck6: BUCK6 { > > + regulator-compatible = "BUCK6"; > > + regulator-min-microvolt = <600000>; > > + regulator-max-microvolt = <3400000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + ldo1: LDO1 { > > + regulator-compatible = "LDO1"; > > + regulator-min-microvolt = <1600000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + ldo2: LDO2 { > > + regulator-compatible = "LDO2"; > > + regulator-min-microvolt = <800000>; > > + regulator-max-microvolt = <1150000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + ldo3: LDO3 { > > + regulator-compatible = "LDO3"; > > + regulator-min-microvolt = <800000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + ldo4: LDO4 { > > + regulator-compatible = "LDO4"; > > + regulator-min-microvolt = <800000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + ldo5: LDO5 { > > + regulator-compatible = "LDO5"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3300000>; > > + }; > > + }; > > + }; > > + > > + eeprom@51 { > > + compatible = "atmel,24c32"; > > + reg = <0x51>; > > + pagesize = <32>; > > + status = "okay"; > > Unneeded 'okay' status. > > > + }; > > + > > + rv3028: rtc@52 { > > + compatible = "microcrystal,rv3028"; > > + reg = <0x52>; > > + trickle-resistor-ohms = <1000>; > > + enable-level-switching-mode; > > Undocumented property? This is a downstream leftover. I will remove it. Same with the unneeded status properties. Thank you for the review. Teresa > > Shawn > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88035C433E0 for ; Thu, 7 Jan 2021 06:59:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FF8322E00 for ; Thu, 7 Jan 2021 06:59:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FF8322E00 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=phytec.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5HmWySbbopZsk7cCIKI0Kl3tN8SAfwuWyyzyCcUxLJg=; b=RGQjUaql9eieLcvc4EpQabmRs 9aKpbEE/bO8sa8g8sND4gi5McaHYi7zEtheO+drKVMqrlFUDNyfpRJEA4r1+VoXRf+TydmFFMPPL0 eZ+3AxF2eNKPGvpFAumKfMhgRaInhYjB47zWgIwrMB8w8F6hcgJy9VLJvz2/w9SsWdB6PseNI7XKE UgY/OYJeL4GhG75wUC3FAvTPPdNev/ChHVxFRlDqlvXT6QnREbO4R84wG+FxsrZBmMvib74ugibR5 2Pu+ox1JcDcRCf0/V/HMCXUCjhajSYLi+dsUqXmnV+JMyVJAUccsERgKRTdIUf3Jj0hsm5FffHss1 mX69V6jOg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxPEY-0000kr-GX; Thu, 07 Jan 2021 06:57:22 +0000 Received: from mickerik.phytec.de ([195.145.39.210]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxPEU-0000kN-IS for linux-arm-kernel@lists.infradead.org; Thu, 07 Jan 2021 06:57:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=phytec.de; s=a1; c=relaxed/simple; q=dns/txt; i=@phytec.de; t=1610002635; x=1612594635; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qlIYyx2dKbyzQPLxoTo8MZiCWD1AYCgVDcO/IGZU0jw=; b=QA8uAM/aZOlthZesYpxPd48v+N11Xej1mKt69KF3ImdUBHgR61PzF/kJ7QQ6MltU CwzOHrvnbUOehUPmANbewzSv1JFO6A4hbHMMuqcrhN9Xbai/HQNGCfMAE0ZK2ASr UwZs/0Myqj41kmHMC09LBfAoOJF5fSnTp41OoFbLBKo=; X-AuditID: c39127d2-0c7b670000001c86-91-5ff6b0cbba6b Received: from Berlix.phytec.de (Berlix.phytec.de [172.16.0.117]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mickerik.phytec.de (PHYTEC Mail Gateway) with SMTP id FC.A0.07302.BC0B6FF5; Thu, 7 Jan 2021 07:57:15 +0100 (CET) Received: from llp-tremmet (172.16.0.116) by Berlix.phytec.de (172.16.0.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Thu, 7 Jan 2021 07:57:14 +0100 Message-ID: <39e830a329225b1f06c77ffaef8ed2ae5fe864fb.camel@phytec.de> Subject: Re: [PATCH v3 4/4] arm64: dts: freescale: Add support for phyBOARD-Pollux-i.MX8MP From: Teresa Remmet To: Shawn Guo Date: Thu, 7 Jan 2021 07:57:14 +0100 In-Reply-To: <20210107062234.GE28365@dragon> References: <1607694535-417799-1-git-send-email-t.remmet@phytec.de> <1607694535-417799-5-git-send-email-t.remmet@phytec.de> <20210107062234.GE28365@dragon> User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 X-Originating-IP: [172.16.0.116] X-ClientProxiedBy: Berlix.phytec.de (172.16.0.117) To Berlix.phytec.de (172.16.0.117) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsWyRoChVPf0hm/xBu/eclv0HWSyeL+sh9Fi /pFzrBYPr/pbnD+/gd1i0+NrrBate4+wW/zdvonF4sUWcQdOjzXz1jB67Jx1l91j06pONo/N S+o9+v8aeKyb+57d4/MmuQD2KC6blNSczLLUIn27BK6M0+seMxe81Kr40HaTpYHxiXwXIweH hICJxNHlGl2MXBxCAsuYJHYe/coE4dxmlPjyeTp7FyMnB6+Am0Tz65dsILawQIzElccrWEFs NgENiacrTjOB2CICyhKnNvaxgzQzC2wEmvRlDSNIgkVAReLP6VXMIDangI5E46QzjBAbFjJK HL+0GKybWUBTonX7b7BtogJqEnuO3WOF2CwocXLmExaIGnmJ7W/ngA0SArJ3XToJtkBCQEFi 7u+JzBB2uMTbU7+ZJzAKzUIydhaSUbOQjFrAyLyKUSg3Mzk7tSgzW68go7IkNVkvJXUTIzBi Dk9Uv7SDsW+OxyFGJg7GQ4wSHMxKIrwWx77EC/GmJFZWpRblxxeV5qQWH2KU5mBREufdwFsS JiSQnliSmp2aWpBaBJNl4uCUamAsTi7iFbk3b8VnueWKh+6+NHimtPjujZkLri9sO/2JS99C IcNg3s/eb5NbJnZFH+mYVG+6ZeIlccbrxs932r/oZz7wRvLC4V8XVx7+npQYtK1n3jeuYJ/u GzfrbXwt5Vh55t1IPVwRPc1kkZCATqFvuaPbnWe+1kx7P7z5/P7mGp5Pf+85nXwwXYmlOCPR UIu5qDgRAB48lSyGAgAA X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210107_015718_847231_F05B268D X-CRM114-Status: GOOD ( 16.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexander Dahl , Catalin Marinas , Sascha Hauer , Krzysztof Kozlowski , Rob Herring , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Shawn, Am Donnerstag, den 07.01.2021, 14:22 +0800 schrieb Shawn Guo: > On Fri, Dec 11, 2020 at 02:48:55PM +0100, Teresa Remmet wrote: > > Add initial support for phyBOARD-Pollux-i.MX8MP. > > Supported basic features: > > * eMMC > > * i2c EEPROM > > * i2c RTC > > * i2c LED > > * PMIC > > * debug UART > > * SD card > > * 1Gbit Ethernet (fec) > > * watchdog > > > > Signed-off-by: Teresa Remmet > > Reviewed-by: Krzysztof Kozlowski > > --- > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > .../dts/freescale/imx8mp-phyboard-pollux-rdk.dts | 163 > > ++++++++++++ > > .../boot/dts/freescale/imx8mp-phycore-som.dtsi | 296 > > +++++++++++++++++++++ > > 3 files changed, 460 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-phyboard- > > pollux-rdk.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-phycore- > > som.dtsi > > > > [...] > > +} > > + > > +/* ethernet 1 */ > > +&fec { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_fec>; > > + phy-mode = "rgmii-id"; > > + phy-handle = <ðphy1>; > > + fsl,magic-packet; > > + status = "okay"; > > + > > + mdio { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + ethphy1: ethernet-phy@0 { > > + compatible = "ethernet-phy-ieee802.3-c22"; > > + reg = <0>; > > + interrupt-parent = <&gpio1>; > > + interrupts = <15 IRQ_TYPE_EDGE_FALLING>; > > + ti,rx-internal-delay = > > ; > > + ti,tx-internal-delay = > > ; > > + ti,fifo-depth = > > ; > > + ti,clk-output-sel = ; > > + enet-phy-lane-no-swap; > > Undocumented property? yes it is undocumented but used by the drivers/net/phy/dp83867.c eth phy driver. > > > + }; > > + }; > > +}; > > + > > +&i2c1 { > > + clock-frequency = <400000>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_i2c1>; > > + pinctrl-1 = <&pinctrl_i2c1_gpio>; > > + sda-gpios = <&gpio5 15 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > > + scl-gpios = <&gpio5 14 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > > + status = "okay"; > > + > > + pmic: pmic@25 { > > + reg = <0x25>; > > + compatible = "nxp,pca9450c"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_pmic>; > > + interrupt-parent = <&gpio4>; > > + interrupts = <18 IRQ_TYPE_LEVEL_LOW>; > > + > > + regulators { > > + buck1: BUCK1 { > > + regulator-compatible = "BUCK1"; > > + regulator-min-microvolt = <600000>; > > + regulator-max-microvolt = <2187500>; > > + regulator-boot-on; > > + regulator-always-on; > > + regulator-ramp-delay = <3125>; > > + }; > > + > > + buck2: BUCK2 { > > + regulator-compatible = "BUCK2"; > > + regulator-min-microvolt = <600000>; > > + regulator-max-microvolt = <2187500>; > > + regulator-boot-on; > > + regulator-always-on; > > + regulator-ramp-delay = <3125>; > > + }; > > + > > + buck4: BUCK4 { > > + regulator-compatible = "BUCK4"; > > + regulator-min-microvolt = <600000>; > > + regulator-max-microvolt = <3400000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + buck5: BUCK5 { > > + regulator-compatible = "BUCK5"; > > + regulator-min-microvolt = <600000>; > > + regulator-max-microvolt = <3400000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + buck6: BUCK6 { > > + regulator-compatible = "BUCK6"; > > + regulator-min-microvolt = <600000>; > > + regulator-max-microvolt = <3400000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + ldo1: LDO1 { > > + regulator-compatible = "LDO1"; > > + regulator-min-microvolt = <1600000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + ldo2: LDO2 { > > + regulator-compatible = "LDO2"; > > + regulator-min-microvolt = <800000>; > > + regulator-max-microvolt = <1150000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + ldo3: LDO3 { > > + regulator-compatible = "LDO3"; > > + regulator-min-microvolt = <800000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + ldo4: LDO4 { > > + regulator-compatible = "LDO4"; > > + regulator-min-microvolt = <800000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + ldo5: LDO5 { > > + regulator-compatible = "LDO5"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3300000>; > > + }; > > + }; > > + }; > > + > > + eeprom@51 { > > + compatible = "atmel,24c32"; > > + reg = <0x51>; > > + pagesize = <32>; > > + status = "okay"; > > Unneeded 'okay' status. > > > + }; > > + > > + rv3028: rtc@52 { > > + compatible = "microcrystal,rv3028"; > > + reg = <0x52>; > > + trickle-resistor-ohms = <1000>; > > + enable-level-switching-mode; > > Undocumented property? This is a downstream leftover. I will remove it. Same with the unneeded status properties. Thank you for the review. Teresa > > Shawn > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel