From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31B2FC433EF for ; Fri, 15 Apr 2022 07:03:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A65EA6B0071; Fri, 15 Apr 2022 03:03:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A163D6B0073; Fri, 15 Apr 2022 03:03:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B61D6B0074; Fri, 15 Apr 2022 03:03:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 79F296B0071 for ; Fri, 15 Apr 2022 03:03:58 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4DB9D250A5 for ; Fri, 15 Apr 2022 07:03:58 +0000 (UTC) X-FDA: 79358223756.01.A798759 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf29.hostedemail.com (Postfix) with ESMTP id DC809120009 for ; Fri, 15 Apr 2022 07:03:55 +0000 (UTC) Received: from kwepemi500012.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KfnLv3YQVzgYt7; Fri, 15 Apr 2022 15:01:59 +0800 (CST) Received: from kwepemm600017.china.huawei.com (7.193.23.234) by kwepemi500012.china.huawei.com (7.221.188.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 15 Apr 2022 15:03:50 +0800 Received: from [10.174.179.19] (10.174.179.19) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 15 Apr 2022 15:03:49 +0800 Content-Type: multipart/alternative; boundary="------------3EUTUrMu380CKoyopGvuwfvZ" Message-ID: <39f1dc95-ce0c-5858-0026-9297529a5864@huawei.com> Date: Fri, 15 Apr 2022 15:03:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v3 4/4] hugetlb: Clean up hugetlb_cma_reserve Content-Language: en-US To: , , , , , , , , References: <20220413032915.251254-1-liupeng256@huawei.com> <20220413032915.251254-5-liupeng256@huawei.com> <20220415021511.umtrspqwovitnrtm@offworld> From: "liupeng (DM)" In-Reply-To: <20220415021511.umtrspqwovitnrtm@offworld> X-Originating-IP: [10.174.179.19] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600017.china.huawei.com (7.193.23.234) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: DC809120009 X-Stat-Signature: z7h4qs69x7eckyxqa1maqp18cq8tgzh7 Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of liupeng256@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=liupeng256@huawei.com X-HE-Tag: 1650006235-524299 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --------------3EUTUrMu380CKoyopGvuwfvZ Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 2022/4/15 10:15, Davidlohr Bueso wrote: > On Wed, 13 Apr 2022, Peng Liu wrote: > >> Use more generic functions to deal with issues related to online >> nodes. The changes will make the code simplified. >> >> Signed-off-by: Peng Liu >> Reviewed-by: Muchun Song >> Reviewed-by: Baolin Wang >> Reviewed-by: Mike Kravetz > > Reviewed-by: Davidlohr Bueso > >> --- >> mm/hugetlb.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> index 2e4d8d9fb7c6..4c529774cc08 100644 >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -6953,7 +6953,7 @@ void __init hugetlb_cma_reserve(int order) >>         if (hugetlb_cma_size_in_node[nid] == 0) >>             continue; >> >> -        if (!node_state(nid, N_ONLINE)) { >> +        if (!node_online(nid)) { > > You could update mm/page_ext.c as well > >>             pr_warn("hugetlb_cma: invalid node %d specified\n", nid); >>             hugetlb_cma_size -= hugetlb_cma_size_in_node[nid]; >>             hugetlb_cma_size_in_node[nid] = 0; >> @@ -6992,7 +6992,7 @@ void __init hugetlb_cma_reserve(int order) >>     } >> >>     reserved = 0; >> -    for_each_node_state(nid, N_ONLINE) { >> +    for_each_online_node(nid) { > > ... and arch/ia64/kernel/uncached.c for this. > . Thank you very much. I catch this. --------------3EUTUrMu380CKoyopGvuwfvZ Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit


On 2022/4/15 10:15, Davidlohr Bueso wrote:
On Wed, 13 Apr 2022, Peng Liu wrote:

Use more generic functions to deal with issues related to online
nodes. The changes will make the code simplified.

Signed-off-by: Peng Liu <liupeng256@huawei.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>

---
mm/hugetlb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 2e4d8d9fb7c6..4c529774cc08 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -6953,7 +6953,7 @@ void __init hugetlb_cma_reserve(int order)
        if (hugetlb_cma_size_in_node[nid] == 0)
            continue;

-        if (!node_state(nid, N_ONLINE)) {
+        if (!node_online(nid)) {

You could update mm/page_ext.c as well

            pr_warn("hugetlb_cma: invalid node %d specified\n", nid);
            hugetlb_cma_size -= hugetlb_cma_size_in_node[nid];
            hugetlb_cma_size_in_node[nid] = 0;
@@ -6992,7 +6992,7 @@ void __init hugetlb_cma_reserve(int order)
    }

    reserved = 0;
-    for_each_node_state(nid, N_ONLINE) {
+    for_each_online_node(nid) {

... and arch/ia64/kernel/uncached.c for this.
. 
Thank you very much. I catch this.


--------------3EUTUrMu380CKoyopGvuwfvZ--