From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 922CFC433B4 for ; Thu, 15 Apr 2021 09:04:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71A8F61073 for ; Thu, 15 Apr 2021 09:04:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232105AbhDOJFO (ORCPT ); Thu, 15 Apr 2021 05:05:14 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:15685 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231482AbhDOJFM (ORCPT ); Thu, 15 Apr 2021 05:05:12 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FLYHj6D7vzpY5v; Thu, 15 Apr 2021 17:01:53 +0800 (CST) Received: from [127.0.0.1] (10.69.38.196) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Thu, 15 Apr 2021 17:04:39 +0800 Subject: Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI To: Geert Uytterhoeven CC: Geert Uytterhoeven , Wei Xu , Wolfram Sang , "Andy Shevchenko" , Dmitry Osipenko , Linux I2C , Linux ARM , Linux Kernel Mailing List , Linuxarm References: <26db9291095c1dfd81c73b0f5f1434f9b399b1f5.1618316565.git.geert+renesas@glider.be> <21d833f0-b1b8-9732-21c7-3a73676e07d3@hisilicon.com> From: Yicong Yang Message-ID: <39f6bbed-9eea-963a-1ef1-a83248f162aa@hisilicon.com> Date: Thu, 15 Apr 2021 17:04:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <21d833f0-b1b8-9732-21c7-3a73676e07d3@hisilicon.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.38.196] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/4/15 16:18, Yicong Yang wrote: > On 2021/4/15 2:06, Geert Uytterhoeven wrote: >> Hi Yicong, >> >> On Wed, Apr 14, 2021 at 11:24 AM Yicong Yang wrote: >>> On 2021/4/13 20:26, Geert Uytterhoeven wrote: >>>> The HiSilicon Kunpeng I2C controller is only present on HiSilicon >>>> Kunpeng SoCs, and its driver relies on ACPI to probe for its presence. >>>> Hence add dependencies on ARCH_HISI and ACPI, to prevent asking the user >>>> about this driver when configuring a kernel without Hisilicon platform >>>> or ACPI firmware support. >>> >>> this is a public IP which doesn't specifically depend on ARCH_HISI. I'm >>> not sure all the platform this IP on has ARCH_HISI configured. The driver >>> will not be compiled by default config. This is not correct to have >>> this dependence. >> >> Thanks for your answer! >> >> I guess it's still fine to add a dependency on ACPI? > > yes. currently we only use this driver through ACPI. So at least > for this driver, it make sense to keep the dependency. > sorry. i was a little mess about this. I dropped this in [1]. so just keep it as is. [1] https://lore.kernel.org/linux-i2c/YGMntYT2iz72wgrd@smile.fi.intel.com/ >> >> Thanks again! >> >>>> Fixes: d62fbdb99a85730a ("i2c: add support for HiSilicon I2C controller") >>>> Signed-off-by: Geert Uytterhoeven >>>> --- >>>> drivers/i2c/busses/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig >>>> index b5b4e0d0ff4dd0bc..3ead6d9e130b2ebc 100644 >>>> --- a/drivers/i2c/busses/Kconfig >>>> +++ b/drivers/i2c/busses/Kconfig >>>> @@ -647,7 +647,7 @@ config I2C_HIGHLANDER >>>> >>>> config I2C_HISI >>>> tristate "HiSilicon I2C controller" >>>> - depends on ARM64 || COMPILE_TEST >>>> + depends on (ARM64 && ARCH_HISI && ACPI) || COMPILE_TEST >>>> help >>>> Say Y here if you want to have Hisilicon I2C controller support >>>> available on the Kunpeng Server. >> \ >> Gr{oetje,eeting}s, >> >> Geert >> > > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7698CC433B4 for ; Thu, 15 Apr 2021 09:06:37 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9A0661073 for ; Thu, 15 Apr 2021 09:06:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9A0661073 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=hisilicon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iOpaasYnulLlKfbHR4e/21apUInbS6NC7CG67ZXEpyU=; b=U4KK0L3kaE44N6VsUwzPf+LAJ TXttNLQae7sJY4yZYgPtknWiiH5UNB/Luz+FJVdt+jVAN+xX5Q45kE6F+BbsMe+Z1EMxgUjTTd7+H RtPuwGgfRHuN+boK+L4NisB1pCL1aUuf94AhGNAV7j4SGwu1nAjN1bz5kdKa0Wy0yn/VyeAb7L0hc rSFJHfSQeBC5UgnCTA4JkWUYosXTwCdQsN87p99M7eNwpu5kmU9Vd0EO/FKhwIqqsLxD7ovb2Hu/A ETjwJ014HUUv5Q1kUlVAp+Q6GzOuEs8MUAu+z8GIOCkjPy5BJq/yZQPFRM7RFpRuztuaGyz/cKEf/ zc2fW06lA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWxvo-00FRy7-KP; Thu, 15 Apr 2021 09:05:00 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWxvl-00FRxq-I2 for linux-arm-kernel@desiato.infradead.org; Thu, 15 Apr 2021 09:04:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=a4spAWE7UIx1FXmcMbbjs0xVE+LgmYJDNZERLQ8fOtM=; b=hm+r1F7MX5t2DICVngV85RcByi ZUC8jHvBrvWTflWlzSZG0qmA2x6nQFs+aQqf+Dc3b2R7NEHnMZo1kQ7rcdZSRU+fYzqt0KT7qQRZm 9RyWO2sty5bZgXJSN696SOIMtGLsYE8roVornQUnJ3I5cIks6sWUfNlhjGEV9r+5WanxlNrR7KzCR NeqGsRzw9BdnK7joskw+nBuTUtXMM+WigNzgq8RplFWq1AqKqt30MyP0DcBTZExETnFOQ9DXqdwSl OBtNVAhevQJxPZWFBufmKJw/DLNbYN03vR6R8c2lNcFrjw/u5uq226i4R0aLalzrC++oFVvouP7O4 J2f3t3hg==; Received: from szxga04-in.huawei.com ([45.249.212.190]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWxvi-008POU-7B for linux-arm-kernel@lists.infradead.org; Thu, 15 Apr 2021 09:04:56 +0000 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FLYHj6D7vzpY5v; Thu, 15 Apr 2021 17:01:53 +0800 (CST) Received: from [127.0.0.1] (10.69.38.196) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Thu, 15 Apr 2021 17:04:39 +0800 Subject: Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI To: Geert Uytterhoeven CC: Geert Uytterhoeven , Wei Xu , Wolfram Sang , "Andy Shevchenko" , Dmitry Osipenko , Linux I2C , Linux ARM , Linux Kernel Mailing List , Linuxarm References: <26db9291095c1dfd81c73b0f5f1434f9b399b1f5.1618316565.git.geert+renesas@glider.be> <21d833f0-b1b8-9732-21c7-3a73676e07d3@hisilicon.com> From: Yicong Yang Message-ID: <39f6bbed-9eea-963a-1ef1-a83248f162aa@hisilicon.com> Date: Thu, 15 Apr 2021 17:04:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <21d833f0-b1b8-9732-21c7-3a73676e07d3@hisilicon.com> X-Originating-IP: [10.69.38.196] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210415_020454_461233_8A903902 X-CRM114-Status: GOOD ( 18.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021/4/15 16:18, Yicong Yang wrote: > On 2021/4/15 2:06, Geert Uytterhoeven wrote: >> Hi Yicong, >> >> On Wed, Apr 14, 2021 at 11:24 AM Yicong Yang wrote: >>> On 2021/4/13 20:26, Geert Uytterhoeven wrote: >>>> The HiSilicon Kunpeng I2C controller is only present on HiSilicon >>>> Kunpeng SoCs, and its driver relies on ACPI to probe for its presence. >>>> Hence add dependencies on ARCH_HISI and ACPI, to prevent asking the user >>>> about this driver when configuring a kernel without Hisilicon platform >>>> or ACPI firmware support. >>> >>> this is a public IP which doesn't specifically depend on ARCH_HISI. I'm >>> not sure all the platform this IP on has ARCH_HISI configured. The driver >>> will not be compiled by default config. This is not correct to have >>> this dependence. >> >> Thanks for your answer! >> >> I guess it's still fine to add a dependency on ACPI? > > yes. currently we only use this driver through ACPI. So at least > for this driver, it make sense to keep the dependency. > sorry. i was a little mess about this. I dropped this in [1]. so just keep it as is. [1] https://lore.kernel.org/linux-i2c/YGMntYT2iz72wgrd@smile.fi.intel.com/ >> >> Thanks again! >> >>>> Fixes: d62fbdb99a85730a ("i2c: add support for HiSilicon I2C controller") >>>> Signed-off-by: Geert Uytterhoeven >>>> --- >>>> drivers/i2c/busses/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig >>>> index b5b4e0d0ff4dd0bc..3ead6d9e130b2ebc 100644 >>>> --- a/drivers/i2c/busses/Kconfig >>>> +++ b/drivers/i2c/busses/Kconfig >>>> @@ -647,7 +647,7 @@ config I2C_HIGHLANDER >>>> >>>> config I2C_HISI >>>> tristate "HiSilicon I2C controller" >>>> - depends on ARM64 || COMPILE_TEST >>>> + depends on (ARM64 && ARCH_HISI && ACPI) || COMPILE_TEST >>>> help >>>> Say Y here if you want to have Hisilicon I2C controller support >>>> available on the Kunpeng Server. >> \ >> Gr{oetje,eeting}s, >> >> Geert >> > > > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel