All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6sxsabreauto: Remove legacy CONFIG_PCA953X
Date: Wed, 5 Apr 2017 17:36:42 +0200	[thread overview]
Message-ID: <39fbd8bb-c1d2-95bc-bae7-4562ed0b0f70@denx.de> (raw)
In-Reply-To: <1491403564-12190-1-git-send-email-trini@konsulko.com>

On 05/04/2017 16:46, Tom Rini wrote:
> When this board was switched to using more DM drivers we didn't disable
> the legacy PCA953X driver.  This in turn learn to a build time warning
> about implicit functions as i2c.h would not say anything about
> 'i2c_read' nor 'i2c_write'.  But this was not a fatal error as none of
> the legacy driver would be linked in either.
> 
> Fixes: e389033f72b5 ("imx: mx6sxsabreauto: enable more dm drivers")
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>  include/configs/mx6sxsabreauto.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/configs/mx6sxsabreauto.h b/include/configs/mx6sxsabreauto.h
> index 0742b4bf2ec9..448b575c2897 100644
> --- a/include/configs/mx6sxsabreauto.h
> +++ b/include/configs/mx6sxsabreauto.h
> @@ -182,7 +182,4 @@
>  #define CONFIG_SYS_MMC_ENV_DEV		0  /*USDHC3*/
>  #endif
>  
> -#define CONFIG_PCA953X
> -#define CONFIG_SYS_I2C_PCA953X_WIDTH	{ {0x30, 8}, {0x32, 8}, {0x34, 8} }
> -
>  #endif				/* __CONFIG_H */
> 

Reviewed-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2017-04-05 15:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05 14:46 [U-Boot] [PATCH] mx6sxsabreauto: Remove legacy CONFIG_PCA953X Tom Rini
2017-04-05 15:36 ` Stefano Babic [this message]
2017-04-05 17:43   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39fbd8bb-c1d2-95bc-bae7-4562ed0b0f70@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.