From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2BEAC636D3 for ; Tue, 31 Jan 2023 01:06:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6787B6B0072; Mon, 30 Jan 2023 20:06:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 628166B0073; Mon, 30 Jan 2023 20:06:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47A916B0074; Mon, 30 Jan 2023 20:06:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 387F76B0072 for ; Mon, 30 Jan 2023 20:06:27 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F23311C15BD for ; Tue, 31 Jan 2023 01:06:26 +0000 (UTC) X-FDA: 80413303572.16.AE98BF4 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf17.hostedemail.com (Postfix) with ESMTP id 3D51940011 for ; Tue, 31 Jan 2023 01:06:23 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=T3I6aXDu; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675127183; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bd8z2AVDZP9BYoIb0tCyfOLVSUsvK5mhNZ/5YHmxuvg=; b=YaP4EdMbs8EHf14ixIePms25gtCK8GBxg4m6ugBzUMmX3dUrgZkMKwMWVUo54kmzDFKRjk MYEor1JcNjHAPKvJwKgpAi4t/VhDGJojkl+YvsNxlB0HKSPBsjWIeBWXxmIUC2WBVPKUeZ a3npilaoUwk84maMjhkxpv3ilQU1qiY= ARC-Authentication-Results: i=2; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=T3I6aXDu; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1675127183; a=rsa-sha256; cv=fail; b=iH68dp3JSo+OuNZHs6SNcQ5DdphjrGz8xvl7R1wdlP+v3OEAu3xjiP2EjJpKUHbK5lNTwV Vk+lYIcf0x+PS3ItyOUaf1SK1sPv+Bo6htG4zh29gOieDb1TpE38pFFVI5pRCvTedIm0SE hHS/7khH48Ib2gi0IR0WynAsuKrC0EI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675127183; x=1706663183; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=e8F6//pajcFid6d0vfkAAPb21Pdmp1qwXZf7X+5BxeE=; b=T3I6aXDukd35dG+Sb//0+TV1MerPqlZqKuQYRchKJDBT1SsI/4fsyqsc AnUzyG3gLpRnoX6yMjehmHTUXMcJ+rmWQDLf9Q5bEjxAZE67ggSLK/0u9 Pnic1mJPq7ee2LumTKNv2Uqbh0Li8PF8nxtzmqI4M3v+PJQw2xn9XfdHa iADcDoopYn5pOlniEbp9uxBeNtpA2xY3JFHuGDhlDcdQVORDJdRCF98Io 6ZhumGMuIhO6JI6EOLevJeIJlopW4Nt6vFePPu/8t8KJ+KpK6EIVaMlKy AZ4FE8kY6RdaXGfYQ47AUEW9iXY44Txz3E9aBrqrH5HbYplaZntVpBFBE Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="315681666" X-IronPort-AV: E=Sophos;i="5.97,259,1669104000"; d="scan'208";a="315681666" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2023 17:06:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="838158627" X-IronPort-AV: E=Sophos;i="5.97,259,1669104000"; d="scan'208";a="838158627" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 30 Jan 2023 17:06:22 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 30 Jan 2023 17:06:21 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 30 Jan 2023 17:06:21 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.49) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 30 Jan 2023 17:06:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E/3q3BuOVXjIh9cn4vrSna3UFhi7V4nyIBgElulPAkq4ovGSJpy70jt9+EAA1t+y/7T0y5IMkEl4jx5d6kNEwj+MJ/S7pOp1KKRPafNfyEeUBKeY4O5qLO6qCeMtPM3hfpRxkyd/qZLkS9KASFdvJKv7usXqB+ybyodk4dOSeOEpSyRAj0XO9fRrx3e1Z87SDe4SydKsHWm9BNCd8+ctfJ+myb2mtSpRplCVVeEOwa7EfoA090L63mXwsO3EJk42j7medXTOLqzW4caKhkCDLx1FCln1I1lNMvnJGmDdzUQUsdDS2OxhJEG86EqcrrKORtju/m3v1vmtMo3gxnNJmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bd8z2AVDZP9BYoIb0tCyfOLVSUsvK5mhNZ/5YHmxuvg=; b=cZWHPvhHsghGWM7oix+l3lf+DDGlvSGA2UCTILC6ePdnAc+CrGWujV93v713cLQUcl++6S189ayuKW8kttqSafExbNFpmnfK4veBjUPNxNfNldkqOOqqmJc2wVC1yjooAsAX54sdRSv/ZTEGHkaWnAghBUVtehSgOUa8b7t0AgVFDlPUhEgfsjJAtU6q8ue8QayusBvKLA/8hwnUxtU1iKCO4snzwehtGy3Bshcpf98ilSgwS0GxxVVq+NyDLAC+YH6pd3dU72qeMrHWtXV5APAstZa25AzNhmUiOOuJQ0K5/ugcvzXFpgWl/t/IelcYOu9sbIdPAr4E0gEnfsKpkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB4831.namprd11.prod.outlook.com (2603:10b6:a03:2d2::20) by MW4PR11MB6785.namprd11.prod.outlook.com (2603:10b6:303:20c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.33; Tue, 31 Jan 2023 01:06:17 +0000 Received: from SJ0PR11MB4831.namprd11.prod.outlook.com ([fe80::9771:dcdf:cdf8:17bf]) by SJ0PR11MB4831.namprd11.prod.outlook.com ([fe80::9771:dcdf:cdf8:17bf%9]) with mapi id 15.20.6043.036; Tue, 31 Jan 2023 01:06:15 +0000 Message-ID: <39fcb110-db00-9cc1-4b75-327172fac50d@intel.com> Date: Tue, 31 Jan 2023 09:06:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.1 Subject: Re: [RFC PATCH 4/5] mm: add do_set_pte_entry() Content-Language: en-US To: Matthew Wilcox CC: , , , , References: <20230130125504.2509710-1-fengwei.yin@intel.com> <20230130125504.2509710-5-fengwei.yin@intel.com> From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR03CA0092.apcprd03.prod.outlook.com (2603:1096:4:7c::20) To SJ0PR11MB4831.namprd11.prod.outlook.com (2603:10b6:a03:2d2::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR11MB4831:EE_|MW4PR11MB6785:EE_ X-MS-Office365-Filtering-Correlation-Id: fa2d39d1-0efd-4e5e-7497-08db032759d2 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6tkCgnGGgfDcJVY+RkbLc2RglNQrKAplKs9RI2DPkxQ2Q0rcbctlT40vxXL+ojoJZUVf0c+FYOKtKSSwAu5SKYo0Q4Ha1+YxlqYwn/J81CizeHu2LRaztAKzm3Nn7W2TBHXXlB54PtU6RSyToJNbi8skAPITDDXy3/EhzZ600f3dXqKRr57MyNsN077+2HgslSKoPngXXLmn5HhV3pEIZSSnoUdAkjaZPdGRnNKj5BXB0nN/a6plSG/qgMV6qbSshinus8mk+LCJXRhHjV93XvEqNFr6jCKSG7G8n6FT/RPrz4dZuHKbygk4UjIh0YtWmqPq7GraNfkjGPm6IQ0a0BOiBnJZuTR04KMFwnY9apBdHzamdJIj8aE/RMHfstBbErI7TPzYJdX3a7aEMMu0vuo4d2OSJiIXXAM4pwuyE9+YiVwjJOJWRoWlrMDAzxwBt9SElNEsqZpiiyfqfyZgot+hiFu7TqwBpQZNUctjKMR8UZuKB+6+3rNsbmBI8seqgwf+aZ0rc31iq3mZhbuotejG/6+pSVu5F6u2ksOD1PDi3vv2wD3Zp0YQJxe/Q6OwCxXEpCTtLZXp0yYGEgWHkIZ4uwb2T4DSXXJf6zCcppkBMrTRl7gAYLpV6m+BwOBkKd8HuV38So/ZETP2mLSgpPQbgI7umP7n/9QJj2DFsrTiCOUTy/c+6GF2ymrCimO+zxjgqtwoZyc1oJ7D6MM566ExPf6w2wycyGv+YdrSpig= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB4831.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(366004)(396003)(39860400002)(376002)(136003)(451199018)(5660300002)(41300700001)(31686004)(8936002)(2906002)(66946007)(4326008)(8676002)(316002)(66476007)(6916009)(66556008)(6486002)(478600001)(6512007)(26005)(53546011)(6506007)(6666004)(107886003)(186003)(83380400001)(31696002)(86362001)(82960400001)(36756003)(2616005)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WU4zWUJnRXgvc1ZKejJ1RXlZNlc5dlNZRUczU3JGaDgzMFZKSWhWTDFSMXJu?= =?utf-8?B?Y3BjNlIraEVDZHhXaDJlQnB6Z1lVT21IWldmMi9PMUlWQklURHVjT3pkRVcy?= =?utf-8?B?bDZ2U0F0cWwxb1AvZ3FHZEsvd2FDRTJCSzZLdVF1WFNNMDhzdWV3UzdjY0N1?= =?utf-8?B?SVp1aHJUZXZtWGMzbXBnSzQ4TDVVK2lpN3NneDVrQkdlTHVLV2U5VUxQRENR?= =?utf-8?B?Tk9pRlVTcWp5WlorZ2VUNE9PRWYzOXN4Tzl1NUQrN3ZpYkVZRHV3Y215TEx2?= =?utf-8?B?SHZsN2FvUW9pOVloWUxJYklaeXJlWXhOTGQzUDJib1VLVjVrMHl6bW5mekJz?= =?utf-8?B?MFJsMG51ektOMGF3endOTDdlVUxPaU5SWVBsK2JGOStSZUt0ZnNRN2RSS1hj?= =?utf-8?B?TEUxTi96amN1WURIQU9qNG5URDNxNkh5WTR1bzJIcytJQTJXY1BKaUhETzVo?= =?utf-8?B?NVhKckhmM1RrYzRXTFV4cmVnNUNJL2V6RjJrTmxDbFFudjF4WHZNVTlON05a?= =?utf-8?B?S002NHdRUDhyN1lpWmxGQ1Zia0hKQS9QcnJld1l0SERHR2JldkVvcmtIRHRT?= =?utf-8?B?ZGw5SFRSRlVhZTQ2RVhBTEN6dmxaREhtRmc2Z0ZqTUEzTXMwVUhHTTB3OWFv?= =?utf-8?B?Y1FrRlpxdWk4VzNqSGhtUmZpUjIxdDI5cGVhL3o3ekhEa0RtT1Q3VFk3SkRa?= =?utf-8?B?bnVvTm12bDRsU3hvS2xEK1lIcXJ4V1NMSytVeUJNbGhabUYxbFE5SWZHelpt?= =?utf-8?B?cUE3MHFoS0J0R2FOOEpMQzFocnliZk9IaGdrMGFTSm5aVzQ4K3hnVWxXVC9F?= =?utf-8?B?Q0plSkRaQkJOb25TL2RjYWVZK3RYSm5DeWgrbklKZUlyUTdnQWZYak9jU0I0?= =?utf-8?B?bTZIVU5zYkVtMXhaZG03c0RPY2k4MzFrZW42Qy9KQzltbFdZcmp3eTVsbjJw?= =?utf-8?B?bXpZYWVRbmptM1dudEJhSFRTUkVIcy90V1g3N2FHOG1rWDIyNitSTTllWm5W?= =?utf-8?B?NjhoYjdaTnNhOEdYOEhsS05yTW9YejAvRHI2eTQrYlZ0THFGZFRyYlcweXlJ?= =?utf-8?B?OWwwbmt3ZWE3dEZNK0JPMWR4a2U1akxzaGJkMzZrNWdDOURkVG9uOFpqckJk?= =?utf-8?B?V29Pd2tzN2ZTTTBpQUVqTXljblJZc2FrWXI4Mi9LaXZ1MDlmWGoxK2w0WDQr?= =?utf-8?B?WU96TWZ0eWZ4NFJURlY2K2MxWjN5WGhiVmdxeDNCWTlNWVdhUlhUQWZFc2tR?= =?utf-8?B?VW9ac3RrUTlmSVJqZ00vbHlaQlBQVWxZV2lSaVZ1dWJ6MGg4MlN3UFRJNGRB?= =?utf-8?B?UUtLVVhpcHJiY3huczhFalBlUzBDYzRhTVpvWFBHZXpiUTl6NUdlZkJGTGpZ?= =?utf-8?B?bG5TRUFmb3hFcnZZcEo2SG5TNTNVNE9zbC9XekRnaCtGM2t6SllFV3pGOG5E?= =?utf-8?B?N1VRenFIMmpFUmlZanZSZ0dOM3NGWFpwTWdKQ1pRMk44WXNVMGxXeXl6TnFK?= =?utf-8?B?Rk9makVKZjUrMThsNk5PR1FBc2FRZTlYbFp1SzBQTWR0cGtyaXNmY1J2MThu?= =?utf-8?B?RkNIK1pOOUdyT0xQK1ZoMWRTQTN1TFIxWU8wVzFOU3o4alB1a2d1S2pDWWlT?= =?utf-8?B?VnpORnZZbkRYeWYvSWZ0c3Q0aW5LYWhrRkVhVnc2Unc1VnBnUjhHUitpbEFO?= =?utf-8?B?dCtMMmhRVHBpU2VkZFR4aytONXVhcGhRcmVKMFJZY3ZPYlo3Wi9OdytjblBM?= =?utf-8?B?Z2pBYmJaeFVUTURWc2d2QWZ3dkR3aHptVXJYWS9IdXdZSndyR3VjRjdxU0c0?= =?utf-8?B?UmRHZkYwK0hFVTM3NWdkck1vbmdUT1FjMDFOOWZ5V0RiLzJUMXZ6bVRwODIw?= =?utf-8?B?cDQzVndPb2VPdGx6RDFkeHlKTnZtZm5wLzhYeGVkR0xxbXlYSi9xK3V2cy90?= =?utf-8?B?YTJGcS90M1hRYVRVV3V4ODhiSmJSNFUrUHFYUmJoaXNmdkpCUjRLZXRlQVlO?= =?utf-8?B?NE9qTkk1ZjdRWXM1U1dOa2VJMnpDcjVpaFhaRGVSMndITWIya3ZJTjhFTFFV?= =?utf-8?B?SHVtWnN6SDZSa0Urb3lkc0ZHcTFHK3FLeGwrYUR0WmNWdUIrRUpjMlBLRUJq?= =?utf-8?B?VHhSY2RKVGRBRll1c3kvdUpwNWlKSS9WWTNIaDdUQmhGSkZSNms2UUR4YlZW?= =?utf-8?B?UkE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: fa2d39d1-0efd-4e5e-7497-08db032759d2 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB4831.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 01:06:15.0660 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gPDF1ETBRooNWWEiN64EgquD5cAG9QSkMVBKY9ggdOP/Hfvlk/EkY73aEqo+Nec8b3RC/XAOSgG9MLa7T10ZSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6785 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3D51940011 X-Stat-Signature: 8qdekccff36j1woyqa789eyr6466mzfk X-HE-Tag: 1675127183-567840 X-HE-Meta: U2FsdGVkX18PQ7RK0Wl8vuu/KpOg2+j9jX66VyHZiwEs6MizOgb6fYmy0ZnmS97kL2RKHqir3LTBQ8KA1Ssgl/3rbGHsN/j8eSRsLvJMH4Soa5WsEZ7bDOWgZrLPwddizlS4JpldmDoWCbNBa4ekESvvIyxSPycJkHIybfSPLVwATd/cCBnDE8ZOenrewaKUn/rrGCJYTAOFyfhDXfxg159rp7Wzw5yg1vFk0jG3biHBq+vd5vaimcutXkm/0LgCraACvtRxqeOd2Rmqm9zLeMdKQeO1cKX0rzbEV85SZW4gJ/PzmrTN75DDOuqeZpCDKH9WgkbK3jCGDyojCW5c1G4uzHSM9ycZgwfAtscW4Zz+CDZd7CaumnErRUX/IaGzJ/xpN/oqr0tfrs42r6PR9CCb8F3KPMD63zZhhT2BM3UbZQldVImldWYBqpsRq+4PBRPv8z3fyewEmYbiL7HLxg2Dy0pIOz8baw4kac3yedQqVb44PV6z9jZRZ4WnOeo0G72+s2Ls5rR1GwGJY87wEOiB3ShDLHpQFyj3w6vrm2WKhYcskN66ZB3iQwBoX8/vdPIXL4hFkBFhD/RYuQoB+IhVKaDcdg6eDk59auaPrR3dLL43ZKEbiNkZNMurVtRNwQr+7WRNZuP47onxeXeEiVPV4XRPn+XH2yrdlEDSBjTb3xqVgKGa+6wL9CJVS8LlZxtHt9bUz2refbEbNUv/B2l4atj9VNNN6iLwIffQ5Hy49tcwR5wjJBcOe1+VSCpX0QLOXUUbmzbKPn5YkIY5mol9s2RWWw8WB/ZcXa74/InmmUhUvcaokOxB3GumT5FPbCcsZdC7GaibvcL8PwSlD7iXePbjPiqvn+B2v3oAD2vVCXBi0iNl5SI8UBoPTrMtnDX3FT4AoSp/XF/u/XXWoufdQxvLB18LoT33RoWyigm6o8UgUhPTXLvlGPqTE0H9kDWJgpsGV4ftEf8sFuZ 9oBcFyYF 0RmqnLvG65tz1Jkcd7KjYtQiZlgAbqVE8saTmOQ/02gRsW/kiqojTTDZWdu6+NPYFrgBh4KzP7W2hsMxm6JH/bkGC/sQTbmvNrJ/LD4/Oa1PVDjEMhpxOX1qg+bEb6hEa773cH2GR/GX5RIb+n3wd2NMtnc2PN4jEtiUEihTCaGYDKA2WRwDCrULFPBj9mIKzyscJCS3BslI09Lcg+PZVkG2NcsJiClp2Y5CjWer37fbCfIPpb/suuL/LRUMKK9LctdfxJ+3CJ40FBSaLmmgV6/oUSasWI7cIQ31EYf9Wxbk4FSO3ukLasm4zFkKzrDiWa8sTHjtatRm8mmEq7hWo+0Jxkw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/30/2023 9:53 PM, Matthew Wilcox wrote: > On Mon, Jan 30, 2023 at 08:55:03PM +0800, Yin Fengwei wrote: >> +++ b/include/linux/mm.h >> @@ -1061,6 +1061,8 @@ static inline pte_t maybe_mkwrite(pte_t pte, struct vm_area_struct *vma) >> >> vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page); >> void do_set_pte(struct vm_fault *vmf, struct page *page, unsigned long addr); >> +void do_set_pte_entry(struct vm_fault *vmf, struct page *page, >> + unsigned long addr); > > indentation > >> -void do_set_pte(struct vm_fault *vmf, struct page *page, unsigned long addr) >> +void do_set_pte_entry(struct vm_fault *vmf, struct page *page, >> + unsigned long addr) > > ditto > >> { >> struct vm_area_struct *vma = vmf->vma; >> bool uffd_wp = pte_marker_uffd_wp(vmf->orig_pte); >> @@ -4276,6 +4277,16 @@ void do_set_pte(struct vm_fault *vmf, struct page *page, unsigned long addr) >> entry = maybe_mkwrite(pte_mkdirty(entry), vma); >> if (unlikely(uffd_wp)) >> entry = pte_mkuffd_wp(entry); >> + set_pte_at(vma->vm_mm, addr, vmf->pte, entry); > > I'm not sure this is safe. As soon as you call set_pte_at(), the page > can be found by GUP. If it is, and it doesn't have rmap set up, aren't > things going to go horribly wrong? Thanks a lot for pointing this out. I was not aware of the connection of the sequence here with GUP. Will take care of this in next version by putting rmap set up before set_pte_at(). Regards Yin, Fengwei >