From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D00BC43382 for ; Thu, 27 Sep 2018 12:33:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3C9E2168B for ; Thu, 27 Sep 2018 12:33:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="cQZd29Mu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3C9E2168B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=synopsys.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727402AbeI0SvW (ORCPT ); Thu, 27 Sep 2018 14:51:22 -0400 Received: from smtprelay2.synopsys.com ([198.182.60.111]:42274 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727112AbeI0SvV (ORCPT ); Thu, 27 Sep 2018 14:51:21 -0400 Received: from mailhost.synopsys.com (mailhost2.synopsys.com [10.13.184.66]) by smtprelay.synopsys.com (Postfix) with ESMTP id 87C8C10C0E7C; Thu, 27 Sep 2018 05:33:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1538051597; bh=K+WGFKCMtrdeWAaZpgDxlPbahKxaBHZdCHyZWS66D8I=; h=From:To:CC:Subject:Date:References:From; b=cQZd29MueqyK2SmVt0XnxQjrW8U5aW6ETCkfhFJDwTR0gC7qzh6gTeHY2PlY3M0hf deiPfTp//U8h9q9BAIRIbxjpJgNum5V7ACQC6Yvy7nIsrH85V2ghEH1mk3Q1UAF7Pi 8Qp88D+7bxgoVdPZGbIBxWcUdcdV0NcxqKRJJHJtMssYLFRz8XF1y7cUI2WH40aVki BuhhXGROh8tILwuICw9CKlhryt3Y6EmcrMIZEU0IcDDD8AKCTz0kbFjdBcTEHygMi6 eVZtmxUwPuTW8UP4BwZyKF3JotB8SX0guGv81irioJAWTkZEPp6dKXZdLSgXOn5u4W Zu4oCLePPPtIQ== Received: from US01WEHTC3.internal.synopsys.com (us01wehtc3.internal.synopsys.com [10.15.84.232]) by mailhost.synopsys.com (Postfix) with ESMTP id 4919C3223; Thu, 27 Sep 2018 05:33:17 -0700 (PDT) Received: from AM04WEHTCA.internal.synopsys.com (10.116.16.190) by US01WEHTC3.internal.synopsys.com (10.15.84.232) with Microsoft SMTP Server (TLS) id 14.3.361.1; Thu, 27 Sep 2018 05:33:17 -0700 Received: from AM04WEMBXB.internal.synopsys.com ([fe80::1006:bcdd:1b7:579b]) by am04wehtca.internal.synopsys.com ([::1]) with mapi id 14.03.0361.001; Thu, 27 Sep 2018 16:33:13 +0400 From: Artur Petrosyan To: John Stultz , Artur Petrosyan CC: Minas Harutyunyan , lkml , John Youn , "Felipe Balbi" , "linux-usb@vger.kernel.org" , Manivannan Sadhasivam Subject: Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature Thread-Topic: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature Thread-Index: AQHT7ws4O+8B/axYs0CeMD+6l4m0jQ== Date: Thu, 27 Sep 2018 12:33:13 +0000 Message-ID: <3AD91E696667BF4BA728303C178E8A63532ACAE6@am04wembxb.internal.synopsys.com> References: <1526690943-8211-1-git-send-email-john.stultz@linaro.org> <410670D7E743164D87FA6160E7907A5601313531E1@am04wembxa.internal.synopsys.com> <410670D7E743164D87FA6160E7907A560131356C4E@am04wembxa.internal.synopsys.com> <3AD91E696667BF4BA728303C178E8A63532AAF6D@am04wembxb.internal.synopsys.com> <3AD91E696667BF4BA728303C178E8A63532AB36A@am04wembxb.internal.synopsys.com> <3AD91E696667BF4BA728303C178E8A63532AB5E5@am04wembxb.internal.synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.116.104.49] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John,=0A= =0A= On 9/25/2018 21:59, John Stultz wrote:=0A= > On Tue, Sep 25, 2018 at 3:04 AM, Artur Petrosyan=0A= > wrote:=0A= >> Just a clarification by this commit "[PATCH] usb: dwc2: Fix HiKey=0A= >> regression caused by power_down feature"=0A= >> https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__marc.info_-3Fl-3D= linux-2Dusb-26m-3D152669095513248-26w-3D2&d=3DDwIBaQ&c=3DDPL6_X_6JkXFx7AXWq= B0tg&r=3D9hPBFKCJ_nBjJhGVrrlYOeOQjP_HlVzYqrC_D7niMJI&m=3D0lMkv7adFVwkzyaUzD= 6-pUG0iwg4fd6b1-aHQgbqvSI&s=3Dm8SZvo3J_Za08sMbo-S9EkhoA06YnzEN-SRm-uTPnbg&e= =3D=0A= >>=0A= >> the power_down is disabled setting "p->power_down =3D false;" in=0A= >> "dwc2_set_his_params" function.=0A= >>=0A= >> Could you please clarify that the testes done for those 3 patches were= =0A= >> done enabling "p->power_down =3D true;" in "dwc2_set_his_params" functio= n.=0A= > =0A= > So if I remove the "power_down =3D true" initialization, USB does not=0A= > seem to function.=0A= > =0A= > If I boot w/ the gadget port removed, the USB host ports do work, but=0A= > plugging in the gadget cable results in a bunch of:=0A= > dwc2 f72c0000.usb: Waiting for Host Mode, Mode=3DPeripheral=0A= > messages.=0A= > =0A= > If I boot w/ the gadget port plugged in, USB gadget mode doesn't seem=0A= > to function at all, and when I remove the gadget cable nothing=0A= > happens, it doesn't switch to host mode.=0A= > =0A= > thanks=0A= > -john=0A= > =0A= =0A= We would like to buy the HiKey board to perform testes.=0A= We found this HiKey LeMaker to have USB 2.0 ports=0A= https://www.ebay.com/itm/HiKey-LeMaker-version-2GB-Kirin-620-SoC-8-core-ARM= -Cortex-A53-CPU-ARM-Mali-450/263958047308?hash=3Ditem3d75202a4c:g:aGsAAOSwO= kxbqqot=0A= on ebay.=0A= =0A= Could you please confirm that it is the right board to test the issues =0A= you mention.=0A= =0A= Regards,=0A= Artur=0A= From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: dwc2: Fix HiKey regression caused by power_down feature From: Artur Petrosyan Message-Id: <3AD91E696667BF4BA728303C178E8A63532ACAE6@am04wembxb.internal.synopsys.com> Date: Thu, 27 Sep 2018 12:33:13 +0000 To: John Stultz , Artur Petrosyan Cc: Minas Harutyunyan , lkml , John Youn , Felipe Balbi , "linux-usb@vger.kernel.org" , Manivannan Sadhasivam List-ID: SGkgSm9obiwKCk9uIDkvMjUvMjAxOCAyMTo1OSwgSm9obiBTdHVsdHogd3JvdGU6Cj4gT24gVHVl LCBTZXAgMjUsIDIwMTggYXQgMzowNCBBTSwgQXJ0dXIgUGV0cm9zeWFuCj4gPGFydGh1ci5wZXRy b3N5YW5Ac3lub3BzeXMuY29tPiB3cm90ZToKPj4gSnVzdCBhIGNsYXJpZmljYXRpb24gYnkgdGhp cyBjb21taXQgIltQQVRDSF0gdXNiOiBkd2MyOiBGaXggSGlLZXkKPj4gcmVncmVzc2lvbiBjYXVz ZWQgYnkgcG93ZXJfZG93biBmZWF0dXJlIgo+PiBodHRwczovL3VybGRlZmVuc2UucHJvb2Zwb2lu dC5jb20vdjIvdXJsP3U9aHR0cHMtM0FfX21hcmMuaW5mb18tM0ZsLTNEbGludXgtMkR1c2ItMjZt LTNEMTUyNjY5MDk1NTEzMjQ4LTI2dy0zRDImZD1Ed0lCYVEmYz1EUEw2X1hfNkprWEZ4N0FYV3FC MHRnJnI9OWhQQkZLQ0pfbkJqSmhHVnJybFlPZU9RalBfSGxWellxckNfRDduaU1KSSZtPTBsTWt2 N2FkRlZ3a3p5YVV6RDYtcFVHMGl3ZzRmZDZiMS1hSFFnYnF2U0kmcz1tOFNadm8zSl9aYTA4c01i by1TOUVraG9BMDZZbnpFTi1TUm0tdVRQbmJnJmU9Cj4+Cj4+IHRoZSBwb3dlcl9kb3duIGlzIGRp c2FibGVkIHNldHRpbmcgInAtPnBvd2VyX2Rvd24gPSBmYWxzZTsiIGluCj4+ICJkd2MyX3NldF9o aXNfcGFyYW1zIiBmdW5jdGlvbi4KPj4KPj4gQ291bGQgeW91IHBsZWFzZSBjbGFyaWZ5IHRoYXQg dGhlIHRlc3RlcyBkb25lIGZvciB0aG9zZSAzIHBhdGNoZXMgd2VyZQo+PiBkb25lIGVuYWJsaW5n ICJwLT5wb3dlcl9kb3duID0gdHJ1ZTsiIGluICJkd2MyX3NldF9oaXNfcGFyYW1zIiBmdW5jdGlv bi4KPiAKPiBTbyBpZiBJIHJlbW92ZSB0aGUgInBvd2VyX2Rvd24gPSB0cnVlIiBpbml0aWFsaXph dGlvbiwgVVNCIGRvZXMgbm90Cj4gc2VlbSB0byBmdW5jdGlvbi4KPiAKPiBJZiBJIGJvb3Qgdy8g dGhlIGdhZGdldCBwb3J0IHJlbW92ZWQsIHRoZSBVU0IgaG9zdCBwb3J0cyBkbyB3b3JrLCBidXQK PiBwbHVnZ2luZyBpbiB0aGUgZ2FkZ2V0IGNhYmxlIHJlc3VsdHMgaW4gYSBidW5jaCBvZjoKPiAg ICAgZHdjMiBmNzJjMDAwMC51c2I6IFdhaXRpbmcgZm9yIEhvc3QgTW9kZSwgTW9kZT1QZXJpcGhl cmFsCj4gbWVzc2FnZXMuCj4gCj4gSWYgSSBib290IHcvIHRoZSBnYWRnZXQgcG9ydCBwbHVnZ2Vk IGluLCBVU0IgZ2FkZ2V0IG1vZGUgZG9lc24ndCBzZWVtCj4gdG8gZnVuY3Rpb24gYXQgYWxsLCBh bmQgd2hlbiBJIHJlbW92ZSB0aGUgZ2FkZ2V0IGNhYmxlIG5vdGhpbmcKPiBoYXBwZW5zLCBpdCBk b2Vzbid0IHN3aXRjaCB0byBob3N0IG1vZGUuCj4gCj4gdGhhbmtzCj4gLWpvaG4KPiAKCldlIHdv dWxkIGxpa2UgdG8gYnV5IHRoZSBIaUtleSBib2FyZCB0byBwZXJmb3JtIHRlc3Rlcy4KV2UgZm91 bmQgdGhpcyBIaUtleSBMZU1ha2VyIHRvIGhhdmUgVVNCIDIuMCBwb3J0cwpodHRwczovL3d3dy5l YmF5LmNvbS9pdG0vSGlLZXktTGVNYWtlci12ZXJzaW9uLTJHQi1LaXJpbi02MjAtU29DLTgtY29y ZS1BUk0tQ29ydGV4LUE1My1DUFUtQVJNLU1hbGktNDUwLzI2Mzk1ODA0NzMwOD9oYXNoPWl0ZW0z ZDc1MjAyYTRjOmc6YUdzQUFPU3dPa3hicXFvdApvbiBlYmF5LgoKQ291bGQgeW91IHBsZWFzZSBj b25maXJtIHRoYXQgaXQgaXMgdGhlIHJpZ2h0IGJvYXJkIHRvIHRlc3QgdGhlIGlzc3VlcyAKeW91 IG1lbnRpb24uCgpSZWdhcmRzLApBcnR1cgo=