From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BB24C43143 for ; Mon, 1 Oct 2018 06:56:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB2222084C for ; Mon, 1 Oct 2018 06:56:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="jsvLWQlw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB2222084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=synopsys.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728815AbeJANci (ORCPT ); Mon, 1 Oct 2018 09:32:38 -0400 Received: from smtprelay2.synopsys.com ([198.182.60.111]:54234 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727339AbeJANci (ORCPT ); Mon, 1 Oct 2018 09:32:38 -0400 Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by smtprelay.synopsys.com (Postfix) with ESMTP id 1F5AB10C0F1C; Sun, 30 Sep 2018 23:56:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1538376984; bh=H1TSMLmWnKNRsjQbEkkvpAM5eLlJ39jb8NHFkGLCuQ4=; h=From:To:CC:Subject:Date:References:From; b=jsvLWQlw/+PkAFUEUpkFlGJPU96zjdhnkSL6TBNigMTCXlbzAJ1sSMDj6MtiQF142 AIPdi8FdvvxEpN93kdUvcoYxCyHzwAKm3+hQXe+1I6O3plgGOG81Tr1FmiY2z9vGis ji39vGpuCnvUJl0NH13/XE6bAQP85tfduERYIQ7MM/aGgylRqBNja3uFPUYKcWDQ1y EwvnNynFNdoMnCcxHvBFKehsivUOPgWFYiYKj93sedi+c/C3hRf3W5DX6YNJ9q7qmo ZB8d76POnkZN0L8kkT8M87lLGn47AFdK5d3HGdusOdE1DS+msP01SA5OoMg2ANzF1I aOCyai9kS4x/Q== Received: from US01WXQAHTC1.internal.synopsys.com (us01wxqahtc1.internal.synopsys.com [10.12.238.230]) by mailhost.synopsys.com (Postfix) with ESMTP id D73635AD7; Sun, 30 Sep 2018 23:56:23 -0700 (PDT) Received: from AM04WEHTCB.internal.synopsys.com (10.116.16.192) by US01WXQAHTC1.internal.synopsys.com (10.12.238.230) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 30 Sep 2018 23:56:23 -0700 Received: from AM04WEMBXB.internal.synopsys.com ([fe80::1006:bcdd:1b7:579b]) by am04wehtcb.internal.synopsys.com ([::1]) with mapi id 14.03.0415.000; Mon, 1 Oct 2018 10:56:20 +0400 From: Artur Petrosyan To: John Stultz , Artur Petrosyan CC: Minas Harutyunyan , lkml , John Youn , "Felipe Balbi" , "linux-usb@vger.kernel.org" , Manivannan Sadhasivam Subject: Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature Thread-Topic: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature Thread-Index: AQHT7ws4O+8B/axYs0CeMD+6l4m0jQ== Date: Mon, 1 Oct 2018 06:56:20 +0000 Message-ID: <3AD91E696667BF4BA728303C178E8A63532B89A4@am04wembxb.internal.synopsys.com> References: <1526690943-8211-1-git-send-email-john.stultz@linaro.org> <410670D7E743164D87FA6160E7907A5601313531E1@am04wembxa.internal.synopsys.com> <410670D7E743164D87FA6160E7907A560131356C4E@am04wembxa.internal.synopsys.com> <3AD91E696667BF4BA728303C178E8A63532AAF6D@am04wembxb.internal.synopsys.com> <3AD91E696667BF4BA728303C178E8A63532AB36A@am04wembxb.internal.synopsys.com> <3AD91E696667BF4BA728303C178E8A63532AB5E5@am04wembxb.internal.synopsys.com> <3AD91E696667BF4BA728303C178E8A63532AB864@am04wembxb.internal.synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.116.70.210] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John,=0A= =0A= On 9/28/2018 22:30, John Stultz wrote:=0A= > On Tue, Sep 25, 2018 at 11:02 PM, Artur Petrosyan =0A= > > = =0A= > wrote:=0A= > > On 9/25/2018 21:59, John Stultz wrote:=0A= > >> On Tue, Sep 25, 2018 at 3:04 AM, Artur Petrosyan=0A= > >> > wrote:=0A= > >>> Just a clarification by this commit "[PATCH] usb: dwc2: Fix HiKey=0A= > >>> regression caused by power_down feature"=0A= > >>> =0A= > https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__marc.info_-3Fl-3Dl= inux-2Dusb-26m-3D152669095513248-26w-3D2&d=3DDwIBaQ&c=3DDPL6_X_6JkXFx7AXWqB= 0tg&r=3D9hPBFKCJ_nBjJhGVrrlYOeOQjP_HlVzYqrC_D7niMJI&m=3D0lMkv7adFVwkzyaUzD6= -pUG0iwg4fd6b1-aHQgbqvSI&s=3Dm8SZvo3J_Za08sMbo-S9EkhoA06YnzEN-SRm-uTPnbg&e= =3D=0A= > >>>=0A= > >>> the power_down is disabled setting "p->power_down =3D false;" in=0A= > >>> "dwc2_set_his_params" function.=0A= > >>>=0A= > >>> Could you please clarify that the testes done for those 3 patches we= re=0A= > >>> done enabling "p->power_down =3D true;" in "dwc2_set_his_params" =0A= > function.=0A= > >>=0A= > >> So if I remove the "power_down =3D true" initialization, USB does not= =0A= > >> seem to function.=0A= > >>=0A= > >> If I boot w/ the gadget port removed, the USB host ports do work, but= =0A= > >> plugging in the gadget cable results in a bunch of:=0A= > >> =A0 =A0 dwc2 f72c0000.usb: Waiting for Host Mode, Mode=3DPeripheral= =0A= > >> messages.=0A= > >>=0A= > >> If I boot w/ the gadget port plugged in, USB gadget mode doesn't seem= =0A= > >> to function at all, and when I remove the gadget cable nothing=0A= > >> happens, it doesn't switch to host mode.=0A= > >>=0A= > >=0A= > > Could you please send the dmesg logs for those situations?=0A= > =0A= > Attached with some annotations in the log.=0A= > =0A= > > Also, please specify the version of the kernel that the testes has bee= n=0A= > > done on.=0A= > =0A= > This was done utilizing my dev/hikey-mainline-WIP branch here:=0A= > https://git.linaro.org/people/john.stultz/android-dev.git/log/?h=3Ddev/hi= key-mainline-WIP =0A= > =0A= > =0A= > which is 4.19.0-rc5 based + your 3 patches + removing the "p->power_down = =0A= > =3D true" line.=0A= > =0A= > Though the changes in my tree are mainly for getting Android up and =0A= > running and not related to USB.=0A= > =0A= > thanks=0A= > -john=0A= =0A= Looking through the dmesg log you have provided, It seems that the debug = =0A= is disabled.=0A= Could you please provide log with debug enabled configuration. So that =0A= we can see more about the described problem.=0A= =0A= Also, the register dump could be really helpful for us. Please provide =0A= it too.=0A= =0A= Regards,=0A= Artur=0A= From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: dwc2: Fix HiKey regression caused by power_down feature From: Artur Petrosyan Message-Id: <3AD91E696667BF4BA728303C178E8A63532B89A4@am04wembxb.internal.synopsys.com> Date: Mon, 1 Oct 2018 06:56:20 +0000 To: John Stultz , Artur Petrosyan Cc: Minas Harutyunyan , lkml , John Youn , Felipe Balbi , "linux-usb@vger.kernel.org" , Manivannan Sadhasivam List-ID: SGkgSm9obiwKCk9uIDkvMjgvMjAxOCAyMjozMCwgSm9obiBTdHVsdHogd3JvdGU6Cj4gT24gVHVl LCBTZXAgMjUsIDIwMTggYXQgMTE6MDIgUE0sIEFydHVyIFBldHJvc3lhbiAKPiA8YXJ0aHVyLnBl dHJvc3lhbkBzeW5vcHN5cy5jb20gPG1haWx0bzphcnRodXIucGV0cm9zeWFuQHN5bm9wc3lzLmNv bT4+IAo+IHdyb3RlOgo+ICA+IE9uIDkvMjUvMjAxOCAyMTo1OSwgSm9obiBTdHVsdHogd3JvdGU6 Cj4gID4+IE9uIFR1ZSwgU2VwIDI1LCAyMDE4IGF0IDM6MDQgQU0sIEFydHVyIFBldHJvc3lhbgo+ ICA+PiA8YXJ0aHVyLnBldHJvc3lhbkBzeW5vcHN5cy5jb20gCj4gPG1haWx0bzphcnRodXIucGV0 cm9zeWFuQHN5bm9wc3lzLmNvbT4+IHdyb3RlOgo+ICA+Pj4gSnVzdCBhIGNsYXJpZmljYXRpb24g YnkgdGhpcyBjb21taXQgIltQQVRDSF0gdXNiOiBkd2MyOiBGaXggSGlLZXkKPiAgPj4+IHJlZ3Jl c3Npb24gY2F1c2VkIGJ5IHBvd2VyX2Rvd24gZmVhdHVyZSIKPiAgPj4+IAo+IGh0dHBzOi8vdXJs ZGVmZW5zZS5wcm9vZnBvaW50LmNvbS92Mi91cmw/dT1odHRwcy0zQV9fbWFyYy5pbmZvXy0zRmwt M0RsaW51eC0yRHVzYi0yNm0tM0QxNTI2NjkwOTU1MTMyNDgtMjZ3LTNEMiZkPUR3SUJhUSZjPURQ TDZfWF82SmtYRng3QVhXcUIwdGcmcj05aFBCRktDSl9uQmpKaEdWcnJsWU9lT1FqUF9IbFZ6WXFy Q19EN25pTUpJJm09MGxNa3Y3YWRGVndrenlhVXpENi1wVUcwaXdnNGZkNmIxLWFIUWdicXZTSSZz PW04U1p2bzNKX1phMDhzTWJvLVM5RWtob0EwNlluekVOLVNSbS11VFBuYmcmZT0KPiAgPj4+Cj4g ID4+PiB0aGUgcG93ZXJfZG93biBpcyBkaXNhYmxlZCBzZXR0aW5nICJwLT5wb3dlcl9kb3duID0g ZmFsc2U7IiBpbgo+ICA+Pj4gImR3YzJfc2V0X2hpc19wYXJhbXMiIGZ1bmN0aW9uLgo+ICA+Pj4K PiAgPj4+IENvdWxkIHlvdSBwbGVhc2UgY2xhcmlmeSB0aGF0IHRoZSB0ZXN0ZXMgZG9uZSBmb3Ig dGhvc2UgMyBwYXRjaGVzIHdlcmUKPiAgPj4+IGRvbmUgZW5hYmxpbmcgInAtPnBvd2VyX2Rvd24g PSB0cnVlOyIgaW4gImR3YzJfc2V0X2hpc19wYXJhbXMiIAo+IGZ1bmN0aW9uLgo+ICA+Pgo+ICA+ PiBTbyBpZiBJIHJlbW92ZSB0aGUgInBvd2VyX2Rvd24gPSB0cnVlIiBpbml0aWFsaXphdGlvbiwg VVNCIGRvZXMgbm90Cj4gID4+IHNlZW0gdG8gZnVuY3Rpb24uCj4gID4+Cj4gID4+IElmIEkgYm9v dCB3LyB0aGUgZ2FkZ2V0IHBvcnQgcmVtb3ZlZCwgdGhlIFVTQiBob3N0IHBvcnRzIGRvIHdvcmss IGJ1dAo+ICA+PiBwbHVnZ2luZyBpbiB0aGUgZ2FkZ2V0IGNhYmxlIHJlc3VsdHMgaW4gYSBidW5j aCBvZjoKPiAgPj4gwqAgwqAgZHdjMiBmNzJjMDAwMC51c2I6IFdhaXRpbmcgZm9yIEhvc3QgTW9k ZSwgTW9kZT1QZXJpcGhlcmFsCj4gID4+IG1lc3NhZ2VzLgo+ICA+Pgo+ICA+PiBJZiBJIGJvb3Qg dy8gdGhlIGdhZGdldCBwb3J0IHBsdWdnZWQgaW4sIFVTQiBnYWRnZXQgbW9kZSBkb2Vzbid0IHNl ZW0KPiAgPj4gdG8gZnVuY3Rpb24gYXQgYWxsLCBhbmQgd2hlbiBJIHJlbW92ZSB0aGUgZ2FkZ2V0 IGNhYmxlIG5vdGhpbmcKPiAgPj4gaGFwcGVucywgaXQgZG9lc24ndCBzd2l0Y2ggdG8gaG9zdCBt b2RlLgo+ICA+Pgo+ICA+Cj4gID4gQ291bGQgeW91IHBsZWFzZSBzZW5kIHRoZSBkbWVzZyBsb2dz IGZvciB0aG9zZSBzaXR1YXRpb25zPwo+IAo+IEF0dGFjaGVkIHdpdGggc29tZSBhbm5vdGF0aW9u cyBpbiB0aGUgbG9nLgo+IAo+ICA+IEFsc28sIHBsZWFzZSBzcGVjaWZ5IHRoZSB2ZXJzaW9uIG9m IHRoZSBrZXJuZWwgdGhhdCB0aGUgdGVzdGVzIGhhcyBiZWVuCj4gID4gZG9uZSBvbi4KPiAKPiBU aGlzIHdhcyBkb25lIHV0aWxpemluZyBteSBkZXYvaGlrZXktbWFpbmxpbmUtV0lQIGJyYW5jaCBo ZXJlOgo+IGh0dHBzOi8vZ2l0LmxpbmFyby5vcmcvcGVvcGxlL2pvaG4uc3R1bHR6L2FuZHJvaWQt ZGV2LmdpdC9sb2cvP2g9ZGV2L2hpa2V5LW1haW5saW5lLVdJUCAKPiA8aHR0cHM6Ly91cmxkZWZl bnNlLnByb29mcG9pbnQuY29tL3YyL3VybD91PWh0dHBzLTNBX19naXQubGluYXJvLm9yZ19wZW9w bGVfam9obi5zdHVsdHpfYW5kcm9pZC0yRGRldi5naXRfbG9nXy0zRmgtM0RkZXZfaGlrZXktMkRt YWlubGluZS0yRFdJUCZkPUR3TUZhUSZjPURQTDZfWF82SmtYRng3QVhXcUIwdGcmcj05aFBCRktD Sl9uQmpKaEdWcnJsWU9lT1FqUF9IbFZ6WXFyQ19EN25pTUpJJm09TnppQkh1MEYwZWVmUUU3Q2Vo VE1BSEY5Um5iZlN6ZkhlU095NU1VTXZfbyZzPU16UW1URjQ3VmVkM1FlMnZoTDY2LWh5eFd5TFV3 Y0M1a0s3QmhaanhSdkkmZT0+Cj4gCj4gd2hpY2ggaXMgNC4xOS4wLXJjNSBiYXNlZCArIHlvdXIg MyBwYXRjaGVzICsgcmVtb3ZpbmcgdGhlICJwLT5wb3dlcl9kb3duIAo+ID0gdHJ1ZSIgbGluZS4K PiAKPiBUaG91Z2ggdGhlIGNoYW5nZXMgaW4gbXkgdHJlZSBhcmUgbWFpbmx5IGZvciBnZXR0aW5n IEFuZHJvaWQgdXAgYW5kIAo+IHJ1bm5pbmcgYW5kIG5vdCByZWxhdGVkIHRvIFVTQi4KPiAKPiB0 aGFua3MKPiAtam9obgoKTG9va2luZyB0aHJvdWdoIHRoZSBkbWVzZyBsb2cgeW91IGhhdmUgcHJv dmlkZWQsIEl0IHNlZW1zIHRoYXQgdGhlIGRlYnVnIAppcyBkaXNhYmxlZC4KQ291bGQgeW91IHBs ZWFzZSBwcm92aWRlIGxvZyB3aXRoIGRlYnVnIGVuYWJsZWQgY29uZmlndXJhdGlvbi4gU28gdGhh dCAKd2UgY2FuIHNlZSBtb3JlIGFib3V0IHRoZSBkZXNjcmliZWQgcHJvYmxlbS4KCkFsc28sIHRo ZSByZWdpc3RlciBkdW1wIGNvdWxkIGJlIHJlYWxseSBoZWxwZnVsIGZvciB1cy4gUGxlYXNlIHBy b3ZpZGUgCml0IHRvby4KClJlZ2FyZHMsCkFydHVyCg==