From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Pattan, Reshma" <reshma.pattan@intel.com>
Subject: Re: [PATCH 04/20] thunderx/nicvf: add get_reg
	and	get_reg_length support
Date: Thu, 12 May 2016 15:39:56 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F01025933@IRSMSX109.ger.corp.intel.com>
References: <1462634198-2289-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1462634198-2289-5-git-send-email-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>, "Richardson,
 Bruce" <bruce.richardson@intel.com>, Maciej Czekaj
 <maciej.czekaj@caviumnetworks.com>, Kamil Rytarowski
 <Kamil.Rytarowski@caviumnetworks.com>, Zyta Szpak <zyta.szpak@semihalf.com>,
 Slawomir Rosek <slawomir.rosek@semihalf.com>, Radoslaw Biernacki
 <rad@semihalf.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id B65C56A68
 for <dev@dpdk.org>; Thu, 12 May 2016 17:41:48 +0200 (CEST)
In-Reply-To: <1462634198-2289-5-git-send-email-jerin.jacob@caviumnetworks.com>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob
> Sent: Saturday, May 7, 2016 4:16 PM
> To: dev@dpdk.org
> Cc: thomas.monjalon@6wind.com; Richardson, Bruce
> <bruce.richardson@intel.com>; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>; Maciej Czekaj
> <maciej.czekaj@caviumnetworks.com>; Kamil Rytarowski
> <Kamil.Rytarowski@caviumnetworks.com>; Zyta Szpak
> <zyta.szpak@semihalf.com>; Slawomir Rosek <slawomir.rosek@semihalf.com>;
> Radoslaw Biernacki <rad@semihalf.com>
> Subject: [dpdk-dev] [PATCH 04/20] thunderx/nicvf: add get_reg and
> get_reg_length support
>=20
> +
> +static int
> +nicvf_dev_get_regs(struct rte_eth_dev *dev, struct rte_dev_reg_info
> +*regs) {
> +	uint64_t *data =3D regs->data;
> +	struct nicvf *nic =3D nicvf_pmd_priv(dev);
> +
> +	if (data =3D=3D NULL)
> +		return -EINVAL;

nicvf_reg_dump prints to stdout if data in NULL, so do we still want to ret=
urn here?

Thanks,
Reshma