From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Pattan, Reshma" <reshma.pattan@intel.com>
Subject: Re: [PATCH 01/20] thunderx/nicvf/base: add hardware API
 for	ThunderX nicvf inbuilt NIC
Date: Thu, 12 May 2016 15:40:19 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F01025942@IRSMSX109.ger.corp.intel.com>
References: <1462634198-2289-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1462634198-2289-2-git-send-email-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>, "Richardson,
 Bruce" <bruce.richardson@intel.com>, Maciej Czekaj
 <maciej.czekaj@caviumnetworks.com>, Kamil Rytarowski
 <Kamil.Rytarowski@caviumnetworks.com>, Zyta Szpak <zyta.szpak@semihalf.com>,
 Slawomir Rosek <slawomir.rosek@semihalf.com>, Radoslaw Biernacki
 <rad@semihalf.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 9EA275AB4
 for <dev@dpdk.org>; Thu, 12 May 2016 17:40:37 +0200 (CEST)
In-Reply-To: <1462634198-2289-2-git-send-email-jerin.jacob@caviumnetworks.com>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob
> Sent: Saturday, May 7, 2016 4:16 PM
> To: dev@dpdk.org
> Cc: thomas.monjalon@6wind.com; Richardson, Bruce
> <bruce.richardson@intel.com>; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>; Maciej Czekaj
> <maciej.czekaj@caviumnetworks.com>; Kamil Rytarowski
> <Kamil.Rytarowski@caviumnetworks.com>; Zyta Szpak
> <zyta.szpak@semihalf.com>; Slawomir Rosek <slawomir.rosek@semihalf.com>;
> Radoslaw Biernacki <rad@semihalf.com>
> Subject: [dpdk-dev] [PATCH 01/20] thunderx/nicvf/base: add hardware API f=
or
> ThunderX nicvf inbuilt NIC
>=20
> +int
> +nicvf_reg_poll_interrupts(struct nicvf *nic)
> +{
> +	int msg =3D 0;
> +	uint64_t intr;
> +
> +	intr =3D nicvf_reg_read(nic, NIC_VF_INT);
> +	if (intr & NICVF_INTR_MBOX_MASK) {
> +		nicvf_reg_write(nic, NIC_VF_INT, NICVF_INTR_MBOX_MASK);
> +		msg =3D nicvf_handle_mbx_intr(nic);
> +	}
> +	if (intr & NICVF_INTR_QS_ERR_MASK) {
> +		nicvf_reg_write(nic, NIC_VF_INT, NICVF_INTR_QS_ERR_MASK);
> +		nicvf_handle_qset_err_intr(nic);
> +	}
> +	return msg;
> +}
> +
> +
[Reshma]: Multiple blank lines

> +int
> +nicvf_qset_rbdr_reclaim(struct nicvf *nic, uint16_t qidx)
> +{
> +	uint64_t status;
> +	int timeout =3D 10;
> +	struct nicvf_rbdr *rbdr =3D nic->rbdr;
> +
> +	/* Save head and tail pointers for freeing up buffers */
> +	if (rbdr) {
> +		rbdr->head =3D nicvf_queue_reg_read(nic,
> +					  NIC_QSET_RBDR_0_1_HEAD,
> +					  qidx) >> 3;
> +		rbdr->tail =3D nicvf_queue_reg_read(nic,
> +					  NIC_QSET_RBDR_0_1_TAIL,
> +					  qidx) >> 3;

 [Reshma]: Mix of tabs + spaces, u can use all tabs, U can correct this for=
 other parts of  the file and other files too.=20

Thanks,
Reshma