From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Pattan, Reshma" <reshma.pattan@intel.com>
Subject: Re: [PATCH v2 07/12] pdump: disabled by default
Date: Fri, 9 Jun 2017 14:24:58 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A2133A4@irsmsx110.ger.corp.intel.com>
References: <cover.1496877060.git.gaetan.rivet@6wind.com>
 <87a12a85ab782a5995100ea1e2ae80a2c7e0ec5e.1496877060.git.gaetan.rivet@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id CFC8C2B92
 for <dev@dpdk.org>; Fri,  9 Jun 2017 16:25:02 +0200 (CEST)
In-Reply-To: <87a12a85ab782a5995100ea1e2ae80a2c7e0ec5e.1496877060.git.gaetan.rivet@6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gaetan Rivet
> Sent: Thursday, June 8, 2017 12:59 AM
> To: dev@dpdk.org
> Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
> Subject: [dpdk-dev] [PATCH v2 07/12] pdump: disabled by default
>=20
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
>  config/common_base | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/config/common_base b/config/common_base index
> cade611..8ec5e4e 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -700,7 +700,7 @@ CONFIG_RTE_KNI_PREEMPT_DEFAULT=3Dy  #  # Compile
> the pdump library  # -CONFIG_RTE_LIBRTE_PDUMP=3Dy
> +CONFIG_RTE_LIBRTE_PDUMP=3Dn
>=20
>  #
>  # Compile vhost user library
> --
> 2.1.4

Since, you already mentioned in other mail to Ferruh that config flag disab=
ling patches are only for testers compilation purpose and you have plans to=
 make proper fix by end of June.  I will wait on for actual patch.=20

Please see if rte_pci.h can be removed from the includes of rte_pdump.c , m=
ight be unnecessary include.

Thanks,
Reshma