From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Pattan, Reshma" <reshma.pattan@intel.com>
Subject: Re: [PATCH 4/4] ether: add packet modification aciton
	in	flow API
Date: Thu, 29 Mar 2018 15:23:12 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A2BBD18@irsmsx110.ger.corp.intel.com>
References: <1522279780-34842-1-git-send-email-qi.z.zhang@intel.com>
 <1522279780-34842-5-git-send-email-qi.z.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Doherty, Declan"
 <declan.doherty@intel.com>, "Chandran, Sugesh" <sugesh.chandran@intel.com>,
 "Glynn, Michael J" <michael.j.glynn@intel.com>, "Liu, Yu Y"
 <yu.y.liu@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>, "Zhang, Qi Z"
 <qi.z.zhang@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "adrien.mazarguil@6wind.com"
 <adrien.mazarguil@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 572982BB1
 for <dev@dpdk.org>; Thu, 29 Mar 2018 17:23:16 +0200 (CEST)
In-Reply-To: <1522279780-34842-5-git-send-email-qi.z.zhang@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

> Subject: [dpdk-dev] [PATCH 4/4] ether: add packet modification aciton in =
flow

Typo in the commit message header "action"

> +/** RTE_FLOW_ACTION_TYPE_FIELD_INCREMENT
> + *
> + * Increment 1 on specific field of the packet.
> + *
> + * Typical usage: increase TTL
> + */
> +struct rte_flow_action_field_increment {
> +	const struct rte_flow_item *item; /**< specify the data to modify. */
> +	uint8_t layer;
> +	/**< 0 means outermost matched pattern, 1 means next-to-
> outermost...
> +*/ };
> +
> +/** RTE_FLOW_ACTION_TYPE_FIELD_DECREMENT
> + *
> + * Decrement 1 on specific field of the packet.
> + *
> + * Typical usage: Decrease TTL
> + */
> +struct rte_flow_action_field_decrement {
> +	const struct rte_flow_item *item; /**< Specify the data to modify. */
> +	uint8_t layer;
> +	/**< 0 means outermost matched pattern, 1 means next-to-
> outermost...
> +*/ };
> +

Can you have only one  struct to represent both increment/decrements operat=
ions instead of two structs? As I see both use same data types .=20

Thanks,
Reshma