Re: [PATCH v2 3/4] eal: add directory for DPDK runtime data

["Pattan, Reshma" <reshma.pattan@intel.com>]

Hi,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Anatoly Burakov
> Sent: Monday, April 30, 2018 1:09 PM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; thomas@monjalon.net
> Subject: [dpdk-dev] [PATCH v2 3/4] eal: add directory for DPDK runtime data
> 
> Currently, during runtime, DPDK will store a bunch of files here and there (in
> /var/run, /tmp or in $HOME). Fix it by creating a DPDK-specific runtime
> directory, under which all runtime data will be placed. The template for
> creating this runtime directory is the following:
> 
>   <base path>/dpdk/<DPDK prefix>/
> 
> Where <base path> is set to either "/var/run" if run as root, or
> $XDG_RUNTIME_DIR if run as non-root, with a fallback to /tmp if
> $XDG_RUNTIME_DIR is not defined. So, for example, if run as root, by default
> all runtime data will be stored at /var/run/dpdk/rte/.
> 
> There is no equivalent of "mkdir -p", so we will be creating the path step by
> step.
> 
> Nothing uses this new path yet, changes for that will come in next commit.
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>  lib/librte_eal/bsdapp/eal/eal.c        | 68
> ++++++++++++++++++++++++++++++++++
>  lib/librte_eal/common/eal_filesystem.h |  8 ++++
>  lib/librte_eal/linuxapp/eal/eal.c      | 67
> +++++++++++++++++++++++++++++++++
>  3 files changed, 143 insertions(+)
> 

Looks good to me.
Reviewed-by: Reshma Pattan <reshma.pattan@intel.cm>