From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Pattan, Reshma" <reshma.pattan@intel.com>
Subject: Re: [PATCH v1 2/9] app/procinfo: add compare for new
	options
Date: Thu, 25 Oct 2018 15:18:48 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A3BE084@irsmsx110.ger.corp.intel.com>
References: <20181023135751.21536-1-vipin.varghese@intel.com>
 <20181023135751.21536-2-vipin.varghese@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Patel, Amol" <amol.patel@intel.com>, "Tummala, Sivaprasad"
 <sivaprasad.tummala@intel.com>, "Byrne, Stephen1" <stephen1.byrne@intel.com>,
 "Glynn, Michael J" <michael.j.glynn@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "Tahhan, Maryam" <maryam.tahhan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id 474CB7CE2
 for <dev@dpdk.org>; Thu, 25 Oct 2018 17:18:52 +0200 (CEST)
In-Reply-To: <20181023135751.21536-2-vipin.varghese@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Varghese, Vipin

> +/**< Enable port debug. */
In comment , Enable displaying port info?

> +static uint32_t enable_dbg_port;
Do you want to consider replacing "debug" to "show" in code here other plac=
es? As you have already changed the commands to "show."

				ring_name =3D optarg;
How about doing memcpy instead of pointer assignment? Similarly below. Thou=
gh I don't see issue here. But safe to use memcpy.

> +			} else if (!strncmp(long_option[option_index].name,
> +					"dbg-mempool",
> MAX_LONG_OPT_SZ)) {
> +				enable_dbg_mempool =3D 1;
> +				mempool_name =3D optarg;
> +			}

Thanks,
Reshma