From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Chaitanya Babu, TalluriX" <tallurix.chaitanya.babu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Marohn, Byron" <byron.marohn@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH] lib: fix write unlock during ring creation
Date: Tue, 13 Nov 2018 16:58:11 +0000 [thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A3D301C@irsmsx110.ger.corp.intel.com> (raw)
In-Reply-To: <1542113714-22607-1-git-send-email-tallurix.chaitanya.babu@intel.com>
> -----Original Message-----
> From: Chaitanya Babu, TalluriX
> Sent: Tuesday, November 13, 2018 12:55 PM
> To: dev@dpdk.org
> Cc: Marohn, Byron <byron.marohn@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Chaitanya Babu, TalluriX
> <tallurix.chaitanya.babu@intel.com>; stable@dpdk.org
> Subject: [PATCH] lib: fix write unlock during ring creation
Heading should have lib/efd:
>
> In rte_efd_create() write lock has already been unlocked before ring creation
> itself.
> So second unlock after the ring creation has been removed and added freeing of
> tail queue entry and efd table.
Changes do not have free of tailq entry, so remove the mention of it from commit message.
> - /* Create ring (Dummy slot index is not enqueued) */
> + /* Create ring (Dummy slot index is not enqueued) */
Undo this change. Unrelated.
Other than these looks ok.
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
Thanks,
Reshma
next prev parent reply other threads:[~2018-11-13 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 12:55 [PATCH] lib: fix write unlock during ring creation Chaitanya Babu Talluri
2018-11-13 16:58 ` Pattan, Reshma [this message]
2018-11-18 14:43 ` [dpdk-stable] " Thomas Monjalon
2018-11-14 11:24 ` [PATCH v2] lib/efd: " Chaitanya Babu Talluri
2018-11-16 13:39 ` [dpdk-stable] " Ferruh Yigit
2018-11-18 14:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A3D301C@irsmsx110.ger.corp.intel.com \
--to=reshma.pattan@intel.com \
--cc=byron.marohn@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
--cc=tallurix.chaitanya.babu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.