From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Pattan, Reshma" <reshma.pattan@intel.com>
Subject: Re: [PATCH v6 1/9] app/procinfo: add usage for new debug
Date: Wed, 12 Dec 2018 14:14:53 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A3E9BB8@irsmsx110.ger.corp.intel.com>
References: <20181122141543.37067-1-vipin.varghese@intel.com>
 <20181203055000.39012-1-vipin.varghese@intel.com>
 <20181203055000.39012-2-vipin.varghese@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "thomas@monjalon.net" <thomas@monjalon.net>, "Byrne, Stephen1"
 <stephen1.byrne@intel.com>, "Patel, Amol" <amol.patel@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>, "Ananyev, Konstantin"
 <konstantin.ananyev@intel.com>, "stephen@networkplumber.org"
 <stephen@networkplumber.org>, "dev@dpdk.org" <dev@dpdk.org>, "Mcnamara, John"
 <john.mcnamara@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id 6D6491B3B9
 for <dev@dpdk.org>; Wed, 12 Dec 2018 15:14:57 +0100 (CET)
In-Reply-To: <20181203055000.39012-2-vipin.varghese@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Varghese, Vipin
> Sent: Monday, December 3, 2018 5:50 AM
> Subject: [PATCH v6 1/9] app/procinfo: add usage for new debug
>=20
> @@ -83,7 +87,13 @@ proc_info_usage(const char *prgname)
>  		"  --stats-reset: to reset port statistics\n"
>  		"  --xstats-reset: to reset port extended statistics\n"
>  		"  --collectd-format: to print statistics to STDOUT in expected by
> collectd format\n"
> -		"  --host-id STRING: host id used to identify the system process
> is running on\n",
> +		"  --host-id STRING: host id used to identify the system process
> is running on\n"
> +		"  --show-port to display ports information\n"
> +		"  --show-tm to display traffic manager information for ports\n"
> +		"  --show-crypto to display crypto information\n"
> +		"  --show-ring[=3Dname] to display ring information\n"
> +		"  --show-mempool[=3Dname] to display mempool information\n"
> +		"  --iter-mempool=3Dname to iterate mempool elements\n",
>  		prgname);
>  }
>=20

Style related comment, add ' :'  between  command token  and token message,=
 similar to host-id and other .

Is iter-mempool option, only to iterate only or to display the elements als=
o? Then update the help message.

Thanks,
Reshma