From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D7B562126CFA9 for ; Wed, 15 May 2019 17:31:34 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id z128so1214718qkb.6 for ; Wed, 15 May 2019 17:31:34 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [RESEND PATCH] nvdimm: fix some compilation warnings From: Qian Cai In-Reply-To: Date: Wed, 15 May 2019 20:31:31 -0400 Message-Id: <3D0A6725-A738-4778-BB5B-1617B6184337@lca.pw> References: <20190514150735.39625-1-cai@lca.pw> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: linux-nvdimm , Linux Kernel Mailing List , Andrew Morton List-ID: Cj4+ICAgICAgICAgICAgICAgIH0KPj4gCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL252ZGltbS9i dXMuYyBiL2RyaXZlcnMvbnZkaW1tL2J1cy5jCj4+IGluZGV4IDdmZjY4NDE1OWYyOS4uMmViNmE2 Y2ZlOWU0IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL252ZGltbS9idXMuYwo+PiArKysgYi9kcml2 ZXJzL252ZGltbS9idXMuYwo+PiBAQCAtNjQyLDcgKzY0Miw3IEBAIHN0YXRpYyBzdHJ1Y3QgYXR0 cmlidXRlICpuZF9kZXZpY2VfYXR0cmlidXRlc1tdID0gewo+PiAgICAgICAgTlVMTCwKPj4gfTsK Pj4gCj4+IC0vKioKPj4gKy8qCj4+ICAqIG5kX2RldmljZV9hdHRyaWJ1dGVfZ3JvdXAgLSBnZW5l cmljIGF0dHJpYnV0ZXMgZm9yIGFsbCBkZXZpY2VzIG9uIGFuIG5kIGJ1cwo+PiAgKi8KPj4gc3Ry dWN0IGF0dHJpYnV0ZV9ncm91cCBuZF9kZXZpY2VfYXR0cmlidXRlX2dyb3VwID0gewo+PiBAQCAt NjcxLDcgKzY3MSw3IEBAIHN0YXRpYyB1bW9kZV90IG5kX251bWFfYXR0cl92aXNpYmxlKHN0cnVj dCBrb2JqZWN0ICprb2JqLCBzdHJ1Y3QgYXR0cmlidXRlICphLAo+PiAgICAgICAgcmV0dXJuIGEt Pm1vZGU7Cj4+IH0KPj4gCj4+IC0vKioKPj4gKy8qCj4+ICAqIG5kX251bWFfYXR0cmlidXRlX2dy b3VwIC0gTlVNQSBhdHRyaWJ1dGVzIGZvciBhbGwgZGV2aWNlcyBvbiBhbiBuZCBidXMKPj4gICov Cj4gCj4gTGV0cyBqdXN0IGZpeCB0aGlzIHRvIGJlIGEgdmFsaWQga2VybmVsLWRvYyBmb3JtYXQg Zm9yIGEgc3RydWN0Lgo+IAo+IEBAIC02NzIsNyArNjcyLDcgQEAgc3RhdGljIHVtb2RlX3QgbmRf bnVtYV9hdHRyX3Zpc2libGUoc3RydWN0IGtvYmplY3QKPiAqa29iaiwgc3RydWN0IGF0dHJpYnV0 ZSAqYSwKPiB9Cj4gCj4gLyoqCj4gLSAqIG5kX251bWFfYXR0cmlidXRlX2dyb3VwIC0gTlVNQSBh dHRyaWJ1dGVzIGZvciBhbGwgZGV2aWNlcyBvbiBhbiBuZCBidXMKPiArICogc3RydWN0IG5kX251 bWFfYXR0cmlidXRlX2dyb3VwIC0gTlVNQSBhdHRyaWJ1dGVzIGZvciBhbGwgZGV2aWNlcwo+IG9u IGFuIG5kIGJ1cwo+ICAqLwo+IHN0cnVjdCBhdHRyaWJ1dGVfZ3JvdXAgbmRfbnVtYV9hdHRyaWJ1 dGVfZ3JvdXAgPSB7Cj4gICAgICAgIC5hdHRycyA9IG5kX251bWFfYXR0cmlidXRlcywKClRoaXMg d29u4oCZdCB3b3JrIGJlY2F1c2Uga2VybmVsLWRvYyBpcyB0byBleHBsYWluIGEgc3RydWN0IGRl ZmluaXRpb24sIGJ1dCB0aGlzIGlzIGEganVzdCBhbiBhc3NpZ25tZW50LgpUaGUgInN0cnVjdCBh dHRyaWJ1dGVfZ3JvdXDigJ0ga2VybmVsLWRvYyBpcyBpbiBpbmNsdWRlL2xpbnV4L3N5c2ZzLmgu Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LW52 ZGltbSBtYWlsaW5nIGxpc3QKTGludXgtbnZkaW1tQGxpc3RzLjAxLm9yZwpodHRwczovL2xpc3Rz LjAxLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW52ZGltbQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36340C04E53 for ; Thu, 16 May 2019 01:46:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECC2420843 for ; Thu, 16 May 2019 01:46:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="ce87YEoH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726772AbfEPBqv (ORCPT ); Wed, 15 May 2019 21:46:51 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:37430 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726569AbfEPAbe (ORCPT ); Wed, 15 May 2019 20:31:34 -0400 Received: by mail-qk1-f196.google.com with SMTP id d10so1224486qko.4 for ; Wed, 15 May 2019 17:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=xM+RFeuYKRxsIgkngGYK7F1nhOVwIknDUHFDYwBWS4M=; b=ce87YEoHQ3gEM1Pzl/OZnHRrbCQNF03DWhlezURYXEiSlkgU4w4mEO67/poVC2z5le a7DclrrqaCnPRhZ2hMIjN2Ax7PaZGQci2kVFNksfsJ7RnluEd6LDYlf3M9b871fljHW8 4IwjunFUffu8qlpNONdUAYqTISgTgNo/vgKWZWhVNEKDLJeuQ7YzpmGht/RfwqaWBs0W xui8kjZq2sEEOlRIiENHuG6jlYQ24vX5rQyKSmP2pAHBBvk3Bh4P30TSBVU6dpTS/M1B 5zKkeAtsOJF7coQpXiBHJpQM2FeqGxb/MyBSa+Ab3Mq1STKRb06LMCoh1j4bRjVF3so5 9A4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=xM+RFeuYKRxsIgkngGYK7F1nhOVwIknDUHFDYwBWS4M=; b=gvUg2xX9exLf6N0OqEYepOVvdF2LmxIsvGLBHlvfHG5mOPHmm26F55uQAnBjmlsOZZ mluGoN8lUIElBlEsToFgUbBLhVW73XF8f1VtaGkbP9d1VztL7kuVFbNq0hX0ZFOwxAwC BwAZgkiuJsQwOECNvgUjkGsDS5bqpVCYak7FYREZyZu6UHIuZv5Vr1TS9NWGGzy8Sqrx wYTegJ9esEq+OKN14j1pQQ9HU2TBS7wpIhiUAorh4m72yMImmaLFBhHwF13iNlU7KyQg sLGHqtq4wp1tji4BSzkxi+LCwQC8vy12U78YrPcdb62XKa0mK+EFn8JaVMN73LgVC3JF zXsg== X-Gm-Message-State: APjAAAW24Gb33LTWW4oyPZfNdvRu+nL1BpF3a6M3YepBKTcXQLkypfcg 04B/VXfAAa+dJt3BWfSPVGbE1Q== X-Google-Smtp-Source: APXvYqz3fHzTPnf64v8pB/ZHAteLVwxI4396VUH6eGzP3onjT97IZWc+DOk95vqA8DE+NZSD0H/6lw== X-Received: by 2002:a37:aa42:: with SMTP id t63mr35422129qke.353.1557966692992; Wed, 15 May 2019 17:31:32 -0700 (PDT) Received: from qians-mbp.fios-router.home (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id m18sm1842826qki.21.2019.05.15.17.31.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 May 2019 17:31:32 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [RESEND PATCH] nvdimm: fix some compilation warnings From: Qian Cai In-Reply-To: Date: Wed, 15 May 2019 20:31:31 -0400 Cc: Andrew Morton , Vishal L Verma , Dave Jiang , Keith Busch , "Weiny, Ira" , linux-nvdimm , Linux Kernel Mailing List Content-Transfer-Encoding: quoted-printable Message-Id: <3D0A6725-A738-4778-BB5B-1617B6184337@lca.pw> References: <20190514150735.39625-1-cai@lca.pw> To: Dan Williams X-Mailer: Apple Mail (2.3445.104.11) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> } >>=20 >> diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c >> index 7ff684159f29..2eb6a6cfe9e4 100644 >> --- a/drivers/nvdimm/bus.c >> +++ b/drivers/nvdimm/bus.c >> @@ -642,7 +642,7 @@ static struct attribute *nd_device_attributes[] =3D= { >> NULL, >> }; >>=20 >> -/** >> +/* >> * nd_device_attribute_group - generic attributes for all devices on = an nd bus >> */ >> struct attribute_group nd_device_attribute_group =3D { >> @@ -671,7 +671,7 @@ static umode_t nd_numa_attr_visible(struct = kobject *kobj, struct attribute *a, >> return a->mode; >> } >>=20 >> -/** >> +/* >> * nd_numa_attribute_group - NUMA attributes for all devices on an nd = bus >> */ >=20 > Lets just fix this to be a valid kernel-doc format for a struct. >=20 > @@ -672,7 +672,7 @@ static umode_t nd_numa_attr_visible(struct kobject > *kobj, struct attribute *a, > } >=20 > /** > - * nd_numa_attribute_group - NUMA attributes for all devices on an nd = bus > + * struct nd_numa_attribute_group - NUMA attributes for all devices > on an nd bus > */ > struct attribute_group nd_numa_attribute_group =3D { > .attrs =3D nd_numa_attributes, This won=E2=80=99t work because kernel-doc is to explain a struct = definition, but this is a just an assignment. The "struct attribute_group=E2=80=9D kernel-doc is in = include/linux/sysfs.h.=