All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Donald Becker <becker@scyld.com>
Cc: Jeff Garzik <jgarzik@mandrakesoft.com>, jamal <hadi@cyberus.ca>,
	netdev@oss.sgi.com
Subject: Re: [ANNOUNCE] NAPI patches for 2.4.19-rc1
Date: Thu, 11 Jul 2002 10:17:24 -0700	[thread overview]
Message-ID: <3D2DBDA4.4090009@candelatech.com> (raw)
In-Reply-To: Pine.LNX.4.44.0207111238570.2498-100000@beohost.scyld.com

Donald Becker wrote:

> Very, very few vendor patchs are worth applying.  They sometimes know of
> otherwise undocumented chip bugs, but a lot of the actual code is bad.
> 
> It's not "maintaining" a driver when you just take a vendor modification
> of a driver and assume it's OK.  You have to understand the changes and
> evaluate if they make sense.

I don't know the quality of the patches submitted by dlink, but I do
know that the existing driver in the 2.4.18 kernel absolutely does not
work at all.  So, if there is a hack/patch that makes it work, I consider
that better than completely broken, even if it is ugly.

Of course, the preferred driver would be clean and work with all chipsets,
but those are not easy to find.

Ben

-- 
Ben Greear <greearb@candelatech.com>       <Ben_Greear AT excite.com>
President of Candela Technologies Inc      http://www.candelatech.com
ScryMUD:  http://scry.wanfear.com     http://scry.wanfear.com/~greear

  reply	other threads:[~2002-07-11 17:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-10 22:32 [ANNOUNCE] NAPI patches for 2.4.19-rc1 Jason Lunz
2002-07-10 22:56 ` Ben Greear
2002-07-11 13:20   ` Jason Lunz
2002-07-10 23:34 ` jamal
2002-07-11  0:41   ` Donald Becker
2002-07-11 14:57     ` Jeff Garzik
2002-07-11 16:50       ` Donald Becker
2002-07-11 17:17         ` Ben Greear [this message]
2002-07-11 18:31           ` Jeff Garzik
2002-07-11 22:31             ` Ben Greear
2002-07-12 15:11               ` Jason Lunz
2002-07-11 18:53           ` Donald Becker
2002-07-11 19:34         ` Jeff Garzik
2002-07-11 13:26   ` Jason Lunz
2002-07-11 13:39     ` Jeff Garzik
2002-07-11 13:44       ` Jason Lunz
2002-07-11 14:33         ` Donald Becker
2002-07-11 14:37         ` Jeff Garzik
2002-07-11 16:00 ` Robert Olsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D2DBDA4.4090009@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=becker@scyld.com \
    --cc=hadi@cyberus.ca \
    --cc=jgarzik@mandrakesoft.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.