From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Mokhtar, Amr" <amr.mokhtar@intel.com>
Subject: Re: [PATCH v1 1/6] bbdev: librte_bbdev library
Date: Wed, 18 Oct 2017 02:25:05 +0000
Message-ID: <3D3765A8CDB52A4C8B410430AA19CB236EC43A6A@IRSMSX101.ger.corp.intel.com>
References: <1506735475-77078-1-git-send-email-amr.mokhtar@intel.com>
 <E115CCD9D858EF4F90C690B0DCB4D8976CC3463B@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Power, Niall" <niall.power@intel.com>, "Macnamara, Chris"
 <chris.macnamara@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id D2D201B253
 for <dev@dpdk.org>; Wed, 18 Oct 2017 04:25:08 +0200 (CEST)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC3463B@IRSMSX108.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Monday 16 October 2017 11:04
> To: Mokhtar, Amr <amr.mokhtar@intel.com>; dev@dpdk.org
> Cc: Power, Niall <niall.power@intel.com>; Macnamara, Chris
> <chris.macnamara@intel.com>; Mokhtar, Amr <amr.mokhtar@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library
>=20
>=20
>=20
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Amr Mokhtar
> > Sent: Saturday, September 30, 2017 2:38 AM
> > To: dev@dpdk.org
> > Cc: Power, Niall <niall.power@intel.com>; Macnamara, Chris
> > <chris.macnamara@intel.com>; Mokhtar, Amr <amr.mokhtar@intel.com>
> > Subject: [dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library
> >
>=20
> You are adding a new library here, so I think it deserves a description h=
ere (also
> for the other patches).

Wrong command caused the cover letter to go separately. You may find it @ h=
ttp://dpdk.org/ml/archives/dev/2017-September/077027.html
Recovered in v2 patch.

>=20
> This is also a good patch to mention the new library in release notes (in=
stead of
> leaving it to the documentation patch).

This was considered in v2 patch. Thanks.

>=20
>=20
> > Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>
>=20
> ...
>=20
> b/lib/librte_bbdev/Makefile
> > new file mode 100644
> > index 0000000..519d49f
> > --- /dev/null
> > +++ b/lib/librte_bbdev/Makefile
>=20
> ...
>=20
> > +
> > +# versioning export map
> > +EXPORT_MAP :=3D rte_bbdev_version.map
> > +
> > +# library dependencies
> > +DEPDIRS-y +=3D lib/librte_eal lib/librte_mempool lib/librte_kvargs
>=20
> Since this patch, DEPDIRS in libraries and drivers are deprecated:
> http://dpdk.org/dev/patchwork/patch/22298/

Done.

>=20
>=20
> > +
> > +include $(RTE_SDK)/mk/rte.lib.mk