All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Dalecki <dalecki@evision.ag>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Heinz J . Mauelshagen" <mauelshagen@sistina.com>,
	linux-kernel@vger.kernel.org, mge@sistina.com
Subject: Re: LVM 1.0.5 patch for Linux 2.4.19-rc3
Date: Fri, 26 Jul 2002 02:47:56 +0200	[thread overview]
Message-ID: <3D409C3C.8090009@evision.ag> (raw)
In-Reply-To: 20020725155433.A12776@infradead.org

Christoph Hellwig wrote:
>  
> +#ifndef	uchar
> +typedef	unsigned char	uchar;
> +#endif
> 
> Do you _really_ have to use this non-standard type?  can't you use the
> BSD u_char or sysv unchar?  and typedef/#define don't really mix nicely..

Or of course the normal u8 u16 and u32 and infally u64, which are so
much more explicit about the fact that we are actually dealig with
bit slices.

> 
> All in all this patch would be _soooo_ much easier to review if you wouldn't
> mix random indentation changes with real fixes.

Christoph applying the patch and rediffing with diffs "ingore white 
space' options can help you here.
And plese note that this kind of problems wouldn't be that common
if we finally decided to make indent -kr -i8 mandatory.



  reply	other threads:[~2002-07-26  4:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-25 13:39 LVM 1.0.5 patch for Linux 2.4.19-rc3 Heinz J . Mauelshagen
2002-07-25 14:34 ` Christoph Hellwig
2002-07-26  9:48   ` Heinz J . Mauelshagen
2002-07-25 14:54 ` Christoph Hellwig
2002-07-26  0:47   ` Marcin Dalecki [this message]
2002-07-26 10:17     ` Christoph Hellwig
2002-07-26 10:36     ` Alan Cox
2002-07-26 10:25 Heinz J . Mauelshagen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D409C3C.8090009@evision.ag \
    --to=dalecki@evision.ag \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin@dalecki.de \
    --cc=mauelshagen@sistina.com \
    --cc=mge@sistina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.