From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wang, Dong1" Subject: Re: [PATCH v2] example/ipv4_multicast: fix app hanging when using clone Date: Wed, 14 Nov 2018 02:28:03 +0000 Message-ID: <3E2E5017C928014B90FD7864A64F0B5514F74985@SHSMSX103.ccr.corp.intel.com> References: <20181112204650.7175-1-herakliusz.lipiec@intel.com> <20181113114929.9269-1-herakliusz.lipiec@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Ananyev, Konstantin" , "thomas@monjalon.net" , "Burakov, Anatoly" , "stable@dpdk.org" To: "Lipiec, Herakliusz" , "dev@dpdk.org" Return-path: In-Reply-To: <20181113114929.9269-1-herakliusz.lipiec@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Herakliusz, Since pkt->ol_flags might set some other bits except IND_ATTACHED_MBUF, how= about set its value to original pkt->ol_flags? Regards, Dong -----Original Message----- From: Lipiec, Herakliusz=20 Sent: Tuesday, November 13, 2018 19:49 To: dev@dpdk.org Cc: Ananyev, Konstantin ; Wang, Dong1 ; thomas@monjalon.net; Burakov, Anatoly ; Lipiec, Herakliusz ; stable@dpdk.org Subject: [PATCH v2] example/ipv4_multicast: fix app hanging when using clon= e The ipv4_multicast sample application was dropping packets when using mbuf = clone. When creating an L2 header and copying metadata from the source pack= et, the ol_flags were also copied along with all the other metadata. Becaus= e the cloned packet had IND_ATTACHED_MBUF flag set in its ol_flags, this ca= used the packets to never be freed when using rte_pktmbuf_free. Since copying ol_flags from the cloned packet is not necessary in the first= place, just don't do it. Fixes: af75078fece3 ("first public release") CC: stable@dpdk.org Reported-by: Wang Dong Signed-off-by: Herakliusz Lipiec --- doc/guides/sample_app_ug/ipv4_multicast.rst | 1 - examples/ipv4_multicast/main.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/doc/guides/sample_app_ug/ipv4_multicast.rst b/doc/guides/sampl= e_app_ug/ipv4_multicast.rst index ce1474ec7..f6efa7f6f 100644 --- a/doc/guides/sample_app_ug/ipv4_multicast.rst +++ b/doc/guides/sample_app_ug/ipv4_multicast.rst @@ -319,7 +319,6 @@ It is the mcast_out_pkt() function that performs the pa= cket duplication (either hdr->pkt.in_port =3D pkt->pkt.in_port; hdr->pkt.vlan_macip =3D pkt->pkt.vlan_macip; hdr->pkt.hash =3D pkt->pkt.hash; - hdr->ol_flags =3D pkt->ol_flags; rte_mbuf_sanity_check(hdr, RTE_MBUF_PKT, 1); =20 return hdr; diff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/main.= c index 4073a4907..428ca4694 100644 --- a/examples/ipv4_multicast/main.c +++ b/examples/ipv4_multicast/main.c @@ -266,8 +266,6 @@ mcast_out_pkt(struct rte_mbuf *pkt, int use_clone) hdr->tx_offload =3D pkt->tx_offload; hdr->hash =3D pkt->hash; =20 - hdr->ol_flags =3D pkt->ol_flags; - __rte_mbuf_sanity_check(hdr, 1); return hdr; } -- 2.17.1