* [PATCH v1] Revert "Bluetooth: btintel: Fix endianness issue for TLV version information"
@ 2020-12-15 23:40 Kiran K
2020-12-16 1:53 ` [v1] " bluez.test.bot
2020-12-18 21:43 ` [PATCH v1] " Marcel Holtmann
0 siblings, 2 replies; 3+ messages in thread
From: Kiran K @ 2020-12-15 23:40 UTC (permalink / raw)
To: linux-bluetooth; +Cc: ravishankar.srivatsa, chethan.tumkur.narayan, Kiran K
This reverts commit a63f23c9d139377833a139b179793fea79ee198f.
get_unaligned_{le16|le32|le64}(p) is meant to replace code of the form
le16_to_cpu(get_unaligned((__le16 *)p)). There is no need to explicitly
do leXX_to_cpu() if get_unaligned_leXX() is used.
https://lwn.net/Articles/277779/
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Kiran K <kiran.k@intel.com>
---
drivers/bluetooth/btintel.c | 21 +++++++--------------
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index 41ff2071d7ef..88ce5f0ffc4b 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -437,38 +437,31 @@ int btintel_read_version_tlv(struct hci_dev *hdev, struct intel_version_tlv *ver
tlv = (struct intel_tlv *)skb->data;
switch (tlv->type) {
case INTEL_TLV_CNVI_TOP:
- version->cnvi_top =
- __le32_to_cpu(get_unaligned_le32(tlv->val));
+ version->cnvi_top = get_unaligned_le32(tlv->val);
break;
case INTEL_TLV_CNVR_TOP:
- version->cnvr_top =
- __le32_to_cpu(get_unaligned_le32(tlv->val));
+ version->cnvr_top = get_unaligned_le32(tlv->val);
break;
case INTEL_TLV_CNVI_BT:
- version->cnvi_bt =
- __le32_to_cpu(get_unaligned_le32(tlv->val));
+ version->cnvi_bt = get_unaligned_le32(tlv->val);
break;
case INTEL_TLV_CNVR_BT:
- version->cnvr_bt =
- __le32_to_cpu(get_unaligned_le32(tlv->val));
+ version->cnvr_bt = get_unaligned_le32(tlv->val);
break;
case INTEL_TLV_DEV_REV_ID:
- version->dev_rev_id =
- __le16_to_cpu(get_unaligned_le16(tlv->val));
+ version->dev_rev_id = get_unaligned_le16(tlv->val);
break;
case INTEL_TLV_IMAGE_TYPE:
version->img_type = tlv->val[0];
break;
case INTEL_TLV_TIME_STAMP:
- version->timestamp =
- __le16_to_cpu(get_unaligned_le16(tlv->val));
+ version->timestamp = get_unaligned_le16(tlv->val);
break;
case INTEL_TLV_BUILD_TYPE:
version->build_type = tlv->val[0];
break;
case INTEL_TLV_BUILD_NUM:
- version->build_num =
- __le32_to_cpu(get_unaligned_le32(tlv->val));
+ version->build_num = get_unaligned_le32(tlv->val);
break;
case INTEL_TLV_SECURE_BOOT:
version->secure_boot = tlv->val[0];
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [v1] Revert "Bluetooth: btintel: Fix endianness issue for TLV version information" 2020-12-15 23:40 [PATCH v1] Revert "Bluetooth: btintel: Fix endianness issue for TLV version information" Kiran K @ 2020-12-16 1:53 ` bluez.test.bot 2020-12-18 21:43 ` [PATCH v1] " Marcel Holtmann 1 sibling, 0 replies; 3+ messages in thread From: bluez.test.bot @ 2020-12-16 1:53 UTC (permalink / raw) To: linux-bluetooth, kiran.k [-- Attachment #1: Type: text/plain, Size: 2044 bytes --] This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=402595 ---Test result--- ############################## Test: CheckPatch - PASS ############################## Test: CheckGitLint - FAIL workflow: Add workflow files for ci 1: T1 Title exceeds max length (92>72): "Merge d1fa109f41e64c2eca73d5d60c830cbd20b787bc into 2aef2746dba4e909f997dd6023c7ac7d66b122da" 3: B6 Body message is missing Revert "Bluetooth: btintel: Fix endianness issue for TLV version information" 1: T1 Title exceeds max length (92>72): "Merge d1fa109f41e64c2eca73d5d60c830cbd20b787bc into 2aef2746dba4e909f997dd6023c7ac7d66b122da" 3: B6 Body message is missing ############################## Test: CheckBuildK - PASS ############################## Test: CheckTestRunner: Setup - PASS ############################## Test: CheckTestRunner: l2cap-tester - PASS Total: 40, Passed: 34 (85.0%), Failed: 0, Not Run: 6 ############################## Test: CheckTestRunner: bnep-tester - PASS Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 ############################## Test: CheckTestRunner: mgmt-tester - FAIL Total: 416, Passed: 394 (94.7%), Failed: 8, Not Run: 14 ############################## Test: CheckTestRunner: rfcomm-tester - PASS Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0 ############################## Test: CheckTestRunner: sco-tester - PASS Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: CheckTestRunner: smp-tester - PASS Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: CheckTestRunner: userchan-tester - PASS Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0 --- Regards, Linux Bluetooth [-- Attachment #2: l2cap-tester.log --] [-- Type: application/octet-stream, Size: 43344 bytes --] [-- Attachment #3: bnep-tester.log --] [-- Type: application/octet-stream, Size: 3535 bytes --] [-- Attachment #4: mgmt-tester.log --] [-- Type: application/octet-stream, Size: 548209 bytes --] [-- Attachment #5: rfcomm-tester.log --] [-- Type: application/octet-stream, Size: 11654 bytes --] [-- Attachment #6: sco-tester.log --] [-- Type: application/octet-stream, Size: 9890 bytes --] [-- Attachment #7: smp-tester.log --] [-- Type: application/octet-stream, Size: 11800 bytes --] [-- Attachment #8: userchan-tester.log --] [-- Type: application/octet-stream, Size: 5432 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] Revert "Bluetooth: btintel: Fix endianness issue for TLV version information" 2020-12-15 23:40 [PATCH v1] Revert "Bluetooth: btintel: Fix endianness issue for TLV version information" Kiran K 2020-12-16 1:53 ` [v1] " bluez.test.bot @ 2020-12-18 21:43 ` Marcel Holtmann 1 sibling, 0 replies; 3+ messages in thread From: Marcel Holtmann @ 2020-12-18 21:43 UTC (permalink / raw) To: Kiran K; +Cc: linux-bluetooth, ravishankar.srivatsa, chethan.tumkur.narayan Hi Kiran, > This reverts commit a63f23c9d139377833a139b179793fea79ee198f. > > get_unaligned_{le16|le32|le64}(p) is meant to replace code of the form > le16_to_cpu(get_unaligned((__le16 *)p)). There is no need to explicitly > do leXX_to_cpu() if get_unaligned_leXX() is used. > > https://lwn.net/Articles/277779/ > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Kiran K <kiran.k@intel.com> > --- > drivers/bluetooth/btintel.c | 21 +++++++-------------- > 1 file changed, 7 insertions(+), 14 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-18 21:44 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-12-15 23:40 [PATCH v1] Revert "Bluetooth: btintel: Fix endianness issue for TLV version information" Kiran K 2020-12-16 1:53 ` [v1] " bluez.test.bot 2020-12-18 21:43 ` [PATCH v1] " Marcel Holtmann
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.