From: David Woodhouse <dwmw2@infradead.org>
To: Vitaly Kuznetsov <vkuznets@redhat.com>, kvm@vger.kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Ankur Arora <ankur.a.arora@oracle.com>,
Joao Martins <joao.m.martins@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Sean Christopherson <seanjc@google.com>,
graf@amazon.com, iaslan@amazon.de, pdurrant@amazon.com,
aagch@amazon.com, fandree@amazon.com
Subject: Re: [PATCH v3 01/17] KVM: Fix arguments to kvm_{un,}map_gfn()
Date: Mon, 14 Dec 2020 21:45:58 +0000 [thread overview]
Message-ID: <3E601C94-B52B-43AF-9D13-FD8CB24DED20@infradead.org> (raw)
In-Reply-To: <87a6ugvzek.fsf@vitty.brq.redhat.com>
On 14 December 2020 21:41:23 GMT, Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
>>Your change is correct but I'm not sure that it's entirely clear that
>kvm_map_gfn() implicitly uses 'as_id=0' and I don't even see a comment
>about the fact :-(
Isn't that true of all the kvm_read_guest and kvm_write_guest functions and indeed of kvm_memslots() itself?
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
next prev parent reply other threads:[~2020-12-14 21:47 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 8:38 [PATCH v3 00/17] KVM: Add minimal support for Xen HVM guests David Woodhouse
2020-12-14 8:38 ` [PATCH v3 01/17] KVM: Fix arguments to kvm_{un,}map_gfn() David Woodhouse
2020-12-14 21:13 ` Vitaly Kuznetsov
2020-12-14 21:21 ` David Woodhouse
2020-12-14 21:41 ` Vitaly Kuznetsov
2020-12-14 21:45 ` David Woodhouse [this message]
2020-12-15 12:07 ` Vitaly Kuznetsov
2020-12-15 12:45 ` David Woodhouse
2020-12-14 8:38 ` [PATCH v3 02/17] KVM: x86/xen: fix Xen hypercall page msr handling David Woodhouse
2020-12-14 21:27 ` Vitaly Kuznetsov
2020-12-14 21:35 ` David Woodhouse
2020-12-14 21:44 ` Vitaly Kuznetsov
2020-12-14 21:48 ` David Woodhouse
2020-12-14 22:22 ` Vitaly Kuznetsov
2020-12-14 22:41 ` David Woodhouse
2020-12-15 12:10 ` Vitaly Kuznetsov
2020-12-23 8:35 ` Christoph Hellwig
2020-12-14 8:38 ` [PATCH v3 03/17] KVM: x86/xen: intercept xen hypercalls if enabled David Woodhouse
2020-12-23 8:36 ` Christoph Hellwig
2020-12-23 10:51 ` David Woodhouse
2020-12-14 8:38 ` [PATCH v3 04/17] KVM: x86/xen: Fix coexistence of Xen and Hyper-V hypercalls David Woodhouse
2020-12-14 8:38 ` [PATCH v3 05/17] KVM: x86/xen: add KVM_XEN_HVM_SET_ATTR/KVM_XEN_HVM_GET_ATTR David Woodhouse
2020-12-14 8:38 ` [PATCH v3 06/17] KVM: x86/xen: latch long_mode when hypercall page is set up David Woodhouse
2020-12-14 8:38 ` [PATCH v3 07/17] KVM: x86/xen: add definitions of compat_shared_info, compat_vcpu_info David Woodhouse
2020-12-14 8:38 ` [PATCH v3 08/17] KVM: x86/xen: register shared_info page David Woodhouse
2020-12-14 10:45 ` Joao Martins
2020-12-14 11:30 ` Joao Martins
2020-12-14 12:04 ` David Woodhouse
2020-12-14 12:02 ` David Woodhouse
2020-12-14 12:53 ` Joao Martins
2020-12-14 15:05 ` David Woodhouse
2020-12-14 8:38 ` [PATCH v3 09/17] xen: add wc_sec_hi to struct shared_info David Woodhouse
2020-12-14 8:38 ` [PATCH v3 10/17] KVM: x86/xen: update wallclock region David Woodhouse
2020-12-14 8:38 ` [PATCH v3 11/17] KVM: x86/xen: register vcpu info David Woodhouse
2020-12-14 10:48 ` Joao Martins
2020-12-14 8:39 ` [PATCH v3 12/17] KVM: x86/xen: setup pvclock updates David Woodhouse
2020-12-14 13:29 ` Joao Martins
2020-12-14 14:58 ` David Woodhouse
2020-12-14 15:20 ` Joao Martins
2020-12-14 15:40 ` David Woodhouse
2020-12-14 8:39 ` [PATCH v3 13/17] KVM: x86/xen: register vcpu time info region David Woodhouse
2020-12-14 10:55 ` Joao Martins
2020-12-14 12:03 ` David Woodhouse
2020-12-14 8:39 ` [PATCH v3 14/17] KVM: x86/xen: register runstate info David Woodhouse
2020-12-14 11:10 ` Joao Martins
2020-12-14 15:47 ` David Woodhouse
2020-12-14 8:39 ` [PATCH v3 15/17] KVM: x86: declare Xen HVM shared info capability and add test case David Woodhouse
2020-12-14 8:39 ` [PATCH v3 16/17] KVM: Add documentation for Xen hypercall and shared_info updates David Woodhouse
2020-12-14 8:39 ` [PATCH v3 17/17] KVM: x86/xen: Add event channel interrupt vector upcall David Woodhouse
2020-12-14 13:19 ` Joao Martins
2020-12-14 13:32 ` Durrant, Paul
2020-12-14 14:57 ` David Woodhouse
2020-12-14 15:13 ` Joao Martins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E601C94-B52B-43AF-9D13-FD8CB24DED20@infradead.org \
--to=dwmw2@infradead.org \
--cc=aagch@amazon.com \
--cc=ankur.a.arora@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=fandree@amazon.com \
--cc=graf@amazon.com \
--cc=iaslan@amazon.de \
--cc=joao.m.martins@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pdurrant@amazon.com \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.