From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751544AbdFWLAK (ORCPT ); Fri, 23 Jun 2017 07:00:10 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.220]:36811 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750795AbdFWLAH (ORCPT ); Fri, 23 Jun 2017 07:00:07 -0400 X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcecEarQROEYabkiUo6mCQKkACaUSHhxnT+FrA= X-RZG-CLASS-ID: mo00 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH v1 1/6] DT bindings: add bindings for ov965x camera module From: "H. Nikolaus Schaller" In-Reply-To: Date: Fri, 23 Jun 2017 12:59:24 +0200 Cc: Hugues Fruchet , Mark Rutland , devicetree , Benjamin Gaignard , Discussions about the Letux Kernel , Alexandre Torgue , LKML , Hans Verkuil , Rob Herring , Maxime Coquelin , Yannick Fertre , Sylwester Nawrocki , Mauro Carvalho Chehab , Guennadi Liakhovetski , linux-arm-kernel , linux-media@vger.kernel.org Message-Id: <3E7B1344-ECE6-4CCC-9E9D-7521BB566CDE@goldelico.com> References: <1498143942-12682-1-git-send-email-hugues.fruchet@st.com> <1498143942-12682-2-git-send-email-hugues.fruchet@st.com> To: =?utf-8?Q?Andreas_F=C3=A4rber?= , Suman Anna , Laurent Pinchart X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5NB1fnk011276 > Am 23.06.2017 um 12:46 schrieb Andreas Färber : > > Hi, > > Am 23.06.2017 um 12:25 schrieb H. Nikolaus Schaller: >>> diff --git a/Documentation/devicetree/bindings/media/i2c/ov965x.txt b/Documentation/devicetree/bindings/media/i2c/ov965x.txt >>> new file mode 100644 >>> index 0000000..0e0de1f >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/media/i2c/ov965x.txt >>> @@ -0,0 +1,37 @@ >>> +* Omnivision OV9650/9652/9655 CMOS sensor >>> + >>> +The Omnivision OV965x sensor support multiple resolutions output, such as >>> +CIF, SVGA, UXGA. It also can support YUV422/420, RGB565/555 or raw RGB >>> +output format. >>> + >>> +Required Properties: >>> +- compatible: should be one of >>> + "ovti,ov9650" >>> + "ovti,ov9652" >>> + "ovti,ov9655" >>> +- clocks: reference to the mclk input clock. >> >> I wonder why you have removed the clock-frequency property? >> >> In some situations the camera driver must be able to tell the clock source >> which frequency it wants to see. > > That's what assigned-clock-rates property is for: > > https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt > > AFAIU clock-frequency on devices is deprecated and equivalent to having > a clocks property pointing to a fixed-clock, which is different from a > clock with varying rate. I am not sure if that helps here. The OMAP3-ISP does not have a fixed clock rate so we can only have the driver define what it wants to see. And common practise for OMAP3-ISP based camera modules (e.g. N900, N9) is that they do it in the driver. Maybe ISP developers can comment? BR, Nikolaus From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Nikolaus Schaller" Subject: Re: [PATCH v1 1/6] DT bindings: add bindings for ov965x camera module Date: Fri, 23 Jun 2017 12:59:24 +0200 Message-ID: <3E7B1344-ECE6-4CCC-9E9D-7521BB566CDE@goldelico.com> References: <1498143942-12682-1-git-send-email-hugues.fruchet@st.com> <1498143942-12682-2-git-send-email-hugues.fruchet@st.com> Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: =?utf-8?Q?Andreas_F=C3=A4rber?= , Suman Anna , Laurent Pinchart Cc: Mark Rutland , devicetree , Mauro Carvalho Chehab , Alexandre Torgue , LKML , Guennadi Liakhovetski , Hans Verkuil , Rob Herring , linux-arm-kernel , Benjamin Gaignard , Hugues Fruchet , Sylwester Nawrocki , Discussions about the Letux Kernel , Yannick Fertre , Maxime Coquelin , linux-media@vger.kernel.org List-Id: devicetree@vger.kernel.org Cj4gQW0gMjMuMDYuMjAxNyB1bSAxMjo0NiBzY2hyaWViIEFuZHJlYXMgRsOkcmJlciA8YWZhZXJi ZXJAc3VzZS5kZT46Cj4gCj4gSGksCj4gCj4gQW0gMjMuMDYuMjAxNyB1bSAxMjoyNSBzY2hyaWVi IEguIE5pa29sYXVzIFNjaGFsbGVyOgo+Pj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9tZWRpYS9pMmMvb3Y5NjV4LnR4dCBiL0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9tZWRpYS9pMmMvb3Y5NjV4LnR4dAo+Pj4gbmV3IGZpbGUgbW9kZSAx MDA2NDQKPj4+IGluZGV4IDAwMDAwMDAuLjBlMGRlMWYKPj4+IC0tLSAvZGV2L251bGwKPj4+ICsr KyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZWRpYS9pMmMvb3Y5NjV4LnR4 dAo+Pj4gQEAgLTAsMCArMSwzNyBAQAo+Pj4gKyogT21uaXZpc2lvbiBPVjk2NTAvOTY1Mi85NjU1 IENNT1Mgc2Vuc29yCj4+PiArCj4+PiArVGhlIE9tbml2aXNpb24gT1Y5NjV4IHNlbnNvciBzdXBw b3J0IG11bHRpcGxlIHJlc29sdXRpb25zIG91dHB1dCwgc3VjaCBhcwo+Pj4gK0NJRiwgU1ZHQSwg VVhHQS4gSXQgYWxzbyBjYW4gc3VwcG9ydCBZVVY0MjIvNDIwLCBSR0I1NjUvNTU1IG9yIHJhdyBS R0IKPj4+ICtvdXRwdXQgZm9ybWF0Lgo+Pj4gKwo+Pj4gK1JlcXVpcmVkIFByb3BlcnRpZXM6Cj4+ PiArLSBjb21wYXRpYmxlOiBzaG91bGQgYmUgb25lIG9mCj4+PiArCSJvdnRpLG92OTY1MCIKPj4+ ICsJIm92dGksb3Y5NjUyIgo+Pj4gKwkib3Z0aSxvdjk2NTUiCj4+PiArLSBjbG9ja3M6IHJlZmVy ZW5jZSB0byB0aGUgbWNsayBpbnB1dCBjbG9jay4KPj4gCj4+IEkgd29uZGVyIHdoeSB5b3UgaGF2 ZSByZW1vdmVkIHRoZSBjbG9jay1mcmVxdWVuY3kgcHJvcGVydHk/Cj4+IAo+PiBJbiBzb21lIHNp dHVhdGlvbnMgdGhlIGNhbWVyYSBkcml2ZXIgbXVzdCBiZSBhYmxlIHRvIHRlbGwgdGhlIGNsb2Nr IHNvdXJjZQo+PiB3aGljaCBmcmVxdWVuY3kgaXQgd2FudHMgdG8gc2VlLgo+IAo+IFRoYXQncyB3 aGF0IGFzc2lnbmVkLWNsb2NrLXJhdGVzIHByb3BlcnR5IGlzIGZvcjoKPiAKPiBodHRwczovL3d3 dy5rZXJuZWwub3JnL2RvYy9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY2xvY2sv Y2xvY2stYmluZGluZ3MudHh0Cj4gCj4gQUZBSVUgY2xvY2stZnJlcXVlbmN5IG9uIGRldmljZXMg aXMgZGVwcmVjYXRlZCBhbmQgZXF1aXZhbGVudCB0byBoYXZpbmcKPiBhIGNsb2NrcyBwcm9wZXJ0 eSBwb2ludGluZyB0byBhIGZpeGVkLWNsb2NrLCB3aGljaCBpcyBkaWZmZXJlbnQgZnJvbSBhCj4g Y2xvY2sgd2l0aCB2YXJ5aW5nIHJhdGUuCgpJIGFtIG5vdCBzdXJlIGlmIHRoYXQgaGVscHMgaGVy ZS4gVGhlIE9NQVAzLUlTUCBkb2VzIG5vdCBoYXZlIGEgZml4ZWQgY2xvY2sgcmF0ZQpzbyB3ZSBj YW4gb25seSBoYXZlIHRoZSBkcml2ZXIgZGVmaW5lIHdoYXQgaXQgd2FudHMgdG8gc2VlLgoKQW5k IGNvbW1vbiBwcmFjdGlzZSBmb3IgT01BUDMtSVNQIGJhc2VkIGNhbWVyYSBtb2R1bGVzIChlLmcu IE45MDAsIE45KSBpcyB0aGF0IHRoZXkgZG8gaXQgaW4gdGhlIGRyaXZlci4KCk1heWJlIElTUCBk ZXZlbG9wZXJzIGNhbiBjb21tZW50PwoKQlIsCk5pa29sYXVzCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.220]:36811 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750795AbdFWLAH (ORCPT ); Fri, 23 Jun 2017 07:00:07 -0400 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH v1 1/6] DT bindings: add bindings for ov965x camera module From: "H. Nikolaus Schaller" In-Reply-To: Date: Fri, 23 Jun 2017 12:59:24 +0200 Cc: Hugues Fruchet , Mark Rutland , devicetree , Benjamin Gaignard , Discussions about the Letux Kernel , Alexandre Torgue , LKML , Hans Verkuil , Rob Herring , Maxime Coquelin , Yannick Fertre , Sylwester Nawrocki , Mauro Carvalho Chehab , Guennadi Liakhovetski , linux-arm-kernel , linux-media@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <3E7B1344-ECE6-4CCC-9E9D-7521BB566CDE@goldelico.com> References: <1498143942-12682-1-git-send-email-hugues.fruchet@st.com> <1498143942-12682-2-git-send-email-hugues.fruchet@st.com> To: =?utf-8?Q?Andreas_F=C3=A4rber?= , Suman Anna , Laurent Pinchart Sender: linux-media-owner@vger.kernel.org List-ID: > Am 23.06.2017 um 12:46 schrieb Andreas F=C3=A4rber : >=20 > Hi, >=20 > Am 23.06.2017 um 12:25 schrieb H. Nikolaus Schaller: >>> diff --git a/Documentation/devicetree/bindings/media/i2c/ov965x.txt = b/Documentation/devicetree/bindings/media/i2c/ov965x.txt >>> new file mode 100644 >>> index 0000000..0e0de1f >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/media/i2c/ov965x.txt >>> @@ -0,0 +1,37 @@ >>> +* Omnivision OV9650/9652/9655 CMOS sensor >>> + >>> +The Omnivision OV965x sensor support multiple resolutions output, = such as >>> +CIF, SVGA, UXGA. It also can support YUV422/420, RGB565/555 or raw = RGB >>> +output format. >>> + >>> +Required Properties: >>> +- compatible: should be one of >>> + "ovti,ov9650" >>> + "ovti,ov9652" >>> + "ovti,ov9655" >>> +- clocks: reference to the mclk input clock. >>=20 >> I wonder why you have removed the clock-frequency property? >>=20 >> In some situations the camera driver must be able to tell the clock = source >> which frequency it wants to see. >=20 > That's what assigned-clock-rates property is for: >=20 > = https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-b= indings.txt >=20 > AFAIU clock-frequency on devices is deprecated and equivalent to = having > a clocks property pointing to a fixed-clock, which is different from a > clock with varying rate. I am not sure if that helps here. The OMAP3-ISP does not have a fixed = clock rate so we can only have the driver define what it wants to see. And common practise for OMAP3-ISP based camera modules (e.g. N900, N9) = is that they do it in the driver. Maybe ISP developers can comment? BR, Nikolaus= From mboxrd@z Thu Jan 1 00:00:00 1970 From: hns@goldelico.com (H. Nikolaus Schaller) Date: Fri, 23 Jun 2017 12:59:24 +0200 Subject: [PATCH v1 1/6] DT bindings: add bindings for ov965x camera module In-Reply-To: References: <1498143942-12682-1-git-send-email-hugues.fruchet@st.com> <1498143942-12682-2-git-send-email-hugues.fruchet@st.com> Message-ID: <3E7B1344-ECE6-4CCC-9E9D-7521BB566CDE@goldelico.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > Am 23.06.2017 um 12:46 schrieb Andreas F?rber : > > Hi, > > Am 23.06.2017 um 12:25 schrieb H. Nikolaus Schaller: >>> diff --git a/Documentation/devicetree/bindings/media/i2c/ov965x.txt b/Documentation/devicetree/bindings/media/i2c/ov965x.txt >>> new file mode 100644 >>> index 0000000..0e0de1f >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/media/i2c/ov965x.txt >>> @@ -0,0 +1,37 @@ >>> +* Omnivision OV9650/9652/9655 CMOS sensor >>> + >>> +The Omnivision OV965x sensor support multiple resolutions output, such as >>> +CIF, SVGA, UXGA. It also can support YUV422/420, RGB565/555 or raw RGB >>> +output format. >>> + >>> +Required Properties: >>> +- compatible: should be one of >>> + "ovti,ov9650" >>> + "ovti,ov9652" >>> + "ovti,ov9655" >>> +- clocks: reference to the mclk input clock. >> >> I wonder why you have removed the clock-frequency property? >> >> In some situations the camera driver must be able to tell the clock source >> which frequency it wants to see. > > That's what assigned-clock-rates property is for: > > https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt > > AFAIU clock-frequency on devices is deprecated and equivalent to having > a clocks property pointing to a fixed-clock, which is different from a > clock with varying rate. I am not sure if that helps here. The OMAP3-ISP does not have a fixed clock rate so we can only have the driver define what it wants to see. And common practise for OMAP3-ISP based camera modules (e.g. N900, N9) is that they do it in the driver. Maybe ISP developers can comment? BR, Nikolaus