From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [PATCH v6 05/11] ip_pipeline: added master pipeline
Date: Thu, 9 Jul 2015 10:00:39 +0000
Message-ID: <3EB4FA525960D640B5BDFFD6A3D89126323985D8@IRSMSX108.ger.corp.intel.com>
References: <1436256575-15107-1-git-send-email-maciejx.t.gajdzica@intel.com>
 <1436256575-15107-6-git-send-email-maciejx.t.gajdzica@intel.com>
 <2556845.B31QGe61c9@xps13>
 <9CC680510C0AC140A846FED2EF7F96281384BDE9@IRSMSX102.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Gajdzica, MaciejX T" <maciejx.t.gajdzica@intel.com>, Thomas Monjalon
 <thomas.monjalon@6wind.com>, "Singh, Jasvinder" <jasvinder.singh@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 427585A6B
 for <dev@dpdk.org>; Thu,  9 Jul 2015 12:00:43 +0200 (CEST)
In-Reply-To: <9CC680510C0AC140A846FED2EF7F96281384BDE9@IRSMSX102.ger.corp.intel.com>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Gajdzica, MaciejX T
> Sent: Thursday, July 9, 2015 12:58 PM
> To: Thomas Monjalon; Singh, Jasvinder
> Cc: dev@dpdk.org; Dumitrescu, Cristian
> Subject: RE: [dpdk-dev] [PATCH v6 05/11] ip_pipeline: added master pipeli=
ne
>=20
>=20
>=20
> > -----Original Message-----
> > From: Gajdzica, MaciejX T
> > Sent: Thursday, July 09, 2015 10:03 AM
> > To: 'Thomas Monjalon'; Singh, Jasvinder
> > Cc: dev@dpdk.org; Dumitrescu, Cristian
> > Subject: RE: [dpdk-dev] [PATCH v6 05/11] ip_pipeline: added master
> pipeline
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > Sent: Thursday, July 09, 2015 12:33 AM
> > > To: Gajdzica, MaciejX T; Singh, Jasvinder
> > > Cc: dev@dpdk.org; Dumitrescu, Cristian
> > > Subject: Re: [dpdk-dev] [PATCH v6 05/11] ip_pipeline: added master
> > > pipeline
> > >
> > > 2015-07-07 10:09, Maciej Gajdzica:
> > > > From: Jasvinder Singh <jasvinder.singh@intel.com>
> > > >
> > > > Master pipeline is responsible for command line handling and
> > > > communicationg with all other pipelines via message queues. Removed
> > > > cmdline.c file, as its functionality will be split over multiple
> > > > pipeline files.
> > > >
> > > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > >
> > > In this v6, it builds well until patch 05 which uses some not exporte=
d
> symbols:
> > > pipeline_common_be.c:(.text+0x51): undefined reference to
> > > `rte_pipeline_port_in_stats_read'
> > > pipeline_common_be.c:(.text+0x91): undefined reference to
> > > `rte_pipeline_port_out_stats_read'
> > > pipeline_common_be.c:(.text+0xd4): undefined reference to
> > > `rte_pipeline_table_stats_read'
> > >
> > > Please check build with shared libraries.
> >
> > There are missing symbols in map file for librte_port and librte_pipeli=
ne. I
> will
> > send separate patch for that.
>=20
> This compilation problem with shared libraries is not because something w=
ith
> this
> patchset is wrong, but because exported symbols in map file in earlier
> patchsets are
> missing. So after separate patches with fix will be applied, could you re=
store
> this patchset?
>=20
> Best Regards
> Maciek

Hi Maciek, I suggest we add the missing symbols to the librte_port, lib_rte=
_table and librte_pipeline as a new patch; this should fix the v6 patch ser=
ies on ip_pipeline without any need for v7? Thanks, Cristian