From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [PATCH 1/5] cfgfile: configurable comment character
Date: Fri, 3 Mar 2017 12:17:14 +0000
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891265275825D@IRSMSX108.ger.corp.intel.com>
References: <1488482971-170522-1-git-send-email-allain.legacy@windriver.com>
 <1488482971-170522-2-git-send-email-allain.legacy@windriver.com>
 <20170302211015.GA18940@bricha3-MOBL3.ger.corp.intel.com>
 <20170303005337.GB18844@yliu-dev.sh.intel.com>
 <3EB4FA525960D640B5BDFFD6A3D8912652758102@IRSMSX108.ger.corp.intel.com>
 <70A7408C6E1BFB41B192A929744D85238A75B22B@ALA-MBC.corp.ad.wrs.com>
 <3EB4FA525960D640B5BDFFD6A3D8912652758220@IRSMSX108.ger.corp.intel.com>
 <70A7408C6E1BFB41B192A929744D85238A75B2D3@ALA-MBC.corp.ad.wrs.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Jolliffe, Ian (Wind River)"
 <ian.jolliffe@windriver.com>
To: "Legacy, Allain (Wind River)" <allain.legacy@windriver.com>, Yuanhan Liu
 <yuanhan.liu@linux.intel.com>, "Richardson, Bruce"
 <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 5AA86952
 for <dev@dpdk.org>; Fri,  3 Mar 2017 13:17:19 +0100 (CET)
In-Reply-To: <70A7408C6E1BFB41B192A929744D85238A75B2D3@ALA-MBC.corp.ad.wrs.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Legacy, Allain [mailto:Allain.Legacy@windriver.com]
> Sent: Friday, March 3, 2017 12:14 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Yuanhan Liu
> <yuanhan.liu@linux.intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; Jolliffe, Ian (Wind River) <ian.jolliffe@windriver.com>
> Subject: RE: [dpdk-dev] [PATCH 1/5] cfgfile: configurable comment charact=
er
>=20
>=20
> > -----Original Message-----
> > From: Dumitrescu, Cristian [mailto:cristian.dumitrescu@intel.com]
>  > Both approaches can support this. Therefore, IMO the separator char is
> not
> > enough to justify approach 1. I would only go for approach 1 if there a=
re
> > some other parameters that we could consider adding to the load functio=
n
> > now or later. Do you see any?
>=20
> No, I don't have any future parameters in mind but that doesn't mean that
> none will arise eventually.   IMO, the comment character should be specif=
ied
> as an actual "char" in the rte_cfgfile_params.  Specifying it as a flag i=
s a bit
> kludgy - I don't like overloading a flag/enum to specify something that
> already has a type that can be used (char).   Also, I don't think we need=
 to
> control which comment characters are valid.  If the app wants to use a 'X=
'
> then that's their choice.
>=20
>=20

I disagree here. I think we must control the set of allowed separators to a=
void confusion.