From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [PATCH 1/5] cfgfile: configurable comment character
Date: Fri, 3 Mar 2017 12:52:40 +0000
Message-ID: <3EB4FA525960D640B5BDFFD6A3D8912652758330@IRSMSX108.ger.corp.intel.com>
References: <1488482971-170522-1-git-send-email-allain.legacy@windriver.com>
 <1488482971-170522-2-git-send-email-allain.legacy@windriver.com>
 <20170302211015.GA18940@bricha3-MOBL3.ger.corp.intel.com>
 <20170303005337.GB18844@yliu-dev.sh.intel.com>
 <3EB4FA525960D640B5BDFFD6A3D8912652758102@IRSMSX108.ger.corp.intel.com>
 <70A7408C6E1BFB41B192A929744D85238A75B22B@ALA-MBC.corp.ad.wrs.com>
 <3EB4FA525960D640B5BDFFD6A3D8912652758220@IRSMSX108.ger.corp.intel.com>
 <70A7408C6E1BFB41B192A929744D85238A75B2D3@ALA-MBC.corp.ad.wrs.com>
 <3EB4FA525960D640B5BDFFD6A3D891265275825D@IRSMSX108.ger.corp.intel.com>
 <70A7408C6E1BFB41B192A929744D85238A75B30F@ALA-MBC.corp.ad.wrs.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Jolliffe, Ian (Wind River)"
 <ian.jolliffe@windriver.com>
To: "Legacy, Allain (Wind River)" <allain.legacy@windriver.com>, Yuanhan Liu
 <yuanhan.liu@linux.intel.com>, "Richardson, Bruce"
 <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 9A22B37AA
 for <dev@dpdk.org>; Fri,  3 Mar 2017 13:52:57 +0100 (CET)
In-Reply-To: <70A7408C6E1BFB41B192A929744D85238A75B30F@ALA-MBC.corp.ad.wrs.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Legacy, Allain [mailto:Allain.Legacy@windriver.com]
> Sent: Friday, March 3, 2017 12:19 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Yuanhan Liu
> <yuanhan.liu@linux.intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; Jolliffe, Ian (Wind River) <ian.jolliffe@windriver.com>
> Subject: RE: [dpdk-dev] [PATCH 1/5] cfgfile: configurable comment charact=
er
>=20
> > -----Original Message-----
> > From: Dumitrescu, Cristian [mailto:cristian.dumitrescu@intel.com]
> > I disagree here. I think we must control the set of allowed separators =
to
> > avoid confusion.
> I don't understand.  What will be confusing?  The app owns the file forma=
t
> and is responsible to ensure that it is parseable.
>=20

I does not make sense to allow letters, numbers, formatting characters (tab=
s, lf, cr, etc), unprintable characters, etc as comment separators. In fact=
, if you look on the ASCII set, there are about 5 chars out of 256 that can=
 be used as comment separators (the ones I listed earlier). The others are =
not suitable as comment separators, so none of the commonly used parsers al=
low them. The API should not allow options that do not make sense.