From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [PATCH v2 6/6] cfgfile: add support for empty value
	string
Date: Mon, 27 Mar 2017 10:54:37 +0000
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891265277BE82@IRSMSX108.ger.corp.intel.com>
References: <1488482971-170522-1-git-send-email-allain.legacy@windriver.com>
 <1489065060-98370-1-git-send-email-allain.legacy@windriver.com>
 <1489065060-98370-7-git-send-email-allain.legacy@windriver.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
To: "Legacy, Allain (Wind River)" <allain.legacy@windriver.com>, "Richardson,
 Bruce" <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 00A87FAB8
 for <dev@dpdk.org>; Mon, 27 Mar 2017 12:54:41 +0200 (CEST)
In-Reply-To: <1489065060-98370-7-git-send-email-allain.legacy@windriver.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Allain Legacy [mailto:allain.legacy@windriver.com]
> Sent: Thursday, March 9, 2017 1:11 PM
> To: Richardson, Bruce <bruce.richardson@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Cc: yuanhan.liu@linux.intel.com; dev@dpdk.org
> Subject: [PATCH v2 6/6] cfgfile: add support for empty value string
>=20
> This commit adds support to the cfgfile library for parsing a key=3Dvalue
> line that has no value string specified (e.g., "key=3D").  This can be us=
ed
> to override a configuration attribute that has a default value or default
> list of values to set it back to an undefined value to disable
> functionality.
>=20

IMO allowing empty string key values is confusing and should not be allowed=
.

I think there are better alternatives for setting a key to its default valu=
e:
	key =3D default
	key =3D DEFAULT
	key =3D <the specific default value>

Any reason not to use these approaches?