From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [PATCH v2 6/6] cfgfile: add support for empty value
	string
Date: Mon, 27 Mar 2017 11:24:38 +0000
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891265277CF3A@IRSMSX108.ger.corp.intel.com>
References: <1488482971-170522-1-git-send-email-allain.legacy@windriver.com>
 <1489065060-98370-1-git-send-email-allain.legacy@windriver.com>
 <1489065060-98370-7-git-send-email-allain.legacy@windriver.com>
 <3EB4FA525960D640B5BDFFD6A3D891265277BE82@IRSMSX108.ger.corp.intel.com>
 <70A7408C6E1BFB41B192A929744D8523968F7D70@ALA-MBC.corp.ad.wrs.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
To: "Legacy, Allain (Wind River)" <allain.legacy@windriver.com>, "Richardson,
 Bruce" <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 42E0EFAC0
 for <dev@dpdk.org>; Mon, 27 Mar 2017 13:24:42 +0200 (CEST)
In-Reply-To: <70A7408C6E1BFB41B192A929744D8523968F7D70@ALA-MBC.corp.ad.wrs.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Legacy, Allain [mailto:Allain.Legacy@windriver.com]
> Sent: Monday, March 27, 2017 12:13 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Richardson, Bru=
ce
> <bruce.richardson@intel.com>
> Cc: yuanhan.liu@linux.intel.com; dev@dpdk.org
> Subject: RE: [PATCH v2 6/6] cfgfile: add support for empty value string
>=20
> We have a legacy file format that we need to support.   Other parts of ou=
r
> system are able to handle a "key=3D" entry in the file so we are trying t=
o gain
> parity with those parsers.
>=20
> Allain
>=20
>=20
> Allain Legacy, Software Developer
> direct 613.270.2279  fax 613.492.7870 skype allain.legacy
>=20
>=20
>=20

OK, for legacy reasons I am OK to allow this feature, but please let's have=
 the user explicitly ask for it by providing a specific flag for it in the =
flags argument of the load/load_with_params functions.

>=20
> > -----Original Message-----
> > From: Dumitrescu, Cristian [mailto:cristian.dumitrescu@intel.com]
> > Sent: Monday, March 27, 2017 6:55 AM
> > To: Legacy, Allain; RICHARDSON, BRUCE
> > Cc: yuanhan.liu@linux.intel.com; dev@dpdk.org
> > Subject: RE: [PATCH v2 6/6] cfgfile: add support for empty value string
> >
> >
> >
> > > -----Original Message-----
> > > From: Allain Legacy [mailto:allain.legacy@windriver.com]
> > > Sent: Thursday, March 9, 2017 1:11 PM
> > > To: Richardson, Bruce <bruce.richardson@intel.com>; Dumitrescu,
> > > Cristian <cristian.dumitrescu@intel.com>
> > > Cc: yuanhan.liu@linux.intel.com; dev@dpdk.org
> > > Subject: [PATCH v2 6/6] cfgfile: add support for empty value string
> > >
> > > This commit adds support to the cfgfile library for parsing a
> > > key=3Dvalue line that has no value string specified (e.g., "key=3D").
> > > This can be used to override a configuration attribute that has a
> > > default value or default list of values to set it back to an undefine=
d
> > > value to disable functionality.
> > >
> >
> > IMO allowing empty string key values is confusing and should not be
> allowed.
> >
> > I think there are better alternatives for setting a key to its default =
value:
> > 	key =3D default
> > 	key =3D DEFAULT
> > 	key =3D <the specific default value>
> >
> > Any reason not to use these approaches?
>=20