From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dumitrescu, Cristian" Subject: Re: [PATCH v2 2/3] eal: add new rte color definition Date: Wed, 19 Dec 2018 10:47:08 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E816DB9@IRSMSX108.ger.corp.intel.com> References: <20181123165423.134922-1-jasvinder.singh@intel.com> <2601191342CEEE43887BDE71AB977258010D8BC0BC@IRSMSX106.ger.corp.intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E8169C8@IRSMSX108.ger.corp.intel.com> <2721277.OGTcNX5HrL@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Ananyev, Konstantin" , "Pattan, Reshma" , "dev@dpdk.org" , "jerin.jacob@caviumnetworks.com" , "Singh, Jasvinder" , "david.marchand@redhat.com" , "olivier.matz@6wind.com" , "techboard@dpdk.org" To: Thomas Monjalon Return-path: In-Reply-To: <2721277.OGTcNX5HrL@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, December 18, 2018 8:20 PM > To: Dumitrescu, Cristian > Cc: Ananyev, Konstantin ; Pattan, Reshma > ; dev@dpdk.org; > jerin.jacob@caviumnetworks.com; Singh, Jasvinder > ; david.marchand@redhat.com; > olivier.matz@6wind.com; techboard@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition >=20 > 18/12/2018 20:34, Dumitrescu, Cristian: > > From: Ananyev, Konstantin > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > 18/12/2018 14:19, Dumitrescu, Cristian: > > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > > > 18/12/2018 12:18, Dumitrescu, Cristian: > > > > > > > > > I replied in v3 that it should stay in rte_meter.h. > > > > > > > > > You can include rte_meter.h in ethdev. > > > > > > > > > > > > > > > > OK, thanks Thomas, makes sense to me as well. > > > > > > > > > > > > > > > > > > > > > > Thomas, > > > > > > > > > > > > > > I agree with your input, but just want to make sure we are on= the > > > same > > > > > > page: > > > > > > > > > > > > > > Besides including rte_meter.h in ethdev (which you are fine w= ith), > we > > > > > > would also need to include rte_meter.h in mbuf. > > > > > > > > > > > > > > Are you OK with this as well? > > > > > > > > > > > > Why do we need rte_meter.h in mbuf? > > > > > > > > > > > > > > > > You probably looked at V2 only, but in V3 we have functions to > set/get > > > the color within the mbuf->hash.sched field. > > > > > > > > > > For space compression reasons, the mbuf->hash.sched stores the > color > > > on 8-bit variable, while for the outside world the set/get functions > > > > work with the 32-bit enum type. We do same thing in other places in > DPDK, > > > such as rte_crypto_op, etc. > > > > > > > > So it's a different discussion. > > > > We need to review this v3 and check how relevant this mbuf API is. > > > > > > > > If the API is accepted, yes the include should not be an issue. > > > > > > Personally, I don't think it is a good idea to add extra dependency f= or > > > librte_mbuf. > > > I'd prefer either to keep rte_color definition inside librte_mbuf, > > > or move corresponding function definitions out of it. > > > Konstantin > > > > Konstantin, > > > > As you see, the number of options is limited, and none of them is > perfect: > > > > 1/ color enum in EAL/common/include: still my favorite, as it does not > create any new library dependencies, and it is already used to store lots= of > similar generic items > > 2/ color enum in rte_meter.h: results in creating new librte_mbuf > dependency to librte_meter > > 3/ color enum in rte_mbuf.h: results in creating new librte_meter > dependency to librte_mbuf (yes, currently librte_meter does not depend on > librte_mbuf) > > > > Personally, I can live with any of these options. > > > > Thomas, > > > > It would be good to have your input as well, Reshma just sent V4 > implementing your proposal based on having the color enum defined in > rte_meter.h, which gets included into rte_mbuf.h. >=20 > We need a decision from Olivier, mbuf maintainer. >=20 > > We need to make progress for RC1 deadline. >=20 > I'm afraid 19.02 is not the right release to change the mbuf. > This kind of decision usually takes several weeks. > Cc the technical board to get more opinions. >=20 Hi Thomas, The only change we are planning to do on the mbuf is reformatting of the sc= hed field, according to the deprecation note that was already acked by Oliv= ier and many others: http://git.dpdk.org/dpdk/tree/doc/guides/rel_notes/deprecation.rst#n52 We are planning to send V5 that should simplify the solution and avoid any = such issues. Specifically, what we are going to do in V5 is: 1/ Make sure the only mbuf changes are related to the reformatting of the = sched field, precisely implementing the above deprecation note; 2/ Include rte_meter.h into some ethdev headers, which you already agreed = with 3/ Avoid adding any header to librte_eal/common/include Are you OK with this? Hopefully this should remove any roadblocks and any further delays for this= patch set. Regards, Cristian