Hi John,

Signed-off-by means that the author/committer/uploader has the rights to submit that work under the associated license.  Multiple people may add their own Signed-off-by line.  But at least one Signed-off-by line is required for every patch and GerritHub is enforcing that correctly.

“Signed off” in terms of “I sign off on this patch being ready to go into SPDK” should really be done with Reviewed-by tags.

We have an “SPDK Developers” group within the SPDK GerritHub project – anyone in this group can update patches they did not author.  Both you and Ed are now in this list.  If anyone else needs to be added, please ask and the core maintainers will add you (this goes for anyone reading this message – not just John’s team!)

Thanks,

-Jim

 

On 5/3/18, 2:35 PM, "SPDK on behalf of Meneghini, John" <spdk-bounces(a)lists.01.org on behalf of John.Meneghini(a)netapp.com> wrote:

    OK. Thanks Jim.
    
    I think this works now... at least for me.
    
    Note: we might want to eliminate any confusion about what the author, vs. signer, vs. committer, vs. uploader is. I am the author of this change, Ed is the signer, and the uploader.
    
    We're developing a team of people here at NetApp who can code review, sign, and upload each other's changes.  As a matter of policy, we'd like:
    
    - Others to sign-off the author's code (we don't want people signing their own changes)
    - The author or signer to be able to upload changes
    
    In this example Ed signed my change and uploaded it.  This is unusual, normally I will upload my own changes, but we still have many engineers who don't know how to use GerritHub so Ed and I will be signing and uploading other engineers code changes and it would be good if we have some flexibility. 
    
    In the example below I had to sign my own change to get GerritHub to take it.  This is a different from the original problem which rejected my change even after I signed it. 
    
    If possible, can we fix this problem?
    
    johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
    Counting objects: 6, done.
    Delta compression using up to 8 threads.
    Compressing objects: 100% (6/6), done.
    Writing objects: 100% (6/6), 2.16 KiB | 2.16 MiB/s, done.
    Total 6 (delta 2), reused 0 (delta 0)
    remote: Resolving deltas: 100% (2/2)
    remote: Processing changes: refs: 1, done    
    To https://review.gerrithub.io/spdk/spdk
     ! [remote rejected]   HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer)
    error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
    johnm-mac-0:spdk(add_git_hooks) > git commit --amend --sign
    [add_git_hooks 4bfdb4fe] git: add .githooks to repository
     Date: Mon Feb 5 13:15:54 2018 -0500
     3 files changed, 165 insertions(+)
     create mode 100755 .githooks/pre-commit
     create mode 100755 .githooks/pre-push
    johnm-mac-0:spdk(add_git_hooks) > git push origin HEAD:refs/for/master
    Counting objects: 6, done.
    Delta compression using up to 8 threads.
    Compressing objects: 100% (6/6), done.
    Writing objects: 100% (6/6), 2.17 KiB | 2.17 MiB/s, done.
    Total 6 (delta 2), reused 0 (delta 0)
    remote: Resolving deltas: 100% (2/2)
    remote: Processing changes: updated: 1, done    
    remote: 
    remote: Updated Changes:
    remote:   https://review.gerrithub.io/#/c/spdk/spdk/+/409577 git: add .githooks to repository
    remote: 
    To https://review.gerrithub.io/spdk/spdk
     * [new branch]        HEAD -> refs/for/master
    
    On 5/2/18, 4:49 PM, "SPDK on behalf of Harris, James R" <spdk-bounces(a)lists.01.org on behalf of james.r.harris(a)intel.com> wrote:
    
        John – can you try it again and let me know if it works now?
        
        On 5/2/18, 12:13 PM, "SPDK on behalf of Walker, Benjamin" <spdk-bounces(a)lists.01.org on behalf of benjamin.walker(a)intel.com> wrote:
        
            On Wed, 2018-05-02 at 17:59 +0000, Meneghini, John wrote:
            > I’m trying to update change request: 409577
            >  
            > And GerritHub is complaining with the following error.
            
            > ! [remote rejected]   HEAD -> refs/for/master (cannot add patch set to
            > 409577.)
            > error: failed to push some refs to 'https://review.gerrithub.io/spdk/spdk'
            >  
            > Any clues as to what the problem is?
            
            We don't allow reviews to be updated with new patch sets from people that aren't
            the original owner. We did allow it originally, but some spammer/bot started
            uploading junk over top of my reviews at one point. It is a permission I can
            grant (I think) - I just have to figure out how to do it in a reasonable way.
            
            It should work if Ed tries to upload the new revision though.
            _______________________________________________
            SPDK mailing list
            SPDK(a)lists.01.org
            https://lists.01.org/mailman/listinfo/spdk
            
        
        _______________________________________________
        SPDK mailing list
        SPDK(a)lists.01.org
        https://lists.01.org/mailman/listinfo/spdk
        
    
    _______________________________________________
    SPDK mailing list
    SPDK(a)lists.01.org
    https://lists.01.org/mailman/listinfo/spdk