From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [PATCH] as i/o hang with aacraid driver 2.6.0-test1 Date: Fri, 18 Jul 2003 15:14:02 +1000 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <3F17821A.307@cyberone.com.au> References: <20030716132036.GB833@suse.de> <1058364455.1856.28.camel@mulgrave> <20030716170456.GK833@suse.de> <20030717015756.135a3f5a.akpm@osdl.org> <20030717085952.GX833@suse.de> <3F1672D9.7070309@cyberone.com.au> <20030717102926.GE833@suse.de> <3F167F98.60006@cyberone.com.au> <20030717105641.GF833@suse.de> <3F1683F5.4030107@cyberone.com.au> <20030717111059.GI833@suse.de> <3F168846.90902@cyberone.com.au> <1058474814.4638.11.camel@markh1.pdx.osdl.net> <1058481553.19508.5.camel@markh1.pdx.osdl.net> <1058485621.7424.30.camel@dell_ss5.pdx.osdl.net> <20030717170055.5dbe20c1.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from dyn-ctb-210-9-243-47.webone.com.au ([210.9.243.47]:45069 "EHLO chimp.local.net") by vger.kernel.org with ESMTP id S271716AbTGRE73 (ORCPT ); Fri, 18 Jul 2003 00:59:29 -0400 In-Reply-To: <20030717170055.5dbe20c1.akpm@osdl.org> List-Id: linux-scsi@vger.kernel.org To: Andrew Morton Cc: Daniel McNeil , markh@osdl.org, axboe@suse.de, James.Bottomley@steeleye.com, cliffw@osdl.org, linux-scsi@vger.kernel.org Andrew Morton wrote: >Daniel McNeil wrote: > >>Should >> list_add(&rq->queuelist, ad->dispatch->prev); >>be >> list_add_tail(&rq->queuelist, ad->dispatch); >> >>It is equivalent, but makes the code clearer that we're adding to the >>end. >> > >yup. > > >>Also, isn't the: !list_empty(ad->dispatch) unnecessary since a >>list_add was just done, so the list cannot be empty? >> > >more yup. > Oh, so the request should go on the dispatch list? OK that makes sense. Maybe also set arq->state = AS_RQ_DISPATCHED just in case. And I think the arq == NULL case should be checked for with rq->flags & REQ_HARDBARRIER || !blk_fs_request(rq) for consistency. I think if arq is still NULL then its a bug. Thanks Nick