From: John Partridge <johnip@sgi.com>
To: "David S. Miller" <davem@redhat.com>
Cc: Andi Kleen <ak@suse.de>,
modica@sgi.com, netdev@oss.sgi.com, jgarzik@pobox.com,
jes@sgi.com
Subject: Re: Tigon3 5701 PCI-X recv performance problem
Date: Mon, 13 Oct 2003 14:53:54 -0500 [thread overview]
Message-ID: <3F8B02D2.4020007@sgi.com> (raw)
In-Reply-To: <20031011105054.0e16a607.davem@redhat.com>
Could we create a module argument like "do_5701_align" and just give it a -1
default which does NOT do the copy but if we give the arg 1, 0, whatever it
DOES to the copy to align the buffs ?
Then inside the driver we define a macro to handle that ?
That way all you need is to include "tg3 do_5701_align=1" in modules.conf
That way all the default comiles work and no CONFIG option for people
who compile all defaults and don't want to re compile the kernel for
this issue.
Is that acceptable ?
John
David S. Miller wrote:
> On Sat, 11 Oct 2003 15:19:21 +0200
> Andi Kleen <ak@suse.de> wrote:
>
>
>>Then just don't set the argument to zero in modules.conf on the 5704cards.
>>That could be even handled somewhere in user space. Switching over sounds
>>best of course, because the performance with the copying won't be great
>
>
> There is no "argument" we don't have a variable in the tg3 driver
> that determines the "copybreak", it's a hard-coded macro define.
>
> For them it's really easy to know when the 5701 hw bug case is present,
> so they can do something like:
>
> if (len > RX_COPY_THRESHOLD
> #ifdef CONFIG_UNALIGNED_EXPENSIVE
> || tp->rx_offset == 2
> #endif
> ) {
> ...
>
> And then only their platform and only when the buggy chips are present,
> will get the desired change in behavior.
--
John Partridge
Silicon Graphics Inc
Tel: 651-683-3428
Vnet: 233-3428
E-Mail: johnip@sgi.com
next prev parent reply other threads:[~2003-10-13 19:53 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 17:12 Tigon3 5701 PCI-X recv performance problem John Partridge
2003-10-08 17:10 ` David S. Miller
2003-10-08 17:52 ` John Partridge
2003-10-08 18:26 ` David S. Miller
2003-10-08 19:02 ` John Partridge
2003-10-08 19:11 ` Steve Modica
2003-10-08 19:15 ` David S. Miller
2003-10-08 18:21 ` Steve Modica
2003-10-08 18:29 ` David S. Miller
2003-10-08 18:37 ` Andi Kleen
2003-10-08 19:22 ` David S. Miller
2003-10-08 20:22 ` Andi Kleen
2003-10-08 20:24 ` David S. Miller
2003-10-08 20:33 ` Andi Kleen
2003-10-08 20:32 ` David S. Miller
2003-10-08 20:46 ` Andi Kleen
2003-10-08 20:50 ` David S. Miller
2003-10-10 19:05 ` Steve Modica
2003-10-10 19:20 ` Andi Kleen
2003-10-11 13:17 ` Steve Modica
2003-10-11 13:19 ` Andi Kleen
2003-10-11 17:50 ` David S. Miller
2003-10-13 19:53 ` John Partridge [this message]
2003-10-13 19:51 ` David S. Miller
2003-10-14 16:49 ` John Partridge
2003-10-14 16:53 ` David S. Miller
2003-11-11 1:24 ` John Partridge
2003-11-11 2:29 ` David S. Miller
2003-11-11 20:04 ` John Partridge
2003-11-11 20:24 ` David S. Miller
2003-11-11 21:26 ` John Partridge
2003-11-11 21:32 ` Jeff Garzik
2003-12-03 22:11 ` John Partridge
2003-11-11 21:39 ` John Partridge
2003-11-11 23:09 ` David S. Miller
2003-11-11 23:53 ` Andi Kleen
2003-11-12 1:46 ` John Partridge
2003-11-12 6:19 ` Andi Kleen
2003-11-12 7:05 ` Jeff Garzik
2003-11-12 15:32 ` John Partridge
2003-11-12 15:43 ` Christoph Hellwig
2003-11-11 20:25 ` David S. Miller
2003-11-11 20:57 ` Jeff Garzik
2003-10-14 18:47 ` John Partridge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F8B02D2.4020007@sgi.com \
--to=johnip@sgi.com \
--cc=ak@suse.de \
--cc=davem@redhat.com \
--cc=jes@sgi.com \
--cc=jgarzik@pobox.com \
--cc=modica@sgi.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.