Re: mouse driver bug in 2.6.0-test7?

From: 4Front Technologies <dev@opensound.com>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: Martin Josefsson <gandalf@wlug.westbo.se>, linux-kernel@vger.kernel.org
Subject: Re: mouse driver bug in 2.6.0-test7?
Date: Tue, 14 Oct 2003 13:04:03 -0700	[thread overview]
Message-ID: <3F8C56B3.1080504@opensound.com> (raw)
In-Reply-To: <20031014193847.GA9112@ucw.cz>

Vojtech Pavlik wrote:
> On Tue, Oct 14, 2003 at 09:18:34PM +0200, Martin Josefsson wrote:
> 
>>On Tue, 2003-10-14 at 20:04, 4Front Technologies wrote:
>>
>>>Why is the PS2 mouse tracking about 2x faster in 2.6.0-test7 compared
>>>to 2.4.xx?. Has anybody else seen this problem?.
>>>
>>>If I move the mouse 1 inch horizontally left-to-right on the mouse
>>>pad, the cursor on the screen moves almost twice the distance on the
>>>screen compared to Linux 2.4.xx
>>
>>It's probably mostly because Vojtech changed the samplerate from 200 to
>>60. Here's a patch to change it back. I've sent it to Vojtech but he's
>>completely ignored it so far. This patch also readds the fallback logic
>>that was used before his change, although it uses the new
>>samplerate-table.
>>
>>Without this patch my mouse is awful to use.
>>Vojtech, please consider this patch, at least say yay or nay.
> 
> 
> Patch considered. I'll up the samplerate default to 80, but not more,
> since samplerates above that cause trouble for a lot of people (keyboard
> doesn't work when you're moving the mouse).
> 
> The "set lower rate in case ..." part of the patch doesn't make sense.
> If the user gives a too low (less than 10) samples per second, then the
> original code will try to set 0, which is stupid, but harmless. The
> added code will try to access beyond the bounds of the rates[] array.

Hi Martin/Vojtech,

Martin, many thanks for your fix - it works perfectly now.

Oddly enough the sample rate of 200 seems to have fixed the problem.
Vojetech,  Martin's fixes are fully functional. If you want to keep it at 80,
I'd recommend that you make the sample rate a module config option so that
users may be able to tweak this for their systems.

The default of 200 has been tested on VIA400 and IntelICH5 systems that I have.
One running Redhat9/2.6.0-test7 and the other running Gentoo 1.4/2.6.0-test7

best regards

Dev Mazumdar
---------------------------------------------------------------------
4Front Technologies
4035 Lafayette Place, Unit F, Culver City, CA 90232, USA
Tel: 310 202 8530   Fax: 310 202 0496   URL: http://www.opensound.com
---------------------------------------------------------------------