From: Manfred Spraul <manfred@colorfullife.com>
To: Erik Jacobson <erikj@subway.americas.sgi.com>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6 /proc/interrupts fails on systems with many CPUs
Date: Tue, 11 Nov 2003 19:15:55 +0100 [thread overview]
Message-ID: <3FB1275B.1000901@colorfullife.com> (raw)
Erik wrote:
> /* don't ask for more than the kmalloc() max size, currently 128 KB */
> if (size > 128 * 1024)
> size = 128 * 1024;
>- buf = kmalloc(size, GFP_KERNEL);
>+ buf = __vmalloc(size, GFP_KERNEL, PAGE_KERNEL);
>
>
kmalloc needs a contiguous memory block. Thus after a long runtime,
large kmalloc calls can fail due to fragmentation. I'd prefer if you
switch to vmalloc after 2*PAGE_SIZE.
Or switch to a line based seq file iterator, then you wouldn't need the
huge buffer.
--
Manfred
next reply other threads:[~2003-11-11 18:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-11 18:15 Manfred Spraul [this message]
[not found] <BF1FE1855350A0479097B3A0D2A80EE0013B1188@hdsmsx402.hd.intel.com>
2003-11-11 19:55 ` 2.6 /proc/interrupts fails on systems with many CPUs Len Brown
2003-11-11 23:37 ` Erlend Aasland
2003-11-12 2:35 ` Martin J. Bligh
-- strict thread matches above, loose matches on Subject: below --
2003-11-11 17:21 Erik Jacobson
2003-11-11 17:29 ` Randy.Dunlap
2003-11-11 17:51 ` Robert Love
2003-11-11 18:02 ` Martin J. Bligh
2003-11-11 18:24 ` Linus Torvalds
2003-11-11 18:57 ` Martin J. Bligh
2003-11-11 18:36 ` Linus Torvalds
2003-11-11 20:14 ` Anton Blanchard
2003-11-11 22:41 ` Martin J. Bligh
2003-11-11 22:32 ` Zwane Mwaikambo
2003-11-11 18:17 ` Linus Torvalds
2003-11-11 18:22 ` viro
2003-11-11 20:15 ` Jonathan Corbet
2003-11-11 18:32 ` Randy.Dunlap
2003-11-11 19:19 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FB1275B.1000901@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=erikj@subway.americas.sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.