From: "Andreas Färber" <andreas.faerber@web.de>
To: Alexandre Raymond <cerbere@gmail.com>
Cc: qemu-trivial@nongnu.org, Tristan Gingold <gingold@adacore.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/6] Cocoa: avoid displaying window when command-line contains '-h'
Date: Sat, 28 May 2011 17:05:09 +0200 [thread overview]
Message-ID: <3FB3F9C7-2BDB-4363-A744-07E3AD68A4AC@web.de> (raw)
In-Reply-To: <1306516951-31105-3-git-send-email-cerbere@gmail.com>
Am 27.05.2011 um 19:22 schrieb Alexandre Raymond:
> There was already a check in place to avoid displaying a window
> in certain modes such as vnc, nographic or curses.
>
> Add a check for '-h' to avoid displaying a window for a split-
> second before showing the usage information.
>
> Signed-off-by: Alexandre Raymond <cerbere@gmail.com>
> ---
> ui/cocoa.m | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index 20f91bc..7fb8d96 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -865,7 +865,8 @@ int main (int argc, const char * argv[]) {
>
> /* In case we don't need to display a window, let's not do that */
> for (i = 1; i < argc; i++) {
> - if (!strcmp(argv[i], "-vnc") ||
> + if (!strcmp(argv[i], "-h") ||
> + !strcmp(argv[i], "-vnc") ||
> !strcmp(argv[i], "-nographic") ||
> !strcmp(argv[i], "-curses")) {
> return qemu_main(gArgc, gArgv);
Nack. I have a patch from Tristan queued (sorry, forgot to send pull
request before my vacation), please rebase against that.
Cf. http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/cocoa-for-upstream
Also, your patch fails to detect -help.
BTW -M ? and others face a similar detection issue, so I believe while
adding to this list is a handy short-term fix, we need a better
solution there. Suggestions and patches welcome.
Andreas
next prev parent reply other threads:[~2011-05-28 15:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 17:22 [Qemu-devel] [PATCH 0/6] Fix compilation issues under darwin Alexandre Raymond
2011-05-27 17:22 ` [Qemu-devel] [PATCH 1/6] Fix incorrect check for fdatasync() in configure Alexandre Raymond
2011-05-29 14:50 ` Andreas Färber
2011-05-29 15:46 ` Alexandre Raymond
2011-05-29 17:05 ` Andreas Färber
2011-05-27 17:22 ` [Qemu-devel] [PATCH 2/6] Cocoa: avoid displaying window when command-line contains '-h' Alexandre Raymond
2011-05-28 15:05 ` Andreas Färber [this message]
2011-05-27 17:22 ` [Qemu-devel] [PATCH 3/6] Fix compilation warning due to incorrectly specified type Alexandre Raymond
2011-05-27 17:42 ` Stefan Weil
2011-05-29 15:02 ` Andreas Färber
2011-05-27 17:22 ` [Qemu-devel] [PATCH 4/6] Fix missing prototype under cocoa for qemu_main Alexandre Raymond
2011-05-29 15:11 ` Andreas Färber
2011-05-29 19:58 ` [Qemu-devel] [PATCH] cocoa: Provide central qemu_main() prototype Andreas Färber
2011-05-29 23:53 ` Alexandre Raymond
2011-06-02 11:33 ` Andreas Färber
2011-06-09 18:30 ` Andreas Färber
2011-05-27 17:22 ` [Qemu-devel] [PATCH 5/6] Remove warning in printf due to type mismatch Alexandre Raymond
2011-05-27 17:35 ` Stefan Weil
2011-05-27 19:11 ` Markus Armbruster
2011-05-27 20:44 ` Stefan Weil
2011-05-27 22:10 ` Alexandre Raymond
2011-05-28 6:55 ` Paolo Bonzini
2011-05-28 8:19 ` Stefan Weil
2011-05-27 17:22 ` [Qemu-devel] [PATCH 6/6] Avoid compilation warning regarding kvm under darwin Alexandre Raymond
2011-05-27 17:39 ` Stefan Weil
2011-05-28 14:55 ` [Qemu-devel] [PATCH 0/6] Fix compilation issues " Andreas Färber
2011-05-28 19:41 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FB3F9C7-2BDB-4363-A744-07E3AD68A4AC@web.de \
--to=andreas.faerber@web.de \
--cc=cerbere@gmail.com \
--cc=gingold@adacore.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.