From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754957AbaDOMsv (ORCPT ); Tue, 15 Apr 2014 08:48:51 -0400 Received: from mx0b-0016ce01.pphosted.com ([67.231.156.153]:47230 "EHLO mx0b-0016ce01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754737AbaDOMsk convert rfc822-to-8bit (ORCPT ); Tue, 15 Apr 2014 08:48:40 -0400 From: Vikas Chaudhary To: Alexander Gordeev , linux-kernel CC: Dept-Eng iSCSI Driver , linux-scsi , linux-pci Subject: Re: [PATCH v2 RESEND 22/23] qla4xxx: Use pci_enable_msix_exact() instead of pci_enable_msix() Thread-Topic: [PATCH v2 RESEND 22/23] qla4xxx: Use pci_enable_msix_exact() instead of pci_enable_msix() Thread-Index: AQHPV7gyTgFRPPtAz06fU/9y/rKdb5sTdB8A Date: Tue, 15 Apr 2014 12:48:35 +0000 Message-ID: <3FC4AB8B47ECD546BCD4B361A64BEACD8C68C56A@avmb3.qlogic.org> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.9.131030 x-originating-ip: [10.35.4.170] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5600 definitions=7408 signatures=670416 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1404150214 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/04/14 1:35 pm, "Alexander Gordeev" wrote: >As result of deprecation of MSI-X/MSI enablement functions >pci_enable_msix() and pci_enable_msi_block() all drivers >using these two interfaces need to be updated to use the >new pci_enable_msi_range() or pci_enable_msi_exact() >and pci_enable_msix_range() or pci_enable_msix_exact() >interfaces. > >Signed-off-by: Alexander Gordeev >Cc: Vikas Chaudhary >Cc: iscsi-driver@qlogic.com >Cc: linux-scsi@vger.kernel.org >Cc: linux-pci@vger.kernel.org >--- > drivers/scsi/qla4xxx/ql4_nx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c >index 63328c8..a3e69e6 100644 >--- a/drivers/scsi/qla4xxx/ql4_nx.c >+++ b/drivers/scsi/qla4xxx/ql4_nx.c >@@ -3787,7 +3787,7 @@ qla4_8xxx_enable_msix(struct scsi_qla_host *ha) > for (i = 0; i < QLA_MSIX_ENTRIES; i++) > entries[i].entry = qla4_8xxx_msix_entries[i].entry; > >- ret = pci_enable_msix(ha->pdev, entries, ARRAY_SIZE(entries)); >+ ret = pci_enable_msix_exact(ha->pdev, entries, ARRAY_SIZE(entries)); > if (ret) { > ql4_printk(KERN_WARNING, ha, > "MSI-X: Failed to enable support -- %d/%d\n", >-- >1.7.7.6 Acked-By: Vikas Chaudhary From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vikas Chaudhary Subject: Re: [PATCH v2 RESEND 22/23] qla4xxx: Use pci_enable_msix_exact() instead of pci_enable_msix() Date: Tue, 15 Apr 2014 12:48:35 +0000 Message-ID: <3FC4AB8B47ECD546BCD4B361A64BEACD8C68C56A@avmb3.qlogic.org> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_000_3FC4AB8B47ECD546BCD4B361A64BEACD8C68C56Aavmb3qlogicorg_" Return-path: Received: from mx0b-0016ce01.pphosted.com ([67.231.156.153]:6610 "EHLO mx0b-0016ce01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754932AbaDOMsj (ORCPT ); Tue, 15 Apr 2014 08:48:39 -0400 In-Reply-To: Content-Language: en-US Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Alexander Gordeev , linux-kernel Cc: Dept-Eng iSCSI Driver , linux-scsi , linux-pci --_000_3FC4AB8B47ECD546BCD4B361A64BEACD8C68C56Aavmb3qlogicorg_ Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable On 14/04/14 1:35 pm, "Alexander Gordeev" wrote: >As result of deprecation of MSI-X/MSI enablement functions >pci_enable_msix() and pci_enable_msi_block() all drivers >using these two interfaces need to be updated to use the >new pci_enable_msi_range() or pci_enable_msi_exact() >and pci_enable_msix_range() or pci_enable_msix_exact() >interfaces. > >Signed-off-by: Alexander Gordeev >Cc: Vikas Chaudhary >Cc: iscsi-driver@qlogic.com >Cc: linux-scsi@vger.kernel.org >Cc: linux-pci@vger.kernel.org >--- > drivers/scsi/qla4xxx/ql4_nx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c >index 63328c8..a3e69e6 100644 >--- a/drivers/scsi/qla4xxx/ql4_nx.c >+++ b/drivers/scsi/qla4xxx/ql4_nx.c >@@ -3787,7 +3787,7 @@ qla4_8xxx_enable_msix(struct scsi_qla_host *ha) > for (i =3D 0; i < QLA_MSIX_ENTRIES; i++) > entries[i].entry =3D qla4_8xxx_msix_entries[i].entry; >=20 >- ret =3D pci_enable_msix(ha->pdev, entries, ARRAY_SIZE(entries)); >+ ret =3D pci_enable_msix_exact(ha->pdev, entries, ARRAY_SIZE(entries)); > if (ret) { > ql4_printk(KERN_WARNING, ha, > "MSI-X: Failed to enable support -- %d/%d\n", >--=20 >1.7.7.6 Acked-By: Vikas Chaudhary --_000_3FC4AB8B47ECD546BCD4B361A64BEACD8C68C56Aavmb3qlogicorg_ Content-Disposition: attachment; filename="winmail.dat" Content-Transfer-Encoding: base64 Content-Type: application/ms-tnef; name="winmail.dat" eJ8+IhtlAQaQCAAEAAAAAAABAAEAAQeQBgAIAAAA5AQAAAAAAADoAAEJgAEAIQAAAEMyOUJDMjhC NDBFNTQ3NDk4NjVDODc3RUI3ODREOEM3AEEHAQ2ABAACAAAAAgACAAEFgAMADgAAAN4HBAAPAAwA MAAjAAIAWQEBIIADAA4AAADeBwQADwAMADAAIwACAFkBAQiABwAYAAAASVBNLk1pY3Jvc29mdCBN YWlsLk5vdGUAMQgBBIABAF4AAABSZTogW1BBVENIIHYyIFJFU0VORCAyMi8yM10gcWxhNHh4eDog VXNlIHBjaV9lbmFibGVfbXNpeF9leGFjdCgpIGluc3RlYWQgb2YgcGNpX2VuYWJsZV9tc2l4KCkA Eh8BA5AGAAASAAA1AAAAAgF/AAEAAAA8AAAAPDNGQzRBQjhCNDdFQ0Q1NDZCQ0Q0QjM2MUE2NEJF QUNEOEM2OEM1NkFAYXZtYjMucWxvZ2ljLm9yZz4ACwAfDgEAAAACAQkQAQAAADYEAAAyBAAAmAcA AExaRnWliAC0YQAKZmJpZAQAAGNjwHBnMTI1MgD+A0PwdGV4dAH3AqQD4wIABGNoCsBzZXQwIO8H bQKDAFARTTIKgAa0AoCWfQqACMg7CWIxOQ7AvwnDFnIKMhZxAoAVYioJsHMJ8ASQYXQFsg5QA2Bz om8BgCBFeBHBbhgwXQZSdgSQF7YCEHIAwHR9CFBuGjEQIAXABaAbZGSaIANSIBAiF7JcdgiQ5Hdr C4BkNR1TBPAHQA0XcDAKcRfyYmttawZzAZAAICBCTV9C4EVHSU59CvwB8QvyWmwLgGUKgSGkTwOg MTg0LzAisCKgIpA6MwA1IHBtLCAiQc0ecHgAcASBIEcFsAEAgGV2IiA8YWckhCZACXER0HQuBaBt PiwgdwNgECA6IZw+QWMEIAlwc3VsBUAZMCDNAQBwCXAeUHRpAiAoQqEF4EktWC8pcSAJ8B8BoB5w B4ACMBxwdW5jhyjyDgAnRXBjaV8qFIRfbQCQeCgpICQRiyNwK+tfAmBvY2sswrpsAyBkBRAaMStH dQCQGxnAHMBoB5AZ4HR3b/YgC4AboWYA0AeRGFAcUYkYkCBiGeB1cGQYgP8xpC/QMHEwQCc2GFAH 4C09/xhwGcEswShABcAtPSPxKvD/LMAnNiz/LKA09zWfOMA2vY0w2C4nNic2U2lnGFAEZC0ZMGYt Ynk6niAj3yT/JgMnNkNjPgBQVmlrYQQgQxHQdfklwXJ5PzAdYEFxJgBBxnRAcQkAZw5QQE8EAGM9 AJAtLuRDWUCaIaF1eBItROJAdhgwci5rUQSRZWwuBbBnRk8tdyvRR68nRS1LcCc2LtYvxUTiL0Ng YTR4TUBM8ZA0X254JgAgfDVw0TVwMiArS5gxHHADEPsHkRmUZCOgTzALgBIAACDxKxIoKylQIgEA HnBQtN4tNxcnNg3gASAgS3BDkNkFQGEvTD9NS2JT/007AzsIAQB4IDYzMzIAOGM4Li5hM2UcNjlZ YCKQHqA2NDTvSvlT31bvJ1QrXVBV31vvCSdUQEBTcDM3ODc8LDdOcGBFYAFU0l84p01BLAsfYHJ1 KvAgROKyX1TRX2gZEAVAKhHQHzcXAzABkRxwBbEoaSAwPSAwOzDAPzAgUQhMQV8pcVhfRU7gVFJJ RVNl0V1QZEwHZOMqgQiBc1tpXS7/aLJCMGWgYWg6RGjNFiBkZ39LBmTjCXAFQGWgK94R0C07K8AB AHYjoGi1I6BBUhBSQVlfKYBaRSjpaLUpKWvXK20POf5uv39vz3DcZNQGkGVgchEs0Fw/AABnr02C KKAw0S5gS0VQUk5fV3UATiAgR/sjoBHQLHfvTiIjsClzPgB+RgtwHnAxsyoUYyAyMHBDCRFTcSAl ZC9+YFw4XG4ierdasSc2MS5qN4BBNiGcQS5QPXFCfz3xQV9Cb0N/IZwVQoZwAAAfAEIAAQAAACAA AABWAGkAawBhAHMAIABDAGgAYQB1AGQAaABhAHIAeQAAAB8AZQABAAAANgAAAHYAaQBrAGEAcwAu AGMAaABhAHUAZABoAGEAcgB5AEAAcQBsAG8AZwBpAGMALgBjAG8AbQAAAAAAHwBkAAEAAAAKAAAA UwBNAFQAUAAAAAAAAgFBAAEAAAB4AAAAAAAAAIErH6S+oxAZnW4A3QEPVAIAAACAVgBpAGsAYQBz ACAAQwBoAGEAdQBkAGgAYQByAHkAAABTAE0AVABQAAAAdgBpAGsAYQBzAC4AYwBoAGEAdQBkAGgA YQByAHkAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAHwACXQEAAAA2AAAAdgBpAGsAYQBzAC4AYwBo AGEAdQBkAGgAYQByAHkAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAAAAfAOVfAQAAAD4AAABzAGkA cAA6AHYAaQBrAGEAcwAuAGMAaABhAHUAZABoAGEAcgB5AEAAcQBsAG8AZwBpAGMALgBjAG8AbQAA AAAAHwAaDAEAAAAgAAAAVgBpAGsAYQBzACAAQwBoAGEAdQBkAGgAYQByAHkAAAAfAB8MAQAAADYA AAB2AGkAawBhAHMALgBjAGgAYQB1AGQAaABhAHIAeQBAAHEAbABvAGcAaQBjAC4AYwBvAG0AAAAA AB8AHgwBAAAACgAAAFMATQBUAFAAAAAAAAIBGQwBAAAAeAAAAAAAAACBKx+kvqMQGZ1uAN0BD1QC AAAAgFYAaQBrAGEAcwAgAEMAaABhAHUAZABoAGEAcgB5AAAAUwBNAFQAUAAAAHYAaQBrAGEAcwAu AGMAaABhAHUAZABoAGEAcgB5AEAAcQBsAG8AZwBpAGMALgBjAG8AbQAAAB8AAV0BAAAANgAAAHYA aQBrAGEAcwAuAGMAaABhAHUAZABoAGEAcgB5AEAAcQBsAG8AZwBpAGMALgBjAG8AbQAAAAAAHwD4 PwEAAAAgAAAAVgBpAGsAYQBzACAAQwBoAGEAdQBkAGgAYQByAHkAAAAfACNAAQAAADYAAAB2AGkA awBhAHMALgBjAGgAYQB1AGQAaABhAHIAeQBAAHEAbABvAGcAaQBjAC4AYwBvAG0AAAAAAB8AIkAB AAAACgAAAFMATQBUAFAAAAAAAAIB+T8BAAAAeAAAAAAAAACBKx+kvqMQGZ1uAN0BD1QCAAAAgFYA aQBrAGEAcwAgAEMAaABhAHUAZABoAGEAcgB5AAAAUwBNAFQAUAAAAHYAaQBrAGEAcwAuAGMAaABh AHUAZABoAGEAcgB5AEAAcQBsAG8AZwBpAGMALgBjAG8AbQAAAB8ACV0BAAAANgAAAHYAaQBrAGEA cwAuAGMAaABhAHUAZABoAGEAcgB5AEAAcQBsAG8AZwBpAGMALgBjAG8AbQAAAAAAHwAxQAEAAAAC AAAAAAAAAAsAQDoBAAAAHwAwQAEAAAACAAAAAAAAAB8AGgABAAAAEgAAAEkAUABNAC4ATgBvAHQA ZQAAAAAAAwDxPwkEAAALAEA6AQAAAAMA/T/kBAAAAgELMAEAAAAQAAAAwpvCi0DlR0mGXId+t4TY xwMAFwABAAAAQAA5AIBTlwOpWM8BQAAIMHdtmwOpWM8BCwAAgAggBgAAAAAAwAAAAAAAAEYAAAAA FIUAAAEAAAAfAACAhgMCAAAAAADAAAAAAAAARgEAAAAeAAAAYQBjAGMAZQBwAHQAbABhAG4AZwB1 AGEAZwBlAAAAAAABAAAADAAAAGUAbgAtAFUAUwAAAAsAAIAIIAYAAAAAAMAAAAAAAABGAAAAAAaF AAAAAAAAHwA3AAEAAAC8AAAAUgBlADoAIABbAFAAQQBUAEMASAAgAHYAMgAgAFIARQBTAEUATgBE ACAAMgAyAC8AMgAzAF0AIABxAGwAYQA0AHgAeAB4ADoAIABVAHMAZQAgAHAAYwBpAF8AZQBuAGEA YgBsAGUAXwBtAHMAaQB4AF8AZQB4AGEAYwB0ACgAKQAgAGkAbgBzAHQAZQBhAGQAIABvAGYAIABw AGMAaQBfAGUAbgBhAGIAbABlAF8AbQBzAGkAeAAoACkAAAAfAD0AAQAAAAoAAABSAGUAOgAgAAAA AAADADYAAAAAAB8AQhABAAAAnAAAADwAYwA5AGYAZABlADUAOABiADYANgA5ADcAMgA0AGIAOQBm ADEAYQAzAGUANwA0ADQANAAzADkAYgA2ADkAYwBhADMAOQBiADUAZgA0AGIAYgAuADEAMwA5ADcA NAA2ADEANgA1ADIALgBnAGkAdAAuAGEAZwBvAHIAZABlAGUAdgBAAHIAZQBkAGgAYQB0AC4AYwBv AG0APgAAAAIBcQABAAAAGwAAAAEBz1e4Mk4BUTz7QM9On1P/cv6ynW+bE3QfAAAfAHAAAQAAALQA AABbAFAAQQBUAEMASAAgAHYAMgAgAFIARQBTAEUATgBEACAAMgAyAC8AMgAzAF0AIABxAGwAYQA0 AHgAeAB4ADoAIABVAHMAZQAgAHAAYwBpAF8AZQBuAGEAYgBsAGUAXwBtAHMAaQB4AF8AZQB4AGEA YwB0ACgAKQAgAGkAbgBzAHQAZQBhAGQAIABvAGYAIABwAGMAaQBfAGUAbgBhAGIAbABlAF8AbQBz AGkAeAAoACkAAAAfADUQAQAAAHgAAAA8ADMARgBDADQAQQBCADgAQgA0ADcARQBDAEQANQA0ADYA QgBDAEQANABCADMANgAxAEEANgA0AEIARQBBAEMARAA4AEMANgA4AEMANQA2AEEAQABhAHYAbQBi ADMALgBxAGwAbwBnAGkAYwAuAG8AcgBnAD4AAAAfADkQAQAAAPIAAAA8AGMAbwB2AGUAcgAuADEA MwA5ADcANAA2ADEANgA1ADIALgBnAGkAdAAuAGEAZwBvAHIAZABlAGUAdgBAAHIAZQBkAGgAYQB0 AC4AYwBvAG0APgAgADwAYwA5AGYAZABlADUAOABiADYANgA5ADcAMgA0AGIAOQBmADEAYQAzAGUA NwA0ADQANAAzADkAYgA2ADkAYwBhADMAOQBiADUAZgA0AGIAYgAuADEAMwA5ADcANAA2ADEANgA1 ADIALgBnAGkAdAAuAGEAZwBvAHIAZABlAGUAdgBAAHIAZQBkAGgAYQB0AC4AYwBvAG0APgAAAAAA AwDeP59OAABAAAcw5cOKA6lYzwEDACYAAAAAAAIBRwABAAAALwAAAGM9VVM7YT0gO3A9UUxvZ2lj O2w9QVZNQjMtMTQwNDE1MTI0ODM1Wi0xNDk5MjMAAB8AFRABAAAAWAAAAEMARAA0ADcAMwBDAEMA RABBADIAQQBDADgARAA0AEQAQQAyADkAMAAzADgAMAA3AEYAOAAwAEQANABBAEQARQBAAHEAbABv AGcAaQBjAC4AYwBvAG0AAAACARQwAQAAAAwAAABgAAAAoz8qlE8AAAAfAPo/AQAAACAAAABWAGkA awBhAHMAIABDAGgAYQB1AGQAaABhAHIAeQAAAB8AAICGAwIAAAAAAMAAAAAAAABGAQAAABYAAAB1 AHMAZQByAC0AYQBnAGUAbgB0AAAAAAABAAAARgAAAE0AaQBjAHIAbwBzAG8AZgB0AC0ATQBhAGMA TwB1AHQAbABvAG8AawAvADEANAAuADMALgA5AC4AMQAzADEAMAAzADAAAAAAAB8AAIAfpOszqHou Qr57eeGpjlSzAQAAADgAAABDAG8AbgB2AGUAcgBzAGEAdABpAG8AbgBJAG4AZABlAHgAVAByAGEA YwBrAGkAbgBnAEUAeAAAAAEAAABuAQAASQBJAD0AMAAxADAAMQBDAEYANQA4AEEAOQAwADMAOQBG AEEAOQBDADkAMgBGADcAOQBBAEUARABFADQARAA4ADIAMQAzAEIAMwBGADcARgBFAEMAOAAwADUA NgBBADsAUwBCAE0ASQBEAD0ANgA0ADsAUwAxAD0APABjADkAZgBkAGUANQA4AGIANgA2ADkANwAy ADQAYgA5AGYAMQBhADMAZQA3ADQANAA0ADMAOQBiADYAOQBjAGEAMwA5AGIANQBmADQAYgBiAC4A MQAzADkANwA0ADYAMQA2ADUAMgAuAGcAaQB0AC4AYQBnAG8AcgBkAGUAZQB2AEAAcgBlAGQAaABh AHQALgBjAG8AbQA+ADsAVgBlAHIAcwBpAG8AbgA9AFYAZQByAHMAaQBvAG4AIAAxADQALgAyACAA KABCAHUAaQBsAGQAIAAzADgANwAuADAAKQAsACAAUwB0AGEAZwBlAD0ASAAyAAAAAAADAA00/T8A AB8AAICGAwIAAAAAAMAAAAAAAABGAQAAACAAAAB4AC0AbQBzAC0AaABhAHMALQBhAHQAdABhAGMA aAAAAAEAAAACAAAAAAAAAB8AAICGAwIAAAAAAMAAAAAAAABGAQAAACIAAAB4AC0AbwByAGkAZwBp AG4AYQB0AGkAbgBnAC0AaQBwAAAAAAABAAAAHAAAAFsAMQAwAC4AMwA1AC4ANAAuADEANwAwAF0A AACZeg== --_000_3FC4AB8B47ECD546BCD4B361A64BEACD8C68C56Aavmb3qlogicorg_--