From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752595AbaG1Lr1 (ORCPT ); Mon, 28 Jul 2014 07:47:27 -0400 Received: from mx0a-0016ce01.pphosted.com ([67.231.148.157]:65319 "EHLO mx0a-0016ce01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752309AbaG1LrY convert rfc822-to-8bit (ORCPT ); Mon, 28 Jul 2014 07:47:24 -0400 From: Vikas Chaudhary To: Alexander Gordeev , linux-kernel CC: Dept-Eng iSCSI Driver , linux-scsi , linux-pci Subject: Re: [PATCH v2 RESEND 22/23] qla4xxx: Use pci_enable_msix_exact() instead of pci_enable_msix() Thread-Topic: [PATCH v2 RESEND 22/23] qla4xxx: Use pci_enable_msix_exact() instead of pci_enable_msix() Thread-Index: AQHPoSCIRrAupA41eUmdqiyexhrgOJuyjesAgAO0tgA= Date: Mon, 28 Jul 2014 11:47:19 +0000 Message-ID: <3FC4AB8B47ECD546BCD4B361A64BEACD8C6CAFD2@avmb3.qlogic.org> References: <0496ccbc0f203afaeeb7758c146b93c2f387684c.1405533479.git.agordeev@redhat.com> <20140726084137.GL21129@agordeev.usersys.redhat.com> In-Reply-To: <20140726084137.GL21129@agordeev.usersys.redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.9.131030 x-originating-ip: [10.1.4.10] disclaimer: bypass Content-Type: text/plain; charset="us-ascii" Content-ID: <9B054D59BA2FE44BB231781055ED7A29@qlogic.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5600 definitions=7512 signatures=670489 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1407280135 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-By: Vikas Chaudhary On 26/07/14 2:11 pm, "Alexander Gordeev" wrote: >On Wed, Jul 16, 2014 at 08:05:26PM +0200, Alexander Gordeev wrote: >> As result of deprecation of MSI-X/MSI enablement functions >> pci_enable_msix() and pci_enable_msi_block() all drivers >> using these two interfaces need to be updated to use the >> new pci_enable_msi_range() or pci_enable_msi_exact() >> and pci_enable_msix_range() or pci_enable_msix_exact() >> interfaces. > >Hi Vikas, > >Could you please reveiw this patch? > >Thanks! > >> Signed-off-by: Alexander Gordeev >> Cc: Vikas Chaudhary >> Cc: iscsi-driver@qlogic.com >> Cc: linux-scsi@vger.kernel.org >> Cc: linux-pci@vger.kernel.org >> Acked-By: Vikas Chaudhary >> --- >> drivers/scsi/qla4xxx/ql4_nx.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/scsi/qla4xxx/ql4_nx.c >>b/drivers/scsi/qla4xxx/ql4_nx.c >> index 9dbdb4b..7c33658 100644 >> --- a/drivers/scsi/qla4xxx/ql4_nx.c >> +++ b/drivers/scsi/qla4xxx/ql4_nx.c >> @@ -4221,7 +4221,7 @@ qla4_8xxx_enable_msix(struct scsi_qla_host *ha) >> for (i = 0; i < QLA_MSIX_ENTRIES; i++) >> entries[i].entry = qla4_8xxx_msix_entries[i].entry; >> >> - ret = pci_enable_msix(ha->pdev, entries, ARRAY_SIZE(entries)); >> + ret = pci_enable_msix_exact(ha->pdev, entries, ARRAY_SIZE(entries)); >> if (ret) { >> ql4_printk(KERN_WARNING, ha, >> "MSI-X: Failed to enable support -- %d/%d\n", >> -- >> 1.7.7.6 >> > >-- >Regards, >Alexander Gordeev >agordeev@redhat.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vikas Chaudhary Subject: Re: [PATCH v2 RESEND 22/23] qla4xxx: Use pci_enable_msix_exact() instead of pci_enable_msix() Date: Mon, 28 Jul 2014 11:47:19 +0000 Message-ID: <3FC4AB8B47ECD546BCD4B361A64BEACD8C6CAFD2@avmb3.qlogic.org> References: <0496ccbc0f203afaeeb7758c146b93c2f387684c.1405533479.git.agordeev@redhat.com> <20140726084137.GL21129@agordeev.usersys.redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_000_3FC4AB8B47ECD546BCD4B361A64BEACD8C6CAFD2avmb3qlogicorg_" Return-path: In-Reply-To: <20140726084137.GL21129@agordeev.usersys.redhat.com> Content-Language: en-US Sender: linux-pci-owner@vger.kernel.org To: Alexander Gordeev , linux-kernel Cc: Dept-Eng iSCSI Driver , linux-scsi , linux-pci List-Id: linux-scsi@vger.kernel.org --_000_3FC4AB8B47ECD546BCD4B361A64BEACD8C6CAFD2avmb3qlogicorg_ Content-Type: text/plain; charset="us-ascii" Content-ID: <9B054D59BA2FE44BB231781055ED7A29@qlogic.com> Content-Transfer-Encoding: quoted-printable Acked-By: Vikas Chaudhary On 26/07/14 2:11 pm, "Alexander Gordeev" wrote: >On Wed, Jul 16, 2014 at 08:05:26PM +0200, Alexander Gordeev wrote: >> As result of deprecation of MSI-X/MSI enablement functions >> pci_enable_msix() and pci_enable_msi_block() all drivers >> using these two interfaces need to be updated to use the >> new pci_enable_msi_range() or pci_enable_msi_exact() >> and pci_enable_msix_range() or pci_enable_msix_exact() >> interfaces. > >Hi Vikas, > >Could you please reveiw this patch? > >Thanks! > >> Signed-off-by: Alexander Gordeev >> Cc: Vikas Chaudhary >> Cc: iscsi-driver@qlogic.com >> Cc: linux-scsi@vger.kernel.org >> Cc: linux-pci@vger.kernel.org >> Acked-By: Vikas Chaudhary >> --- >> drivers/scsi/qla4xxx/ql4_nx.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >>=20 >> diff --git a/drivers/scsi/qla4xxx/ql4_nx.c >>b/drivers/scsi/qla4xxx/ql4_nx.c >> index 9dbdb4b..7c33658 100644 >> --- a/drivers/scsi/qla4xxx/ql4_nx.c >> +++ b/drivers/scsi/qla4xxx/ql4_nx.c >> @@ -4221,7 +4221,7 @@ qla4_8xxx_enable_msix(struct scsi_qla_host *ha) >> for (i =3D 0; i < QLA_MSIX_ENTRIES; i++) >> entries[i].entry =3D qla4_8xxx_msix_entries[i].entry; >> =20 >> - ret =3D pci_enable_msix(ha->pdev, entries, ARRAY_SIZE(entries)); >> + ret =3D pci_enable_msix_exact(ha->pdev, entries, ARRAY_SIZE(entries)); >> if (ret) { >> ql4_printk(KERN_WARNING, ha, >> "MSI-X: Failed to enable support -- %d/%d\n", >> --=20 >> 1.7.7.6 >>=20 > >--=20 >Regards, >Alexander Gordeev >agordeev@redhat.com --_000_3FC4AB8B47ECD546BCD4B361A64BEACD8C6CAFD2avmb3qlogicorg_ Content-Disposition: attachment; filename="winmail.dat" Content-Transfer-Encoding: base64 Content-Type: application/ms-tnef; name="winmail.dat" eJ8+IlwfAQaQCAAEAAAAAAABAAEAAQeQBgAIAAAA5AQAAAAAAADoAAEJgAEAIQAAAENGRjBCODAz NDI1NDE1NDA5OTgxMDIzNjE0NzlDMjdBAN0GAQ2ABAACAAAAAgACAAEFgAMADgAAAN4HBwAcAAsA LwATAAEAVgEBIIADAA4AAADeBwcAHAALAC8AEwABAFYBAQiABwAYAAAASVBNLk1pY3Jvc29mdCBN YWlsLk5vdGUAMQgBBIABAF4AAABSZTogW1BBVENIIHYyIFJFU0VORCAyMi8yM10gcWxhNHh4eDog VXNlIHBjaV9lbmFibGVfbXNpeF9leGFjdCgpIGluc3RlYWQgb2YgcGNpX2VuYWJsZV9tc2l4KCkA Eh8BA5AGAOQSAAA2AAAAAgF/AAEAAAA8AAAAPDNGQzRBQjhCNDdFQ0Q1NDZCQ0Q0QjM2MUE2NEJF QUNEOEM2Q0FGRDJAYXZtYjMucWxvZ2ljLm9yZz4ACwAfDgEAAAACAQkQAQAAAMkEAADFBAAAKgkA AExaRnUmx09UYQAKZmJpZAQAAGNjwHBnMTI1MgD+A0PwdGV4dAH3AqQD4wIABGNoCsBzZXQwIO8H bQKDAFARTTIKgAa0AoCWfQqACMg7CWIxOQ7AvwnDFnIKMhZxAoAVYioJsHMJ8ASQYXQFsg5QA2Bz om8BgCBFeBHBbhgwXQZSdgSQF7YCEHIAwHR9CFBuGjEQIAXABaAbZGSaIANSIBAiF7JcdgiQ5Hdr C4BkNR1TBPAHQA0XcDAKcRfyYmttawZzAZAAICBCTV9C4EVHSU59CvwB8QvyimwLgGUKgEFjawmA AC1CeTogVmlrSmEEIEMR0HVkEdF5bCA8HWAiwS4RwSM0QLpxCQBnDlAkAANwPiGVCyVvIcJPA6Ay Ni8wEDcvMTQnQDoxMYAgcG0sICJBHnBmeABwBIEgRwWwAQBlpHYiI5BhZyk0QAlxZRHQdCUTIHcD YBAgOjUl3D4nIVcJgChQSnV5AyAxNihQAdAnsRiAIEAwODowNTonUFDQTSArMAHQMChQKI+1Kww+ KvBBBCAJcHMs8GsFQBkwIAEAcAlwHlB0DmkCIDGyBeBJLVgv/TLhIAnwAaAecAeAAjAccDh1bmMy Yg4AMJdwYyRpXzOEX20AkHgoriktoB3ANV1fAmBvIhB1NlJsAyBkBRAaMTS5dTcAkBnAHMBoB5AZ 4HR37G8gC4AboWYA0AeRGFATHFEYkCBiGeB1cGT/GIA7VDmAOiE58DCIGFAH4P82zRhwGcE2UTGw BcA2zSih/zRgNlAwiDaPNjA+xz9vQrCbQI86iC4r5ivmSGkilNYsRk4IUWwcYHkIYCgg3x5wItAZ 4AlwGjBpB+A54K8EACggGIARwD9GTlQZoY0fUCFGTirwU2lnGFDjIkAZMGYtYiJxLw8pr/MlGjDx Q2MijyOfJK9RR/UEAGMAkC04dFPZUPwhoUh1eC1VgkB2GDByRi4iIASgZWwuBbBn/1bvV/E1YVhv MJgiH1JfU29dUNotYHAwiDhmL1WCLzFfIGE0eGJgYhE0X2RueF5wIHw/QD9AMvcugGCaKBBmAxAH kRmULLEfKBALgBIAACA0gigrKe9lYgEAHnBl9C1A6TCIDeDPASBgYSTgBUBhL2FfYmo9MIdiaX9q j0U2AQB4IAg5ZGJu4DRiLi6AN2MzMzY1OC0Q8R6gNjQ0X9tpX2zvMKY+K3OwO6BxP3JPMMRAQIFg YDQyMjEsNy6A53bFdoFiIl84YmE1mx9gVHJ1NGAgVYJfYiFf9mgZEAVAKhHQQOkDMAGRqxxwBbEo R1A9LdA7OnBBXgAgUUxBXzLhWABfRU5UUklFUz98cXOwes57gzPxCIFzW/hpXS5/cl3wfEB36EQ0 /3+NFiB66V/oe4MJcAVAfEDzNW4R0C0+O/ApcChQf3VBLuFSUkFZXzLwWqRFKH91KSmCmSuED/9D 7oW/hs+H3nt0BpB8AIkx/TZgXAAAfk97sGKiMhA6gYE38EtFUk5fV4wg+k4gIEcoUBHQR8d+umNC 9iIy41zwRgtwHnA7YzOEG3mgO+BwCRFgYSAlZMIvleBcXG4ikhlw8e0wiDFvUJgBNmd/RreXKfhS ZWcLEUe4To8r5k+/D1bHIZUVQp+QAAAAHwBCAAEAAAAgAAAAVgBpAGsAYQBzACAAQwBoAGEAdQBk AGgAYQByAHkAAAAfAGUAAQAAADYAAAB2AGkAawBhAHMALgBjAGgAYQB1AGQAaABhAHIAeQBAAHEA bABvAGcAaQBjAC4AYwBvAG0AAAAAAB8AZAABAAAACgAAAFMATQBUAFAAAAAAAAIBQQABAAAAeAAA AAAAAACBKx+kvqMQGZ1uAN0BD1QCAAAAgFYAaQBrAGEAcwAgAEMAaABhAHUAZABoAGEAcgB5AAAA UwBNAFQAUAAAAHYAaQBrAGEAcwAuAGMAaABhAHUAZABoAGEAcgB5AEAAcQBsAG8AZwBpAGMALgBj AG8AbQAAAB8AAl0BAAAANgAAAHYAaQBrAGEAcwAuAGMAaABhAHUAZABoAGEAcgB5AEAAcQBsAG8A ZwBpAGMALgBjAG8AbQAAAAAAHwDlXwEAAAA+AAAAcwBpAHAAOgB2AGkAawBhAHMALgBjAGgAYQB1 AGQAaABhAHIAeQBAAHEAbABvAGcAaQBjAC4AYwBvAG0AAAAAAB8AGgwBAAAAIAAAAFYAaQBrAGEA cwAgAEMAaABhAHUAZABoAGEAcgB5AAAAHwAfDAEAAAA2AAAAdgBpAGsAYQBzAC4AYwBoAGEAdQBk AGgAYQByAHkAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAAAAfAB4MAQAAAAoAAABTAE0AVABQAAAA AAACARkMAQAAAHgAAAAAAAAAgSsfpL6jEBmdbgDdAQ9UAgAAAIBWAGkAawBhAHMAIABDAGgAYQB1 AGQAaABhAHIAeQAAAFMATQBUAFAAAAB2AGkAawBhAHMALgBjAGgAYQB1AGQAaABhAHIAeQBAAHEA bABvAGcAaQBjAC4AYwBvAG0AAAAfAAFdAQAAADYAAAB2AGkAawBhAHMALgBjAGgAYQB1AGQAaABh AHIAeQBAAHEAbABvAGcAaQBjAC4AYwBvAG0AAAAAAB8A+D8BAAAAIAAAAFYAaQBrAGEAcwAgAEMA aABhAHUAZABoAGEAcgB5AAAAHwAjQAEAAAA2AAAAdgBpAGsAYQBzAC4AYwBoAGEAdQBkAGgAYQBy AHkAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAAAAfACJAAQAAAAoAAABTAE0AVABQAAAAAAACAfk/ AQAAAHgAAAAAAAAAgSsfpL6jEBmdbgDdAQ9UAgAAAIBWAGkAawBhAHMAIABDAGgAYQB1AGQAaABh AHIAeQAAAFMATQBUAFAAAAB2AGkAawBhAHMALgBjAGgAYQB1AGQAaABhAHIAeQBAAHEAbABvAGcA aQBjAC4AYwBvAG0AAAAfAAldAQAAADYAAAB2AGkAawBhAHMALgBjAGgAYQB1AGQAaABhAHIAeQBA AHEAbABvAGcAaQBjAC4AYwBvAG0AAAAAAB8AMUABAAAAAgAAAAAAAAALAEA6AQAAAB8AMEABAAAA AgAAAAAAAAAfABoAAQAAABIAAABJAFAATQAuAE4AbwB0AGUAAAAAAAMA8T8JBAAACwBAOgEAAAAD AP0/5AQAAAIBCzABAAAAEAAAAM/wuANCVBVAmYECNhR5wnoDABcAAQAAAEAAOQCAPXyvWarPAUAA CDCAiwCwWarPAQsAAIAIIAYAAAAAAMAAAAAAAABGAAAAABSFAAABAAAAHwAAgIYDAgAAAAAAwAAA AAAAAEYBAAAAHgAAAGEAYwBjAGUAcAB0AGwAYQBuAGcAdQBhAGcAZQAAAAAAAQAAAAwAAABlAG4A LQBVAFMAAAALAACACCAGAAAAAADAAAAAAAAARgAAAAAGhQAAAAAAAB8ANwABAAAAvAAAAFIAZQA6 ACAAWwBQAEEAVABDAEgAIAB2ADIAIABSAEUAUwBFAE4ARAAgADIAMgAvADIAMwBdACAAcQBsAGEA NAB4AHgAeAA6ACAAVQBzAGUAIABwAGMAaQBfAGUAbgBhAGIAbABlAF8AbQBzAGkAeABfAGUAeABh AGMAdAAoACkAIABpAG4AcwB0AGUAYQBkACAAbwBmACAAcABjAGkAXwBlAG4AYQBiAGwAZQBfAG0A cwBpAHgAKAApAAAAHwA9AAEAAAAKAAAAUgBlADoAIAAAAAAAAwA2AAAAAAAfAEIQAQAAAGoAAAA8 ADIAMAAxADQAMAA3ADIANgAwADgANAAxADMANwAuAEcATAAyADEAMQAyADkAQABhAGcAbwByAGQA ZQBlAHYALgB1AHMAZQByAHMAeQBzAC4AcgBlAGQAaABhAHQALgBjAG8AbQA+AAAAAAACAXEAAQAA ACAAAAABAc+hIIhGsC6kDjV5SZ2qLJ7GGuA4m7KN6wCAA7S2AB8AcAABAAAAtAAAAFsAUABBAFQA QwBIACAAdgAyACAAUgBFAFMARQBOAEQAIAAyADIALwAyADMAXQAgAHEAbABhADQAeAB4AHgAOgAg AFUAcwBlACAAcABjAGkAXwBlAG4AYQBiAGwAZQBfAG0AcwBpAHgAXwBlAHgAYQBjAHQAKAApACAA aQBuAHMAdABlAGEAZAAgAG8AZgAgAHAAYwBpAF8AZQBuAGEAYgBsAGUAXwBtAHMAaQB4ACgAKQAA AB8ANRABAAAAeAAAADwAMwBGAEMANABBAEIAOABCADQANwBFAEMARAA1ADQANgBCAEMARAA0AEIA MwA2ADEAQQA2ADQAQgBFAEEAQwBEADgAQwA2AEMAQQBGAEQAMgBAAGEAdgBtAGIAMwAuAHEAbABv AGcAaQBjAC4AbwByAGcAPgAAAB8AORABAAAAXAEAADwAYwBvAHYAZQByAC4AMQA0ADAANQA1ADMA MwA0ADcAOQAuAGcAaQB0AC4AYQBnAG8AcgBkAGUAZQB2AEAAcgBlAGQAaABhAHQALgBjAG8AbQA+ ACAAPAAwADQAOQA2AGMAYwBiAGMAMABmADIAMAAzAGEAZgBhAGUAZQBiADcANwA1ADgAYwAxADQA NgBiADkAMwBjADIAZgAzADgANwA2ADgANABjAC4AMQA0ADAANQA1ADMAMwA0ADcAOQAuAGcAaQB0 AC4AYQBnAG8AcgBkAGUAZQB2AEAAcgBlAGQAaABhAHQALgBjAG8AbQA+ACAAPAAyADAAMQA0ADAA NwAyADYAMAA4ADQAMQAzADcALgBHAEwAMgAxADEAMgA5AEAAYQBnAG8AcgBkAGUAZQB2AC4AdQBz AGUAcgBzAHkAcwAuAHIAZQBkAGgAYQB0AC4AYwBvAG0APgAAAAMA3j+fTgAAQAAHMGNn+a9Zqs8B AwAmAAAAAAACAUcAAQAAAC4AAABjPVVTO2E9IDtwPVFMb2dpYztsPUFWTUIzLTE0MDcyODExNDcx OVotNDM2MDUAAAAfABUQAQAAAFgAAAA5AEIAMAA1ADQARAA1ADkAQgBBADIARgBFADQANABCAEIA MgAzADEANwA4ADEAMAA1ADUARQBEADcAQQAyADkAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAAgEU MAEAAAAMAAAAgwAAAB35fFJBAAAAHwD6PwEAAAAgAAAAVgBpAGsAYQBzACAAQwBoAGEAdQBkAGgA YQByAHkAAAAfAACAhgMCAAAAAADAAAAAAAAARgEAAAAWAAAAdQBzAGUAcgAtAGEAZwBlAG4AdAAA AAAAAQAAAEYAAABNAGkAYwByAG8AcwBvAGYAdAAtAE0AYQBjAE8AdQB0AGwAbwBvAGsALwAxADQA LgAzAC4AOQAuADEAMwAxADAAMwAwAAAAAAAfAACAH6TrM6h6LkK+e3nhqY5UswEAAAA4AAAAQwBv AG4AdgBlAHIAcwBhAHQAaQBvAG4ASQBuAGQAZQB4AFQAcgBhAGMAawBpAG4AZwBFAHgAAAABAAAA OgEAAEkASQA9ADAAMQAwADEAQwBGAEEAQQA1ADkAQgAwADUANwA4ADUARQBEAEQANQA0ADEAQwAw ADgAQQA0ADkAOQBGAEIANwBDADkAOABDAEUAMwBEADYARQBFADYANgA7AFMAQgBNAEkARAA9ADMA OwBTADEAPQA8ADIAMAAxADQAMAA3ADIANgAwADgANAAxADMANwAuAEcATAAyADEAMQAyADkAQABh AGcAbwByAGQAZQBlAHYALgB1AHMAZQByAHMAeQBzAC4AcgBlAGQAaABhAHQALgBjAG8AbQA+ADsA VgBlAHIAcwBpAG8AbgA9AFYAZQByAHMAaQBvAG4AIAAxADQALgAyACAAKABCAHUAaQBsAGQAIAAz ADgANwAuADAAKQAsACAAUwB0AGEAZwBlAD0ASAAyAAAAAAADAA00/T8AAB8AAICGAwIAAAAAAMAA AAAAAABGAQAAACAAAAB4AC0AbQBzAC0AaABhAHMALQBhAHQAdABhAGMAaAAAAAEAAAACAAAAAAAA AB8AAICGAwIAAAAAAMAAAAAAAABGAQAAACIAAAB4AC0AbwByAGkAZwBpAG4AYQB0AGkAbgBnAC0A aQBwAAAAAAABAAAAGAAAAFsAMQAwAC4AMQAuADQALgAxADAAXQAAAB8AAICGAwIAAAAAAMAAAAAA AABGAQAAABYAAABkAGkAcwBjAGwAYQBpAG0AZQByAAAAAAABAAAADgAAAGIAeQBwAGEAcwBzAAAA AAAcxw== --_000_3FC4AB8B47ECD546BCD4B361A64BEACD8C6CAFD2avmb3qlogicorg_--