--- linux-2.6/fs/namei.c-opendir 2003-12-20 21:32:50.000000000 -0800 +++ linux-2.6/fs/namei.c 2003-12-21 01:37:09.000000000 -0800 @@ -1295,7 +1295,12 @@ if (!dentry->d_inode) { if (!IS_POSIXACL(dir->d_inode)) mode &= ~current->fs->umask; - error = vfs_create(dir->d_inode, dentry, mode, nd); + if (unlikely(flag & O_DIRECTORY)) { + error = -EISDIR; + if (!(flag & FMODE_WRITE)) + error = vfs_mkdir(dir->d_inode, dentry, mode); + } else + error = vfs_create(dir->d_inode, dentry, mode, nd); up(&dir->d_inode->i_sem); dput(nd->dentry); nd->dentry = dentry; @@ -1331,7 +1336,11 @@ dput(nd->dentry); nd->dentry = dentry; error = -EISDIR; - if (dentry->d_inode && S_ISDIR(dentry->d_inode->i_mode)) + /* Since we allow creating directories with open(2) we forbid + opening an existing directory with O_CREAT only if the + O_DIRECTORY flag is not set or if truncation is requested. */ + if (dentry->d_inode && S_ISDIR(dentry->d_inode->i_mode) && + (!(flag & O_DIRECTORY) || (flag & O_TRUNC))) goto exit; ok: error = may_open(nd, acc_mode, flag);